Re: Krita supports OpenColorIO


Jeremy Selan <jeremy...@...>
 

Boudewijn,

Kudos on the quick integration again! Can I see the code? Is there a
repo you can point us to?

Looking further at your example screenshot, I notice that you have
gamma set to 2.2, and exposure to 2.4. Were these particular values
just playing around with the UI, or are they the defaults? I would
expect the sliders for gamma to default to 1.0, and exposure to 0.0.
(Presuming you're linking up exposure with pow(2,exp), as ociodisplay
does).

The DisplayTransform gamma and exposure sliders are there to allow the
artist to preview / inspect the fidelity of there work, particularly
in the dark and bright regions. They are NOT there to account for the
display gamma. (This is traditionally done inside the OCIO profile,
and is not visible externally to the user). Does this make sense?

Also note that painting is rarely done directly in scene-linear
colorspace (HDR), so it's probably not the best default for input
color space. (Maybe some day it will, but not quite yet).

I would recommend querying
ColorSpace cs = config->getColorSpace(OCIO::ROLE_TEXTURE_PAINT)
if(cs) cs->getName()

This is how mari find the default color space. You could also query
MATTE_PAINT if you think that's more likely for artists in krita to
use.

If you test with a profile that uses a film emulation lut (such as
spi-vfx), by switching between "Film" and "Raw" you'll be able to see
the 3D color warp that would be anticipated in a theatrical context.

-- Jeremy

On Fri, Jun 15, 2012 at 8:17 AM, Boudewijn Rempt <bo...@...> wrote:
Hi!

So... Basically Krita now supports OpenColoriO :-). I've used the display
example as suggested and implemented both the CPU and the GPU path.
Everything seems to be working fine, and fast. See
http://www.valdyas.org/~boud/krita_opencolor_io.jpg. I'm not sure whether
this feature will be in the 2.5 release since we're branching for the
release today, and I'm hesistant to merge a huge branch without much review.

Thanks for the help.

Join {ocio-dev@lists.aswf.io to automatically receive all group messages.