Re: Review: Visual Studio 2010 compile fix Edit


Richard Shaw <hobbe...@...>
 

On Fri, Dec 14, 2012 at 8:37 PM, Jeremy Selan <jeremy...@...> wrote:
http://github.com/imageworks/OpenColorIO/pull/300

Frederik has submitted a bunch of changes related to Visual Studio
2010 compatibility and STATIC linking.

As this touches CMake mojo as used on linux / osx, would those
familiar with package management please check this request out?
Ok, first problem. When I apply the patch to 1.0.8 I get the following
on my Linux build:

cd /home/build/rpmbuild/OpenColorIO/BUILD/OpenColorIO-1.0.8/build/docs/setuptools-prefix/src/setuptools
&& /usr/bin/cmake -E touch
/home/build/rpmbuild/OpenColorIO/BUILD/OpenColorIO-1.0.8/build/docs/setuptools-prefix/src/setuptools-stamp/setuptools-build
/usr/bin/cmake -E cmake_progress_report
/home/build/rpmbuild/OpenColorIO/BUILD/OpenColorIO-1.0.8/build/CMakeFiles
/home/build/rpmbuild/OpenColorIO/BUILD/OpenColorIO-1.0.8/src/core/PathUtils.cpp:52:15:
error: previous declaration of 'char** environ' with 'C++' linkage
In file included from
/home/build/rpmbuild/OpenColorIO/BUILD/OpenColorIO-1.0.8/src/core/PathUtils.cpp:55:0:
/usr/include/unistd.h:546:15: error: conflicts with new declaration
with 'C' linkage
/home/build/rpmbuild/OpenColorIO/BUILD/OpenColorIO-1.0.8/src/core/PathUtils.cpp:
In function 'std::string OpenColorIO::v1::pystring::os::getcwd()':
/home/build/rpmbuild/OpenColorIO/BUILD/OpenColorIO-1.0.8/src/core/PathUtils.cpp:125:33:
warning: ignoring return value of 'char* getcwd(char*, size_t)',
declared with attribute warn_unused_result [-Wunused-result]
make[2]: *** [src/core/CMakeFiles/OpenColorIO.dir/PathUtils.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....

Richard

Join ocio-dev@lists.aswf.io to automatically receive all group messages.