Re: Review: Visual Studio 2010 compile fix Edit


Richard Shaw <hobbe...@...>
 

I'm not sure if this is causing any issues:

diff --git a/src/core/PathUtils.cpp b/src/core/PathUtils.cpp
index a04ecee..4c944b1 100644
--- a/src/core/PathUtils.cpp
+++ b/src/core/PathUtils.cpp
@@ -49,10 +49,14 @@
#if defined(__APPLE__) && !defined(__IPHONE__)
#include <crt_externs.h> // _NSGetEnviron()
#elif !defined(WINDOWS)
-#include <unistd.h>
extern char **environ;
#endif

+#include <unistd.h>
+#if defined(__clang__)
+#include <unistd.h>
+#endif


Is it a problem to include the same header twice? I'm not sure what we
should be doing differently for clang.

Richard

Join ocio-dev@lists.aswf.io to automatically receive all group messages.