Malcolm Humphreys <malcolmh...@...>
This looks all pretty good to me
A bunch of changes related to yaml serialization:- Can we call AddBaseTransformPropertiesToYAMLMap = EmitBaseTransformKeyValues
- Can we call ReadBaseTransformPropertiesFromYAMLMap = ReadBaseTransformKeyValues, and can the argument order be swaped to match the other >> operators ie. (TransformRcPtr & t, const YAML::Node & node) -> (const YAML::Node & node, TransformRcPtr &)
* Roles survive a yaml round trip+1 I like this being a map, I'm not sure if order is important.
* Most transforms serialize in Flow form for better readabilityYeah most of our yamls are hand written with big breaks between sections, so this hasn't really been an issue.
One possible way would be using YAML::Comment with some new line chars, but it would be much nicer to have something like out << YAML::NewLines(3) that you could use.
void MultiLineComment(YAML::Emitter& out, std::string& desiredOutput)
out << YAML::BeginSeq;
out << "item 1" << YAML::Comment("really really long\ncomment that couldn't possibly\nfit on one line");
out << "item 2";
out << YAML::EndSeq;
desiredOutput = "---\n- item 1 # really really long\n # comment that couldn't possibly\n # fit on one line\n- item 2";