Re: Review: OCIO namespace update


Malcolm Humphreys <malcolmh...@...>
 

I think your missing a set() line in the CMakeLists.txt eg.
..
set(OCIO_VERSION "${OCIO_VERSION_MAJOR}.${OCIO_VERSION_MINOR}.${OCIO_VERSION_PATCH}")
set(OCIO_NAMESPACE OpenColorIO)
..

Other than that it LGTM.

.malcolm

On 27/10/2010, at 9:16 AM, Jeremy Selan wrote:

OCIO namespace #define is now configured using the CMAKE
configure_file mojo.  This makes namespace errors far less likely, as
it's baked into the header that's a part of make_install.

commits:
d00581c9373806b85416115a58488d57a12be04a

Join ocio-dev@lists.aswf.io to automatically receive all group messages.