Re: Review: Support python with --exec-prefix and registering Nuke viewer processes
|
Jeremy Selan <jeremy...@...>
Thanks for the commits!
toggle quoted messageShow quoted text
Look great at first glance. (I'll run it all this afternoon to make sure it works multi-platform, etc). I like all the nuke cleanup, very sensible. My one concern is I'm not convinced the pre-filled display nodes at startup are appropriate in menu.py. Your new code is an excellent example to point folks in the right direction, but it may a bit too overbearing to actually create instances for the user at startup. Would you expect the average facility to use the code, as written? Or, is this just an example which you would expect people to customize? Perhaps this function should be in a different file, which the user is encouraged to customize as needed? You can link into the viewer's gain/gamma (just make an expression to Viewer1.gain, Viewer1.gamma), but there's no way to prevent nuke from applying the cc math when the sliders are moved. In the short term maybe the foundry could expose monitor options to disable the gain/gamma math? (In the long terms, there's potential to have nuke directly ship with builtin OCIO color management) -- Jeremy
On Tue, Jan 11, 2011 at 4:28 AM, dbr/Ben <dbr....@...> wrote:
I've made a few minor changes, partly to familiarise myself with the
|
|
|