Re: Building issues with gcc


Jeff Clifford <j...@...>
 

Hi Jeremy,

Thanks for getting back to me so fast.

I can confirm already that omitting the -fvisibility-inlines-hidden from just CMakeLists.txt works.

I can also confirm that the issue doesn't occur for our gcc4.3.3 build - only for our gcc4.1.2 build.

Thanks,

Jeff.

Jeremy Selan wrote:

I've pushed the fix for CMAKE_CXX_FLAGS to master. Thanks for pointing that out.

As for -fvisibility-inlines-hidden, the only places that appears in OCIO are:
CMakeLists.txt
ext/tinyxml_2_6_1.patch
ext/yaml-cpp-r482.patch

Would you try commenting out the offending lines, and see if that can build on your gcc version?

There are currently checks for CMAKE_COMPILER_IS_GNUCXX around these lines, and if we can confirm that older gccs dont support this option I'm happy to add an additional gcc version check as well.

-- Jeremy

On Thu, Dec 8, 2011 at 8:57 AM, Jeremy Selan <jeremy...@... <mailto:jeremy...@...>> wrote:

I'll hold off on commenting on the first issue for the moment, but
the 2nd issue (not preserving incoming CMAKE_CXX_FLAGS) is clearly
an oversight. I'll check in a fix today.

-- Jeremy


------------------------------------------------------------------------

No virus found in this message.
Checked by AVG - www.avg.com <http://www.avg.com>
Version: 10.0.1415 / Virus Database: 2102/4067 - Release Date: 12/08/11

Join ocio-dev@lists.aswf.io to automatically receive all group messages.