Review: After Effects plug-in


Brendan Bolles <bre...@...>
 

Got a sizable pull request to add the AE plug-in:

https://github.com/imageworks/OpenColorIO/pull/272

Here's what I wrote in the comments:

Have the After Effects plug-in ready to integrate. It has been through
a few revisions and some production testing.

As you would expect, this requires the After Effects SDK. I'm
currently pointing to a copy in the ext/ folder.

The After Effects SDK uses Xcode and Visual Studio to build the
samples, so that's what this plug-in is built with. It does not use
CMake, and it uses hard-coded OpenColorABI.h configuration files as a
result. Hopefully someone who knows CMake would be willing to try to
integrate the AE plug-in with the regular build system in the future.
In the meantime, do people want to add the Xcode and Visual Studio
projects to the OCIO repository, or just leave them out?

There are also a few changes to core files where doing &my_vec[0] on
an empty vector was causing a crash with Visual Studio, as opposed to
returning NULL as it does with GCC.

Join ocio-dev@lists.aswf.io to automatically receive all group messages.