Date   

Review: added TestForDDImageVersion.cxx to support multiple versions of nuke

Malcolm Humphreys <malcolmh...@...>
 

(excuse the typos in the actual commit msg)

Added TestForDDImageVersion.cxx to FindNuke.cmake so that we can workout which version of nuke we are building against. This now gets appended to the '$CMAKE_INSTALL_PREFIX/lib/nuke${Nuke_DDImageVersion}'. This makes it easier to build and run against multiple versions of nuke.

Added init.py and menu.py so that the ocio nuke plugins can be setup with the NUKE_PATH searchpath, to make it easier to test and integrate into our toolchains.

Updated the INSTALL file to reflect these changes.

https://github.com/malcolmhumphreys/OpenColorIO/commit/8d45b1dd71b845cc3b685263f365f25358ad8c68

.malcolm


Review: Added ${Boost_INCLUDE_DIR} to the nuke CMakeLists.txt

Malcolm Humphreys <malcolmh...@...>
 

Added ${Boost_INCLUDE_DIR} to the nuke CMakeLists.txt, this is temp till we remove '#include <boost/shared_ptr.hpp>' from OpenColorTypes.h
https://github.com/malcolmhumphreys/OpenColorIO/commit/0077676cd4e44b03df3e0931d594f350fba3fef9

We don't have the boost headers on our linux image so this was failing to build the nuke plugins.

.malcolm


OCIO 0.7.2 released

Jeremy Selan <jeremy...@...>
 

Version 0.7.2 (Dec 9 2010):
    * GPUAllocation refactor (API tweak)
    * Added AllocationTransform
    * Added LogTransform
    * Removed CineonLogToLinTransform
    * A few bug fixes

Available for download,

Updated configurations and example images will also be posted shortly.


Re: Review: Added 'pure' LogTransform

Jeremy Selan <jeremy...@...>
 

Looks good to myself!
:)


Re: Review: AllocationTransform

Jeremy Selan <jeremy...@...>
 

No objections? Rolling it in...


Re: Review: Bugfix for Nuke LogConvert

Jeremy Selan <jeremy...@...>
 

No one objected, so I've merged this in.


Re: Review: Inital pass at searchpath impl

Malcolm Humphreys <malcolmh...@...>
 

How about we shoot for tomorrow, I'm still getting backup to speed with things.

.malcolm

On 07 Dec, 2010,at 09:08 AM, Jeremy Selan <jere...@...> wrote:

What's your schedule like this week? Up for a conference call? I'd
like to primarily discuss the env-vars / 'globals' / per-shot cc look
options.

-- Jeremy


Review: Added 'pure' LogTransform

Jeremy Selan <jeremy...@...>
 

As a pseudo-replacement for the CineonLogTransform, added
LogTransform. This is the pure mathematical Log operator, with a user
configurable base.

Commits:
7f7ad979

-- Jeremy


Re: Review: Inital pass at searchpath impl

Malcolm Humphreys <malcolmh...@...>
 

* I like supporting only strings for now. In the future, I can also
see numbers being supported (such as allowing for CDL blocks that rely
on envvars), but this can be added as needed.
It would also be super nice if the CDLTransform supported the full Color Correction Collection (CCC) in the CDL spec, where you could have something along the lines of '!<CDLTransform> { src: '/path/to/basegrades.ccc', id: '${SEQ}_${SHOT}_balance' }'.
* The FileTransform will probably have to get a bit smarter. Say
you're using a pershot lut, and for some shots you dont want any such
table. This could be solved by either not installing a lut in the
expected location, or by installing an identity lut. Which is
preferable? In the current implementation, if a lut is not found
this is always an error condition. Maybe we should introduce on the
FilmTransform a 'silent error mode', where this would just skip the
application of that specific LUT?
Keep the system simple let it error, it should be up to the user to setup the searchpath so that an identity lut is found if other paths fail to resolve to a lut.

It might be an idea to make this case not an exception, but a error which gets sent through some kind or error handler.

* The "globals" pre-declaration could also define an optional default
(used if the envvar is not set). If the envvar is not set, and no
default is specified, any references to the global variable would
probably be an error.
+1

.malcolm


Re: Review: Inital pass at searchpath impl

Jeremy Selan <jeremy...@...>
 

What's your schedule like this week? Up for a conference call? I'd
like to primarily discuss the env-vars / 'globals' / per-shot cc look
options.

-- Jeremy


Re: Review: Inital pass at searchpath impl

Jeremy Selan <jeremy...@...>
 

Next week will be fantastic. Welcome back.
-- Jeremy

On Fri, Dec 3, 2010 at 8:05 PM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:
Hi Jeremy,
On 04/11/2010, at 3:32 PM, Malcolm Humphreys wrote:

I'm going to be out of town for the remainder of the week, perhaps we
could try an internet call early next week to discuss these specifics
further? (Skype, iChat, etc). Many of these points can probably be
hashed out easier live, and then we can summarize our thoughts back to
the list.


It might have to wait a few weeks, I'm in Hong Kong right now and I'm going
to be MIA in asia for a bit.

But yes a chat would be good when we are both free.

Just letting you know I'm back from Holidays now, I'll try and go back
through
and review what I have missed.
And we should line up a chat maybe next week if you are around.
.malcolm


Re: Review: Inital pass at searchpath impl

Malcolm Humphreys <malcolmh...@...>
 

Hi Jeremy,

On 04/11/2010, at 3:32 PM, Malcolm Humphreys wrote:
I'm going to be out of town for the remainder of the week, perhaps we
could try an internet call early next week to discuss these specifics
further? (Skype, iChat, etc). Many of these points can probably be
hashed out easier live, and then we can summarize our thoughts back to
the list.
 
It might have to wait a few weeks, I'm in Hong Kong right now and I'm going to be MIA in asia for a bit.

But yes a chat would be good when we are both free.

Just letting you know I'm back from Holidays now, I'll try and go back through
and review what I have missed.

And we should line up a chat maybe next week if you are around.

.malcolm



Review: Bugfix for Nuke LogConvert

Jeremy Selan <jeremy...@...>
 

Nuke's OCIOLogConvert node was being applied in the wrong direction.
(What was listed as log->lin was actually the opposite).

Commits:
b5bd0c824

Issue:
http://github.com/imageworks/OpenColorIO/issues#issue/9

-- Jeremy


Review: Removed CineonLogToLin Transform

Jeremy Selan <jeremy...@...>
 

CineonLogToLin was always occupying a sort of transform netherworld.
It's too specific to count as 'general math', but not specific enough
to be useful in many practical cases for linearizing film data. This
transform was a late addition to OCIO (it did not appear in Sony's in
house predecessor), and upon further consideration is not worth
keeping.

For those interested in doing this conversion in the future, we would
recommend using a 1D LUT, or using the log allocation transform. An
example of the 1D lut approach is demonstrated in the spi-vfx profile,
and an example of the Allocation approach is in the iif profile.

Issue:
http://github.com/imageworks/OpenColorIO/issues#issue/12

Commits:
11c19f7bf26298dd95bf63a9ba59dc63ebf7a093

-- Jeremy


Review: AllocationTransform

Jeremy Selan <jeremy...@...>
 

These add a new transform type, AllocationTransform, which is useful
in mapping HDR color ranges into LDR code spaces. Two options are
supported: a uniform allocation, and a log-2 allocation, and the
specific math corresponds to the gpu allocation options already used
internally. This transform is useful for applying LUTs to HDR
imagery (for example in the upcoming IIF profile).

Commits:
105dba932d32970d4cbb6d4fee77be99a18334a5
4b50d7b222538f637abd11fb03616e60ee2c73ab

Issue:
https://github.com/imageworks/OpenColorIO/issues#issue/11

-- Jeremy


Re: Review: removed TODO

Jeremy Selan <jeremy...@...>
 

Merging this into trunk, no objections.
-- Jeremy


Coming soon: Initial IIF support

Jeremy Selan <jeremy...@...>
 

For those not familiar with the IIF project, the Academy is
sponsoring a project to standardize a single floating-point linear
workflow across the motion picture industry:

http://www.oscars.org/science-technology/council/projects/iif.html

One of the core developer, Alex Forsythe, was kind enough to sit down
with me and spec out what an OCIO implementation of the IIF workflow
would look like. It was a great learning experience (trying to port
a non-sony workflow to OpenColorIO), and we learned a lot about making
OCIO easier to use. Expect to see a bunch of improvements in the next
few weeks related to LUT generation, allocation, baking, import,
export, etc.

Also, hopefully in the next week or two we'll also put out a first
'prototype' IIF / ACES OpenColorIO configuration. This will allow
anyone with an existing OCIO setup to test the IIF workflow. (which is
the whole promise of this project)!

(Note that in the near term, the OCIO profile will not execute the CTL
(Color transformation language) directly, but instead will rely on a
manual port of the existing transformation logic.)

-- Jeremy


Review: removed TODO

Jeremy Selan <jeremy...@...>
 

I've removed the TODO file internal to the codebase, in favor of the
github issue tracking. (Which is really nice!)

Please feel free to add any issues (bugs or features) to this list as
you encounter them. Thanks!

https://github.com/imageworks/OpenColorIO/issues

commit:
8cf3d4a18

-- Jeremy


Re: Review: API Change to ColorSpace.GPUAllocation

Jeremy Selan <jeremy...@...>
 

No one has objected, so I'll roll this into the master branch.

-- Jeremy

On Nov 16, 11:43 am, Jeremy Selan <jeremy...@gmail.com> wrote:
This updates the API for setting the ColorSpace GPU allocation hint.
(The allocation is used to determine how a particular lattice is best
sampled using a fixed domain lut on the GPU).  Previously all
allocations were configured with 2 fixed arguments (min, max):

Prior:
Uniform:    x mapped from  [min, max] to [0,1]
Log2         log2(x) mapped from [min, max] to [0,1]

Now, allocations can be configured with a variable number of
arguments. (The definition of which is allocation specific).  This is
useful as it allows for (optionally) more sophisticated allocations on
the GPU.   The first allocation to take advantage of this is "LG2",
which adds a linear offset value as the 3rd variable:

Log2         log2(x+offset) mapped from [min, max] to [0,1]

Using a small, positive offset allows a log allocation to represent
the value 0.0 precisely, which is useful in some configurations.

This update also names GpuAllocation -> Allocation, as what it
represents is not GPU specific. (GPU is the use case, rather than the
description of what the data is).

Commits:
3f12fca8bf0aff910a4989b855d711ab609b61f9
e780e5d21333aca75de25403dd56852da17a7517
d17a6530982b86b5ef51601aae97a76e1c2da59d

-- Jeremy


Review: API Change to ColorSpace.GPUAllocation

Jeremy Selan <jeremy...@...>
 

This updates the API for setting the ColorSpace GPU allocation hint.
(The allocation is used to determine how a particular lattice is best
sampled using a fixed domain lut on the GPU). Previously all
allocations were configured with 2 fixed arguments (min, max):

Prior:
Uniform: x mapped from [min, max] to [0,1]
Log2 log2(x) mapped from [min, max] to [0,1]

Now, allocations can be configured with a variable number of
arguments. (The definition of which is allocation specific). This is
useful as it allows for (optionally) more sophisticated allocations on
the GPU. The first allocation to take advantage of this is "LG2",
which adds a linear offset value as the 3rd variable:

Log2 log2(x+offset) mapped from [min, max] to [0,1]

Using a small, positive offset allows a log allocation to represent
the value 0.0 precisely, which is useful in some configurations.

This update also names GpuAllocation -> Allocation, as what it
represents is not GPU specific. (GPU is the use case, rather than the
description of what the data is).

Commits:
3f12fca8bf0aff910a4989b855d711ab609b61f9
e780e5d21333aca75de25403dd56852da17a7517
d17a6530982b86b5ef51601aae97a76e1c2da59d

-- Jeremy

1901 - 1920 of 2190