LGTM

I was thinking rather than having these in src/examples they should be src/apps as
they will be pretty useful things to have around.

.malcolm

While working on this ocio photoshop plugin I noticed a difference in the cpu vs gpu path.

Attached is a screenshot.

The image on top has been imported by the plugin already and processed on the cpu, while the dialog below is a GL canvas using the gpu path for preview.

I'm guessing this is the allocation we are using on the gpu?

.malcolm

Issue:
http://github.com/imageworks/OpenColorIO/issues#issue/51

Commit:
http://github.com/jeremyselan/OpenColorIO/commit/afe8a04366515a152197c345e0362bd6f5540c37

* Added makefile support for ociodisplay + ocioconvert.

These are built optionally, if one adds the proper cmake options.

Example:
mkdir -p build && cd build
mkdir -p install
cmake -D CMAKE_BUILD_TYPE=Release \
-D CMAKE_INSTALL_PREFIX=install \
-D USE_OPENGL=1 \
-D USE_OIIO=1 \
-D OIIO_PATH=/net/homedirs/jeremys/svn/oiio/dist/spinux1/ \
-D PYTHON=/usr/bin/python2.5 \
../
make -j8 && make install

setenv $LD_LIBRARY_PATH to include OIIO + OCIO
setenv $OCIO path to .config
ociodisplay <IMG>


-- Jeremy

LGTM

.malcolm

3 unrelated commits.

1) Updated an error message in config loading.
http://github.com/jeremyselan/OpenColorIO/commit/05b84bca45187f4f5f2c8117ce0bb2a553a36f16

2) GLSL shader doesnt use invalid keywords in 1.0 mode. Also works
around glsl bug on osx.
http://github.com/jeremyselan/OpenColorIO/commit/1b2f112e46b78c8a351f779c7467b2510ab311ad

3) config.parseColorSpaceFromString(...) no longer can return a null ptr.
http://github.com/jeremyselan/OpenColorIO/commit/380978b8d88b438da601de8ea5b6a29b7893f9ca

-- Jeremy

Done.

I've checked this into master, with a few changes:
* Nuke_INSTALL_PATH is now NUKE_INSTALL_PATH (all caps)

I know the old value predates this checkin, but now that it's
publicized I figure we should make it all caps to match all the other
CMake configuration options.

* OCIO python module is now put in the global namespace, so it's
available to other scripts (and the script panel).

* The ocio viewer mojo is not executed by default in menu.py. Users
are free to call ocio_populate_menu() though at any time to run the
code though.

-- Jeremy

On Tue, Jan 11, 2011 at 1:21 PM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:

It all looks great other than the ocio_viewer as I would need to disable this for our install.

I think the nuke nodes should only be registered as part of the ocio project initialisation.

Viewer gizmo's are normally a per company/project configuration, maybe it would be better to include this as a separate example gizmo for people to copy in to their setup.

.malcolm

On 12/01/2011, at 6:07 AM, Jeremy Selan wrote:

Thanks for the commits!

Look great at first glance.  (I'll run it all this afternoon to make
sure it works multi-platform, etc).  I like all the nuke cleanup, very
sensible.

My one concern is I'm not convinced the pre-filled display nodes at
startup are appropriate in menu.py.  Your new code is an excellent
example to point folks in the right direction, but it may a bit too
overbearing to actually create instances for the user at startup.
Would you expect the average facility to use the code, as written? Or,
is this just an example which you would expect people to customize?
Perhaps this function should be in a different file, which the user is
encouraged to customize as needed?

You can link into the viewer's gain/gamma (just make an expression to
Viewer1.gain, Viewer1.gamma), but there's no way to prevent nuke from
applying the cc math when the sliders are moved.    In the short term
maybe the foundry could expose monitor options to disable the
gain/gamma math?  (In the long terms, there's potential to have nuke
directly ship with builtin OCIO color management)

-- Jeremy


On Tue, Jan 11, 2011 at 4:28 AM, dbr/Ben <dbr....@gmail.com> wrote:

I've made a few minor changes, partly to familiarise myself with the
code, partly to say thanks for open-sourcing this extremely useful
project!


First change - there was a hardcoded Nuke path, which meant you
couldn't do "cmake -D Nuke_INSTALL_PATH=/blah". Not sure if there's a
reason this this was hardcoded, but it's a (trivially) nicer than
using the env-variable:

https://github.com/dbr/OpenColorIO/commit/321625205caa1ad9a8735571f617a226493c6b44


Second a slightly less trivial - to support Python installations that
use --exec-prefix to put arch-specific stuff in a separate directory -
before it would fail to compile, complaining "pyconfig.h was not
found" (I guess it's pretty uncommon to use --exec-prefix, as even
PyQT had/has this issue..)

Tested on CentOS, with the exec-prefix'd Python, and OS X 10.6 with
the default system Python, both worked work fine.

https://github.com/dbr/OpenColorIO/commit/131efac091419aaa9d7729ba7f330c241d75917f


Final two commits are to the init.py and menu.py - automagical loading/
menu'ing of the OCIO nodes, and a first attempt at registering
OCIODisplay nodes as Nuke viewer processes.

It adds one process for every display and every transform (e.g "Film1D
(sRGB)", "Log (sRGB)", "Film1D (P3)", "Log (P3)") - seemed like the
most Nuke'ish solution given the limitations of the viewer
customisation.

On that subject, I wonder if it's possible to somehow tie the viewer's
exposure/gamma controls to the OCIODIsplay node.. I suspect not
currently.

https://github.com/dbr/OpenColorIO/commit/0cdf665eba7bd9dbeadcb94d9d446a4424a81303
https://github.com/dbr/OpenColorIO/commit/8151eca9edf3acf027e2a60ea3857f2240af6461


As I said, nothing too exciting.. I'm hoping to integrate OCIO into
the pipeline at work soon, so will almost certainly have more patches/
questions/feature-requests soon!

Oh, I've not signed a CLA yet - these changes seemed trivial enough
for it not to be necessary, but I will do so soon. Let me know if this
is a problem

Anyway, thanks again to everyone involved in this project!
- Ben Dickson

It all looks great other than the ocio_viewer as I would need to disable this for our install.

I think the nuke nodes should only be registered as part of the ocio project initialisation.

Viewer gizmo's are normally a per company/project configuration, maybe it would be better to include this as a separate example gizmo for people to copy in to their setup.

.malcolm

Thanks for the commits!

Look great at first glance. (I'll run it all this afternoon to make
sure it works multi-platform, etc). I like all the nuke cleanup, very
sensible.

My one concern is I'm not convinced the pre-filled display nodes at
startup are appropriate in menu.py. Your new code is an excellent
example to point folks in the right direction, but it may a bit too
overbearing to actually create instances for the user at startup.
Would you expect the average facility to use the code, as written? Or,
is this just an example which you would expect people to customize?
Perhaps this function should be in a different file, which the user is
encouraged to customize as needed?

You can link into the viewer's gain/gamma (just make an expression to
Viewer1.gain, Viewer1.gamma), but there's no way to prevent nuke from
applying the cc math when the sliders are moved. In the short term
maybe the foundry could expose monitor options to disable the
gain/gamma math? (In the long terms, there's potential to have nuke
directly ship with builtin OCIO color management)

-- Jeremy

I've made a few minor changes, partly to familiarise myself with the
code, partly to say thanks for open-sourcing this extremely useful
project!


First change - there was a hardcoded Nuke path, which meant you
couldn't do "cmake -D Nuke_INSTALL_PATH=/blah". Not sure if there's a
reason this this was hardcoded, but it's a (trivially) nicer than
using the env-variable:

https://github.com/dbr/OpenColorIO/commit/321625205caa1ad9a8735571f617a226493c6b44


Second a slightly less trivial - to support Python installations that
use --exec-prefix to put arch-specific stuff in a separate directory -
before it would fail to compile, complaining "pyconfig.h was not
found" (I guess it's pretty uncommon to use --exec-prefix, as even
PyQT had/has this issue..)

Tested on CentOS, with the exec-prefix'd Python, and OS X 10.6 with
the default system Python, both worked work fine.

https://github.com/dbr/OpenColorIO/commit/131efac091419aaa9d7729ba7f330c241d75917f


Final two commits are to the init.py and menu.py - automagical loading/
menu'ing of the OCIO nodes, and a first attempt at registering
OCIODisplay nodes as Nuke viewer processes.

It adds one process for every display and every transform (e.g "Film1D
(sRGB)", "Log (sRGB)", "Film1D (P3)", "Log (P3)") - seemed like the
most Nuke'ish solution given the limitations of the viewer
customisation.

On that subject, I wonder if it's possible to somehow tie the viewer's
exposure/gamma controls to the OCIODIsplay node.. I suspect not
currently.

https://github.com/dbr/OpenColorIO/commit/0cdf665eba7bd9dbeadcb94d9d446a4424a81303
https://github.com/dbr/OpenColorIO/commit/8151eca9edf3acf027e2a60ea3857f2240af6461


As I said, nothing too exciting.. I'm hoping to integrate OCIO into
the pipeline at work soon, so will almost certainly have more patches/
questions/feature-requests soon!

Oh, I've not signed a CLA yet - these changes seemed trivial enough
for it not to be necessary, but I will do so soon. Let me know if this
is a problem

Anyway, thanks again to everyone involved in this project!
- Ben Dickson

done.

On Mon, Jan 10, 2011 at 6:00 PM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:

On 11/01/2011, at 12:54 PM, Jeremy Selan wrote:

Spaces in knob names have always worried me.  How about an underscore
in the knob name?

perfect

On Mon, Jan 10, 2011 at 5:51 PM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:

On 11/01/2011, at 12:49 PM, Jeremy Selan wrote:

UI Label or underlying knob name?

I would do both just for consistency.

On Mon, Jan 10, 2011 at 5:48 PM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:

LGTM

I would be tempted to name the knob 'display gamma'.

.malcolm

On 11/01/2011, at 12:43 PM, Jeremy Selan wrote:

Issue:
http://github.com/imageworks/OpenColorIO/issues#issue/45

Commit:
http://github.com/jeremyselan/OpenColorIO/commit/c206c4fe65d415b5c87c09acde3e05013dc0ab9f

I've exposed a gamma control for the Nuke OCIODisplay node.  The gamma
control, like the origin one in nuke's monitor, is post-display
transform.

-- Jeremy

On 11/01/2011, at 12:54 PM, Jeremy Selan wrote:

Spaces in knob names have always worried me. How about an underscore
in the knob name?

perfect

On Mon, Jan 10, 2011 at 5:51 PM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:

On 11/01/2011, at 12:49 PM, Jeremy Selan wrote:

UI Label or underlying knob name?

I would do both just for consistency.

On Mon, Jan 10, 2011 at 5:48 PM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:

LGTM

I would be tempted to name the knob 'display gamma'.

.malcolm

On 11/01/2011, at 12:43 PM, Jeremy Selan wrote:

Issue:
http://github.com/imageworks/OpenColorIO/issues#issue/45

Commit:
http://github.com/jeremyselan/OpenColorIO/commit/c206c4fe65d415b5c87c09acde3e05013dc0ab9f

I've exposed a gamma control for the Nuke OCIODisplay node. The gamma
control, like the origin one in nuke's monitor, is post-display
transform.

-- Jeremy

Spaces in knob names have always worried me. How about an underscore
in the knob name?

On Mon, Jan 10, 2011 at 5:51 PM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:

On 11/01/2011, at 12:49 PM, Jeremy Selan wrote:

UI Label or underlying knob name?

I would do both just for consistency.

On Mon, Jan 10, 2011 at 5:48 PM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:

LGTM

I would be tempted to name the knob 'display gamma'.

.malcolm

On 11/01/2011, at 12:43 PM, Jeremy Selan wrote:

Issue:
http://github.com/imageworks/OpenColorIO/issues#issue/45

Commit:
http://github.com/jeremyselan/OpenColorIO/commit/c206c4fe65d415b5c87c09acde3e05013dc0ab9f

I've exposed a gamma control for the Nuke OCIODisplay node.  The gamma
control, like the origin one in nuke's monitor, is post-display
transform.

-- Jeremy

On 11/01/2011, at 12:49 PM, Jeremy Selan wrote:

UI Label or underlying knob name?

I would do both just for consistency.

On Mon, Jan 10, 2011 at 5:48 PM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:

LGTM

I would be tempted to name the knob 'display gamma'.

.malcolm

On 11/01/2011, at 12:43 PM, Jeremy Selan wrote:

Issue:
http://github.com/imageworks/OpenColorIO/issues#issue/45

Commit:
http://github.com/jeremyselan/OpenColorIO/commit/c206c4fe65d415b5c87c09acde3e05013dc0ab9f

I've exposed a gamma control for the Nuke OCIODisplay node. The gamma
control, like the origin one in nuke's monitor, is post-display
transform.

-- Jeremy

UI Label or underlying knob name?

On Mon, Jan 10, 2011 at 5:48 PM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:

LGTM

I would be tempted to name the knob 'display gamma'.

.malcolm

On 11/01/2011, at 12:43 PM, Jeremy Selan wrote:

Issue:
http://github.com/imageworks/OpenColorIO/issues#issue/45

Commit:
http://github.com/jeremyselan/OpenColorIO/commit/c206c4fe65d415b5c87c09acde3e05013dc0ab9f

I've exposed a gamma control for the Nuke OCIODisplay node.  The gamma
control, like the origin one in nuke's monitor, is post-display
transform.

-- Jeremy

LGTM

I would be tempted to name the knob 'display gamma'.

.malcolm

Issue:
http://github.com/imageworks/OpenColorIO/issues#issue/45

Commit:
http://github.com/jeremyselan/OpenColorIO/commit/c206c4fe65d415b5c87c09acde3e05013dc0ab9f

I've exposed a gamma control for the Nuke OCIODisplay node. The gamma
control, like the origin one in nuke's monitor, is post-display
transform.

-- Jeremy

Malcolm, I wasn't able to build the docs at home even on OSX 10.6.
Would you try the master repo on your machine again (post merge) to
verify it works for you?

-- Jeremy

Looks good to me. I did the merge, but disabled doc generation in the
top-level makefile by default. When you add the explicit target i'll
just roll that in too.

Thanks!

-- Jeremy

Version 0.7.4 (Jan 4 2011):
* Added Context, allowing for 'per-shot' Transforms
* Misc API Cleanup: removed old functions + fixed const-ness
* Added config.sanityCheck() for validation
* Additional Makefile configuration options, SONAME, etc.

Coming soon...
* Docs / Examples
* "Looks"
* IIF Profile

Yah, these conflict in:
export/OpenColorIO/OpenColorIO.h
src/pyglue/CMakeLists.txt

Looks easy to address though. Why don't you checkin the extra build
option to make the docs optional on your master, and then i'll fix it
to work on the new trunk? (or you can do the merge too if you'd like)
;)

-- Jeremy

On Tue, Jan 4, 2011 at 3:37 PM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:

LGTM,

This might slightly conflict with the docs commit just see how you go.

.malcolm

On 05/01/2011, at 10:00 AM, Jeremy Selan wrote:

Commits:
http://github.com/jeremyselan/OpenColorIO/commit/f5a80ee9e46eab956de7d618abda866af81de0e7
http://github.com/jeremyselan/OpenColorIO/commit/9859c936bd4c17651ec2a4ae33fa23c6476fc6d2

These checkins expose additional build options on the command-line
(needed for custom facility install scripts).
* SOVERSION can now be exposed, and overridden, on the command-line (a
la openimageio)
* The python so can be built with, or without, the "lib" prefix.

This checkin does *not* change any build default values. Default
behavior should be identical.

-- Jeremy