|
OCIO 0.7.0 posted
The first release based on YAML is now ready for download. Thanks to
Malcolm for his help on this.
An updated set of 0.7-format color configs (with many more color
spaces!) will be posted
The first release based on YAML is now ready for download. Thanks to
Malcolm for his help on this.
An updated set of 0.7-format color configs (with many more color
spaces!) will be posted
|
By
Jeremy Selan <jeremy...@...>
·
#191
·
|
|
Re: Review: Additional Yaml bugfixes
All LGTM, sorry most of these were introduced by me in the switch
All LGTM, sorry most of these were introduced by me in the switch
|
By
Malcolm Humphreys <malcolmh...@...>
·
#194
·
|
|
Re: Review: renamed config.writeToStream to config.serialize
Yep, I was thinking about doing that but it's not straight forward if we don't want yaml-cpp in the public interfaces for the Transforms()s.
It could also be possible if we have some form of
Yep, I was thinking about doing that but it's not straight forward if we don't want yaml-cpp in the public interfaces for the Transforms()s.
It could also be possible if we have some form of
|
By
Malcolm Humphreys <malcolmh...@...>
·
#193
·
|
|
Review: Additional Yaml bugfixes
These commits fix a bunch of bugs we discovered when testing our
in-house apps on real production color configurations.
* Yaml serialization fix, resource_path is updated properly
* Relative path
These commits fix a bunch of bugs we discovered when testing our
in-house apps on real production color configurations.
* Yaml serialization fix, resource_path is updated properly
* Relative path
|
By
Jeremy Selan <jeremy...@...>
·
#188
·
|
|
Re: Review: renamed config.writeToStream to config.serialize
Thinking about this topic further, I think the right thing to do it to
have __str__ call through to the C++ ostream implementation for each
class. (If that happens to use yaml, great! But it's not a
Thinking about this topic further, I think the right thing to do it to
have __str__ call through to the C++ ostream implementation for each
class. (If that happens to use yaml, great! But it's not a
|
By
Jeremy Selan <jeremy...@...>
·
#187
·
|
|
Re: Review: Misc Yaml Updates
Looking at this quickly it would be a pretty small patch to add out << YAML::NewLines(3);
Something along the lines of:
--emittermanip.h--
struct _NewLines {
_NewLines(int value_): value(value_)
Looking at this quickly it would be a pretty small patch to add out << YAML::NewLines(3);
Something along the lines of:
--emittermanip.h--
struct _NewLines {
_NewLines(int value_): value(value_)
|
By
Malcolm Humphreys <malcolmh...@...>
·
#190
·
|
|
Re: Review: Misc Yaml Updates
This looks all pretty good to me
- Can we call AddBaseTransformPropertiesToYAMLMap = EmitBaseTransformKeyValues
- Can we call ReadBaseTransformPropertiesFromYAMLMap = ReadBaseTransformKeyValues, and
This looks all pretty good to me
- Can we call AddBaseTransformPropertiesToYAMLMap = EmitBaseTransformKeyValues
- Can we call ReadBaseTransformPropertiesFromYAMLMap = ReadBaseTransformKeyValues, and
|
By
Malcolm Humphreys <malcolmh...@...>
·
#189
·
|
|
Review: Misc Yaml Updates
A bunch of changes related to yaml serialization:
* ColorSpace transform a base Transform, instead of GroupTransform.
* GroupTransform Yaml serialization supports nesting
* Direction is now
A bunch of changes related to yaml serialization:
* ColorSpace transform a base Transform, instead of GroupTransform.
* GroupTransform Yaml serialization supports nesting
* Direction is now
|
By
Jeremy Selan <jeremy...@...>
·
#186
·
|
|
Re: Review: renamed config.writeToStream to config.serialize
I did see that comment, forgot to address it in the last post.
I'd prefer to not expose the exact yaml serialization using __str__().
I'm pretty biased against "non-obvious" operator overloading
I did see that comment, forgot to address it in the last post.
I'd prefer to not expose the exact yaml serialization using __str__().
I'm pretty biased against "non-obvious" operator overloading
|
By
Jeremy Selan <jeremy...@...>
·
#184
·
|
|
Re: Review: added missing cmake NAME arg to add_test()
looks good to me.
<malcolmh...@...> wrote:
looks good to me.
<malcolmh...@...> wrote:
|
By
Jeremy Selan <jeremy...@...>
·
#180
·
|
|
Review: added missing cmake NAME arg to add_test()
- Added missing NAME arg to add_test() as this was failing to work on linux (worked on OSX, small cmake
- Added missing NAME arg to add_test() as this was failing to work on linux (worked on OSX, small cmake
|
By
Malcolm Humphreys <malcolmh...@...>
·
#185
·
|
|
Re: Review: renamed config.writeToStream to config.serialize
LGTM,
Did you see my comment in one of the threads about also supporting the .__str__() method?
LGTM,
Did you see my comment in one of the threads about also supporting the .__str__() method?
|
By
Malcolm Humphreys <malcolmh...@...>
·
#183
·
|
|
Re: Review: Fixed malformed ocio profile header tag
LGTM
By
Malcolm Humphreys <malcolmh...@...>
·
#182
·
|
|
Review: renamed config.writeToStream to config.serialize
This makes the naming unified across C++ / python, and also gets rid
of "getXML" (which is no longer xml).
js/master
commits:
bd559608bdfbbc930634ef78eebd42cda83647da
This makes the naming unified across C++ / python, and also gets rid
of "getXML" (which is no longer xml).
js/master
commits:
bd559608bdfbbc930634ef78eebd42cda83647da
|
By
Jeremy Selan <jeremy...@...>
·
#177
·
|
|
Review: Fixed malformed ocio profile header tag
* cleaned up malformed profile name (ocs_profile_version vs
ocio_profile_version)
* added better loading error checks
* updated raw profile to new yaml
* cleaned up malformed profile name (ocs_profile_version vs
ocio_profile_version)
* added better loading error checks
* updated raw profile to new yaml
|
By
Jeremy Selan <jeremy...@...>
·
#176
·
|
|
Trunk is now OCIO 0.7 (dev branch)
Folks,
I've deleted the OCIO yaml branch. The main trunk now is up to date
with all recent commits.
-- Jeremy
Folks,
I've deleted the OCIO yaml branch. The main trunk now is up to date
with all recent commits.
-- Jeremy
|
By
Jeremy Selan <jeremy...@...>
·
#175
·
|
|
Re: Review: fix some 'const char*' to 'char*' in pyglue
LGTM.
This was a compilation warning though, right? (It shouldnt have been an error).
-- Jeremy
<malcolmh...@...> wrote:
LGTM.
This was a compilation warning though, right? (It shouldnt have been an error).
-- Jeremy
<malcolmh...@...> wrote:
|
By
Jeremy Selan <jeremy...@...>
·
#172
·
|
|
Re: Review: YAML serialization
Works great on our linux distro now, thanks!
(LGTM)
I agree that it may make sense to include boost/shared_ptr.hpp, let me
look into this.
-- Jeremy
<malcolmh...@...> wrote:
Works great on our linux distro now, thanks!
(LGTM)
I agree that it may make sense to include boost/shared_ptr.hpp, let me
look into this.
-- Jeremy
<malcolmh...@...> wrote:
|
By
Jeremy Selan <jeremy...@...>
·
#171
·
|
|
Review: fix some 'const char*' to 'char*' in pyglue
PyOpenColorIO.so wouldn't compile on linux
http://github.com/malcolmhumphreys/OpenColorIO/commit/bb90284fa98161aae4ace74987246ae301ec1822
- Added some const_cast<char*>(..) ie. 'error: invalid
PyOpenColorIO.so wouldn't compile on linux
http://github.com/malcolmhumphreys/OpenColorIO/commit/bb90284fa98161aae4ace74987246ae301ec1822
- Added some const_cast<char*>(..) ie. 'error: invalid
|
By
Malcolm Humphreys <malcolmh...@...>
·
#181
·
|
|
Re: Review: YAML serialization
Hi,
This should fix the link error on linux
http://github.com/malcolmhumphreys/OpenColorIO/commit/7b016f274aefd8a4ce2deb7c72639351db8de0b4
I always forget how to create these diffs so I guess other
Hi,
This should fix the link error on linux
http://github.com/malcolmhumphreys/OpenColorIO/commit/7b016f274aefd8a4ce2deb7c72639351db8de0b4
I always forget how to create these diffs so I guess other
|
By
Malcolm Humphreys <malcolmh...@...>
·
#179
·
|