|
Re: Reference !<Colorspace>
My concern is when/where we want to have different primaries on
different shows. So the reference space is probably a particular RGB
space (rather than XYZ), and it is not obvious what that is
My concern is when/where we want to have different primaries on
different shows. So the reference space is probably a particular RGB
space (rather than XYZ), and it is not obvious what that is
|
By
Rod Bogart <bog...@...>
·
#216
·
|
|
Review: OCIO namespace update
OCIO namespace #define is now configured using the CMAKE
configure_file mojo. This makes namespace errors far less likely, as
it's baked into the header that's a part of
OCIO namespace #define is now configured using the CMAKE
configure_file mojo. This makes namespace errors far less likely, as
it's baked into the header that's a part of
|
By
Jeremy Selan <jeremy...@...>
·
#215
·
|
|
Review: Updated cmake_minimum_required to 2.8
We already required cmake 2.8 (for ExternalProject usage), now this is explicit.
commits:
949855cca45431a6e813ac3b6f3688de0799f379
We already required cmake 2.8 (for ExternalProject usage), now this is explicit.
commits:
949855cca45431a6e813ac3b6f3688de0799f379
|
By
Jeremy Selan <jeremy...@...>
·
#214
·
|
|
Review: nuke plugin crash fix
Nuke plugins wont crash if the specified $OCIO is invalid.
This issue is related to calling the nuke IOP::error method during
construction, but in the meantime we can at least prevent a crash by
not
Nuke plugins wont crash if the specified $OCIO is invalid.
This issue is related to calling the nuke IOP::error method during
construction, but in the meantime we can at least prevent a crash by
not
|
By
Jeremy Selan <jeremy...@...>
·
#213
·
|
|
Re: Review: Inital pass at searchpath impl
I've checked in this patch to the master branch. The code itself
looks good; whether we choose to backtrack from that API direction in
the upcoming weeks can/should be a separate issue from this
I've checked in this patch to the master branch. The code itself
looks good; whether we choose to backtrack from that API direction in
the upcoming weeks can/should be a separate issue from this
|
By
Jeremy Selan <jeremy...@...>
·
#212
·
|
|
Re: Review: Inital pass at searchpath impl
Malcolm,
I wish I had known you were thinking about writing this particular
piece of code; I probably would have asked you to hold off on it for a
little while... (This is my mistake, I do realize
Malcolm,
I wish I had known you were thinking about writing this particular
piece of code; I probably would have asked you to hold off on it for a
little while... (This is my mistake, I do realize
|
By
Jeremy Selan <jeremy...@...>
·
#206
·
|
|
Re: Reference !<Colorspace>
I'm not sure what promoting the reference colorspace to something
special - either in the API or the format - buys us. Can you provide
details on how this would make things simpler (or any other
I'm not sure what promoting the reference colorspace to something
special - either in the API or the format - buys us. Can you provide
details on how this would make things simpler (or any other
|
By
Jeremy Selan <jeremy...@...>
·
#205
·
|
|
Re: Review: added new yaml-cpp with YAML::Newline feature
Thanks,
LGTM
<malcolmh...@...> wrote:
Thanks,
LGTM
<malcolmh...@...> wrote:
|
By
Jeremy Selan <jeremy...@...>
·
#204
·
|
|
Re: Review: converted configs/testing/config.ocio to YAML
Looks good to me. I'll commit this after I finish working through the
search path checkins (tomorrow, hopefully).
-- Jeremy
<malcolmh...@...> wrote:
Looks good to me. I'll commit this after I finish working through the
search path checkins (tomorrow, hopefully).
-- Jeremy
<malcolmh...@...> wrote:
|
By
Jeremy Selan <jeremy...@...>
·
#203
·
|
|
Re: Reference !<Colorspace>
Is it just a role? seems like each colorspace needs it to convert between each other. Roles main purpose is to have abstract names / pointers for colorspaces. The reference space could also be a role
Is it just a role? seems like each colorspace needs it to convert between each other. Roles main purpose is to have abstract names / pointers for colorspaces. The reference space could also be a role
|
By
Malcolm Humphreys <malcolmh...@...>
·
#208
·
|
|
Re: Reference !<Colorspace>
Malcolm,
I don't see that the reference space should be separate in the profile. It's important, but it is just a role. Where the reference sits in the xml or yaml should matter much. Although
Malcolm,
I don't see that the reference space should be separate in the profile. It's important, but it is just a role. Where the reference sits in the xml or yaml should matter much. Although
|
By
Joseph Slomka <jsl...@...>
·
#199
·
|
|
Re: Review: added new yaml-cpp with YAML::Newline feature
No reason was just waiting to get the tick of approval, this is now removed.
http://github.com/malcolmhumphreys/OpenColorIO/commit/26aa9bfc1baa74796b355de0b2ec476960b1b481
.malcolm
No reason was just waiting to get the tick of approval, this is now removed.
http://github.com/malcolmhumphreys/OpenColorIO/commit/26aa9bfc1baa74796b355de0b2ec476960b1b481
.malcolm
|
By
Malcolm Humphreys <malcolmh...@...>
·
#211
·
|
|
Review: converted configs/testing/config.ocio to YAML
- converted configs/testing/config.ocio to YAML
- added OpenColorIOTest to the ctest run ie 'make test & make test_verbose'
- some test output was being written to /mcp changed this to /tmp for
- converted configs/testing/config.ocio to YAML
- added OpenColorIOTest to the ctest run ie 'make test & make test_verbose'
- some test output was being written to /mcp changed this to /tmp for
|
By
Malcolm Humphreys <malcolmh...@...>
·
#210
·
|
|
Re: Review: added new yaml-cpp with YAML::Newline feature
Is there a reason to not remove yaml-cpp-0.2.5* from ext?
Other than that, looks good to me.
-- Jeremy
<malcolmh...@...> wrote:
Is there a reason to not remove yaml-cpp-0.2.5* from ext?
Other than that, looks good to me.
-- Jeremy
<malcolmh...@...> wrote:
|
By
Jeremy Selan <jeremy...@...>
·
#198
·
|
|
Re: Review: Inital pass at GCC visibility
Looks good to me.
(I tested this, as well as all the related post-email updates).
-- Jeremy
<malcolmh...@...> wrote:
Looks good to me.
(I tested this, as well as all the related post-email updates).
-- Jeremy
<malcolmh...@...> wrote:
|
By
Jeremy Selan <jeremy...@...>
·
#197
·
|
|
Reference !<Colorspace>
Do you think the 'reference' colorspace should in a separate section in the profile? This would be similar to the PCS in the icc world. It could be an extra line 'reference: !<ColorSpace> ...' before
Do you think the 'reference' colorspace should in a separate section in the profile? This would be similar to the PCS in the icc world. It could be an extra line 'reference: !<ColorSpace> ...' before
|
By
Malcolm Humphreys <malcolmh...@...>
·
#209
·
|
|
Review: added new yaml-cpp with YAML::Newline feature
- added yaml-cpp r443 which contains the new YAML::Newline emitter manipulator
http://stackoverflow.com/questions/3982901/how-to-emit-a-blank-line-using-yaml-cpp
- added some 'out << YAML::Newline' to
- added yaml-cpp r443 which contains the new YAML::Newline emitter manipulator
http://stackoverflow.com/questions/3982901/how-to-emit-a-blank-line-using-yaml-cpp
- added some 'out << YAML::Newline' to
|
By
Malcolm Humphreys <malcolmh...@...>
·
#207
·
|
|
Re: Review: Inital pass at searchpath impl
- fixed a bug with abs searchpath entries
- empty '::' searchpaths now resolve to the profile
- fixed a bug with abs searchpath entries
- empty '::' searchpaths now resolve to the profile
|
By
Malcolm Humphreys <malcolmh...@...>
·
#202
·
|
|
Re: Review: Inital pass at searchpath impl
- removed the EnvExpand recusion limits as this didn't work in the production env which
has more than 30 env vars. might want to add limits in later if this becomes a
- removed the EnvExpand recusion limits as this didn't work in the production env which
has more than 30 env vars. might want to add limits in later if this becomes a
|
By
Malcolm Humphreys <malcolmh...@...>
·
#201
·
|
|
Review: Inital pass at searchpath impl
Inital pass at searchpath impl
- added environment variable string expansion code in PathUtils.h (GetEnvMap() & EnvExpand())
- added FileExists() function to PathUtils.h
- added searchpath
Inital pass at searchpath impl
- added environment variable string expansion code in PathUtils.h (GetEnvMap() & EnvExpand())
- added FileExists() function to PathUtils.h
- added searchpath
|
By
Malcolm Humphreys <malcolmh...@...>
·
#200
·
|