|
Re: Review: Exposed gamma control on Nuke OCIODisplay node
UI Label or underlying knob name?
<malcolmh...@...> wrote:
UI Label or underlying knob name?
<malcolmh...@...> wrote:
|
By
Jeremy Selan <jeremy...@...>
·
#340
·
|
|
Re: Review: Exposed gamma control on Nuke OCIODisplay node
LGTM
I would be tempted to name the knob 'display gamma'.
.malcolm
LGTM
I would be tempted to name the knob 'display gamma'.
.malcolm
|
By
Malcolm Humphreys <malcolmh...@...>
·
#345
·
|
|
Review: Exposed gamma control on Nuke OCIODisplay node
Issue:
http://github.com/imageworks/OpenColorIO/issues#issue/45
Commit:
http://github.com/jeremyselan/OpenColorIO/commit/c206c4fe65d415b5c87c09acde3e05013dc0ab9f
I've exposed a gamma control for the
Issue:
http://github.com/imageworks/OpenColorIO/issues#issue/45
Commit:
http://github.com/jeremyselan/OpenColorIO/commit/c206c4fe65d415b5c87c09acde3e05013dc0ab9f
I've exposed a gamma control for the
|
By
Jeremy Selan <jeremy...@...>
·
#339
·
|
|
Re: Review: Added html and pdf documentation generation using sphinx
Malcolm, I wasn't able to build the docs at home even on OSX 10.6.
Would you try the master repo on your machine again (post merge) to
verify it works for you?
-- Jeremy
Malcolm, I wasn't able to build the docs at home even on OSX 10.6.
Would you try the master repo on your machine again (post merge) to
verify it works for you?
-- Jeremy
|
By
Jeremy Selan <jeremy...@...>
·
#338
·
|
|
Re: Review: Added html and pdf documentation generation using sphinx
Looks good to me. I did the merge, but disabled doc generation in the
top-level makefile by default. When you add the explicit target i'll
just roll that in too.
Thanks!
-- Jeremy
Looks good to me. I did the merge, but disabled doc generation in the
top-level makefile by default. When you add the explicit target i'll
just roll that in too.
Thanks!
-- Jeremy
|
By
Jeremy Selan <jeremy...@...>
·
#333
·
|
|
0.7.4 Released
Version 0.7.4 (Jan 4 2011):
* Added Context, allowing for 'per-shot' Transforms
* Misc API Cleanup: removed old functions + fixed const-ness
* Added config.sanityCheck() for validation
Version 0.7.4 (Jan 4 2011):
* Added Context, allowing for 'per-shot' Transforms
* Misc API Cleanup: removed old functions + fixed const-ness
* Added config.sanityCheck() for validation
|
By
Jeremy Selan <jeremy...@...>
·
#332
·
|
|
Re: Review: Makefile updates
Yah, these conflict in:
export/OpenColorIO/OpenColorIO.h
src/pyglue/CMakeLists.txt
Looks easy to address though. Why don't you checkin the extra build
option to make the docs optional on your
Yah, these conflict in:
export/OpenColorIO/OpenColorIO.h
src/pyglue/CMakeLists.txt
Looks easy to address though. Why don't you checkin the extra build
option to make the docs optional on your
|
By
Jeremy Selan <jeremy...@...>
·
#331
·
|
|
Re: Review: Makefile updates
LGTM,
This might slightly conflict with the docs commit just see how you go.
.malcolm
LGTM,
This might slightly conflict with the docs commit just see how you go.
.malcolm
|
By
Malcolm Humphreys <malcolmh...@...>
·
#337
·
|
|
Re: Review: added pycontext
LGTM
By
Malcolm Humphreys <malcolmh...@...>
·
#336
·
|
|
Review: Makefile updates
Commits:
http://github.com/jeremyselan/OpenColorIO/commit/f5a80ee9e46eab956de7d618abda866af81de0e7
http://github.com/jeremyselan/OpenColorIO/commit/9859c936bd4c17651ec2a4ae33fa23c6476fc6d2
These
Commits:
http://github.com/jeremyselan/OpenColorIO/commit/f5a80ee9e46eab956de7d618abda866af81de0e7
http://github.com/jeremyselan/OpenColorIO/commit/9859c936bd4c17651ec2a4ae33fa23c6476fc6d2
These
|
By
Jeremy Selan <jeremy...@...>
·
#330
·
|
|
Re: Review: Added html and pdf documentation generation using sphinx
;) Thats good.
It should be trying to do it all in the build/ directory, so this is a little strange.
I have included all the additional libs for the html build, and install of Latex is the only
;) Thats good.
It should be trying to do it all in the build/ directory, so this is a little strange.
I have included all the additional libs for the html build, and install of Latex is the only
|
By
Malcolm Humphreys <malcolmh...@...>
·
#335
·
|
|
Re: Review: Added html and pdf documentation generation using sphinx
Whoa!!
These are beautiful docs, thanks for the hard work! The pdf is
awesome, as is the html. I think this will inspire me to keep all
docstrings up to date from now on.
When I run with your
Whoa!!
These are beautiful docs, thanks for the hard work! The pdf is
awesome, as is the html. I think this will inspire me to keep all
docstrings up to date from now on.
When I run with your
|
By
Jeremy Selan <jeremy...@...>
·
#329
·
|
|
Review: Added html and pdf documentation generation using sphinx
I have added sphinx OCIO document generation using sphinx, there are demo's of the output here:
html - http://malcolmhumphreys.github.com/OpenColorIO/
pdf -
I have added sphinx OCIO document generation using sphinx, there are demo's of the output here:
html - http://malcolmhumphreys.github.com/OpenColorIO/
pdf -
|
By
Malcolm Humphreys <malcolmh...@...>
·
#334
·
|
|
Review: added pycontext
The new 'Context' class is now exposed in python, and can be passed as
an optional kwarg in
The new 'Context' class is now exposed in python, and can be passed as
an optional kwarg in
|
By
Jeremy Selan <jeremy...@...>
·
#328
·
|
|
Re: Review: Fixed const correctness
LGTM
By
Malcolm Humphreys <malcolmh...@...>
·
#327
·
|
|
Re: Review: Support for per-shot looks
I guess I was mainly thinking about speed, I have seen people create a hell of a lot of environment variables. But your right we can add that complexity later when / if that becomes a
I guess I was mainly thinking about speed, I have seen people create a hell of a lot of environment variables. But your right we can add that complexity later when / if that becomes a
|
By
Malcolm Humphreys <malcolmh...@...>
·
#326
·
|
|
Review: Fixed const correctness
Issue:
http://github.com/imageworks/OpenColorIO/issues#issue/48
Commit:
http://github.com/jeremyselan/OpenColorIO/commit/a0fb960d0e8b083acc4bd18048d24ac8e49f99ad
All the classes that relied on the
Issue:
http://github.com/imageworks/OpenColorIO/issues#issue/48
Commit:
http://github.com/jeremyselan/OpenColorIO/commit/a0fb960d0e8b083acc4bd18048d24ac8e49f99ad
All the classes that relied on the
|
By
Jeremy Selan <jeremy...@...>
·
#325
·
|
|
Re: Review: Support for per-shot looks
Thanks, I've addressed all comments and rolled it into master.
Fixed.
Currently, nothing causes it to be flushed. Adding a library-wide
"flush cache" call is at the top of my todo list. (It was
Thanks, I've addressed all comments and rolled it into master.
Fixed.
Currently, nothing causes it to be flushed. Adding a library-wide
"flush cache" call is at the top of my todo list. (It was
|
By
Jeremy Selan <jeremy...@...>
·
#324
·
|
|
Re: Review: Support for per-shot looks
I really like most of this change, I have a few comments which are mostly cosmetic.
'Default' seems a little redundant in this names.
config.getDefaultContext() vs
I really like most of this change, I have a few comments which are mostly cosmetic.
'Default' seems a little redundant in this names.
config.getDefaultContext() vs
|
By
Malcolm Humphreys <malcolmh...@...>
·
#323
·
|
|
Review: Support for per-shot looks
Commits:
1a54ec8d76
Resolves Issue #16:
http://github.com/imageworks/OpenColorIO/issues#issue/16
This commit enables color transforms to leverage environment variables
+ search paths to determine
Commits:
1a54ec8d76
Resolves Issue #16:
http://github.com/imageworks/OpenColorIO/issues#issue/16
This commit enables color transforms to leverage environment variables
+ search paths to determine
|
By
Jeremy Selan <jeremy...@...>
·
#322
·
|