|
Re: Idea: Remove boost:shared_ptr
Would
#include <tr1/memory>
be an option for now?
Would
#include <tr1/memory>
be an option for now?
|
By
Colin Doncaster <colin.d...@...>
·
#244
·
|
|
Re: Idea: Remove boost:shared_ptr
Definitely,
I went to add tr1 on mac, and realized we're already doing it. From
export/OpenColorIO/OpenColorTypes.h,
#ifdef __APPLE__
#include <tr1/memory>
#define OCIO_SHARED_PTR
Definitely,
I went to add tr1 on mac, and realized we're already doing it. From
export/OpenColorIO/OpenColorTypes.h,
#ifdef __APPLE__
#include <tr1/memory>
#define OCIO_SHARED_PTR
|
By
Jeremy Selan <jeremy...@...>
·
#245
·
|
|
Review: Disable envvar unit tests
Unit tests for envvars were failing, referencing files that weren't
checked into the source tree. Disabling these specific tests for now.
Commits:
0a052d9090c9d693f63cdb409260627406790d75
--
Unit tests for envvars were failing, referencing files that weren't
checked into the source tree. Disabling these specific tests for now.
Commits:
0a052d9090c9d693f63cdb409260627406790d75
--
|
By
Jeremy Selan <jeremy...@...>
·
#246
·
|
|
Review: Switched auto_ptr -> ptr
In the public API we were storing references to m_impl using autoptrs,
which really was unnecessary. This only saved one line of code per
use, and made the memory model less obvious. This doesnt
In the public API we were storing references to m_impl using autoptrs,
which really was unnecessary. This only saved one line of code per
use, and made the memory model less obvious. This doesnt
|
By
Jeremy Selan <jeremy...@...>
·
#247
·
|
|
Review: Added two additional Nuke OCIO nodes
* LogConvert, which is a handy node that does the colorspace transform
between the SCENE_LINEAR role, and the COMPOSITING_LOG role. While
this isnt strictly needed (it could be accomplished using
* LogConvert, which is a handy node that does the colorspace transform
between the SCENE_LINEAR role, and the COMPOSITING_LOG role. While
this isnt strictly needed (it could be accomplished using
|
By
Jeremy Selan <jeremy...@...>
·
#248
·
|
|
Review: CSP bugfix
Upon further testing, it appears the channel swizzling was backwards
during CSP lut importing.
I used Nuke as the baseline in terms of lut channel order, so it's
possible that I've actually broken
Upon further testing, it appears the channel swizzling was backwards
during CSP lut importing.
I used Nuke as the baseline in terms of lut channel order, so it's
possible that I've actually broken
|
By
Jeremy Selan <jeremy...@...>
·
#249
·
|
|
Re: Review: Inital pass at searchpath impl
Malcolm, I like your suggestions.
My thoughts:
* The name 'globals' is good.
* I like pre-declaring the list of allowed variables beforehand for the config.
* I like the use of env-vars as
Malcolm, I like your suggestions.
My thoughts:
* The name 'globals' is good.
* I like pre-declaring the list of allowed variables beforehand for the config.
* I like the use of env-vars as
|
By
Jeremy Selan <jeremy...@...>
·
#250
·
|
|
Re: Review: CSP bugfix
In the absence of any objections, I will be merging this (and the
previous commits) into OCIO.
-- Jeremy
In the absence of any objections, I will be merging this (and the
previous commits) into OCIO.
-- Jeremy
|
By
Jeremy Selan <jeremy...@...>
·
#251
·
|
|
Review: EnvExpand optimization
Minor optimization: the potentially expensive EnvExpand call (which
expands envvars in file paths), does an early exit for paths which do
not contain special characters. ($ +
Minor optimization: the potentially expensive EnvExpand call (which
expands envvars in file paths), does an early exit for paths which do
not contain special characters. ($ +
|
By
Jeremy Selan <jeremy...@...>
·
#252
·
|
|
Review: Config.roles data storage is map
The list of defined roles within a config previously maintained order.
Conceptually, this is actually a mapping type where order does not
matter (and the yaml serialization dropped ordering). This
The list of defined roles within a config previously maintained order.
Conceptually, this is actually a mapping type where order does not
matter (and the yaml serialization dropped ordering). This
|
By
Jeremy Selan <jeremy...@...>
·
#253
·
|
|
Review: Added Truelight .cub support
Added support for Truelight .cub luts. (Both 1D shaper + 3d lut). 1D
shaper lut currently uses linear interpolation, until something better
comes along.
Note: This checkin tested with a limited
Added support for Truelight .cub luts. (Both 1D shaper + 3d lut). 1D
shaper lut currently uses linear interpolation, until something better
comes along.
Note: This checkin tested with a limited
|
By
Jeremy Selan <jeremy...@...>
·
#254
·
|
|
Review: Lut1D optimization
On Lut loading, 1D luts are checked to determine if the underlying
transform represents 'identity'. If so, they are skipped during op
generation. This is particularly useful when working with 3D
On Lut loading, 1D luts are checked to determine if the underlying
transform represents 'identity'. If so, they are skipped during op
generation. This is particularly useful when working with 3D
|
By
Jeremy Selan <jeremy...@...>
·
#255
·
|
|
Re: Review: Lut1D optimization
Is this semantically correct if the presence of the 1D lut also
triggers clipping to 0-1? Is there now a missing clamp?
RGB
Is this semantically correct if the presence of the 1D lut also
triggers clipping to 0-1? Is there now a missing clamp?
RGB
|
By
Rod Bogart <bog...@...>
·
#256
·
|
|
Re: Review: Lut1D optimization
Man, I can't get anything past you guys! :)
The clamp was omitted on purpose, but I could probably be convinced
either way on this issue.*
If this code were inside a compiler, there would be no
Man, I can't get anything past you guys! :)
The clamp was omitted on purpose, but I could probably be convinced
either way on this issue.*
If this code were inside a compiler, there would be no
|
By
Jeremy Selan <jeremy...@...>
·
#257
·
|
|
Re: Review: Lut1D optimization
I guess my preference would be to allow someone to ask for
optimization or not. In the glorious future when OCIO is involved in
the creation of every pixel in every movie, the animated CTL
I guess my preference would be to allow someone to ask for
optimization or not. In the glorious future when OCIO is involved in
the creation of every pixel in every movie, the animated CTL
|
By
Rod Bogart <bog...@...>
·
#258
·
|
|
Review: Updated Nuke OCIOFileTransform
Added explicit control of transform direction + interpolation to the
Nuke OCIOFileTransform node.
Commits:
3143ccdb38fee9ec774a1be94150c8f04d9e70c5
-- Jeremy
Added explicit control of transform direction + interpolation to the
Nuke OCIOFileTransform node.
Commits:
3143ccdb38fee9ec774a1be94150c8f04d9e70c5
-- Jeremy
|
By
Jeremy Selan <jeremy...@...>
·
#259
·
|
|
Re: Review: Disable envvar unit tests
hmm thats a bit weird the test should be creating all the files it is looking for.
--snip--
std::string lut2(two_dir+"somelut2.lut");
std::ofstream
hmm thats a bit weird the test should be creating all the files it is looking for.
--snip--
std::string lut2(two_dir+"somelut2.lut");
std::ofstream
|
By
Malcolm Humphreys <malcolmh...@...>
·
#263
·
|
|
Re: Review: CSP bugfix
LGTM, sorry I did know about this I was in the middle of doing the spline op for the prelut section and waiting for a better name for GetAutodeskLut3DArrayOffset which
we were discussing in one of the
LGTM, sorry I did know about this I was in the middle of doing the spline op for the prelut section and waiting for a better name for GetAutodeskLut3DArrayOffset which
we were discussing in one of the
|
By
Malcolm Humphreys <malcolmh...@...>
·
#264
·
|
|
Re: Review: EnvExpand optimization
LGTM
By
Malcolm Humphreys <malcolmh...@...>
·
#265
·
|
|
Re: Review: Inital pass at searchpath impl
+1
I was tempted to always have a lut that would match in the searchpath, say a global identity lut.
As this is possible to circumvent this way I would fix this later. The identity lut option should
+1
I was tempted to always have a lut that would match in the searchpath, say a global identity lut.
As this is possible to circumvent this way I would fix this later. The identity lut option should
|
By
Malcolm Humphreys <malcolmh...@...>
·
#266
·
|