|
Re: Inital Houdini lut support
Looks good to me!
I have a few comments, but these dont need to be addressed yet.
* In terms of coding style, you put the return value on a new line,
where as I tend to not. I'm actually fine
Looks good to me!
I have a few comments, but these dont need to be addressed yet.
* In terms of coding style, you put the return value on a new line,
where as I tend to not. I'm actually fine
|
By
Jeremy Selan <jeremy...@...>
·
#140
·
|
|
Re: Inital Houdini lut support
Also - for future reference - you don't need to include the patch
file. It will be sufficient to just include the SHA1 hash for the top-
most commit that corresponds to the topic.
For example, in
Also - for future reference - you don't need to include the patch
file. It will be sufficient to just include the SHA1 hash for the top-
most commit that corresponds to the topic.
For example, in
|
By
Jeremy Selan <jeremy...@...>
·
#141
·
|
|
Re: Review: pkg-config support and some OCIO_VERSION changes
Looks good to me!
I really like the VERSION consolidation and the cmake "configure_file"
mojo.
Now that I know about that approach, I'll use it for the
OCIO_NAMESPACE #define as well...
-- Jeremy
Looks good to me!
I really like the VERSION consolidation and the cmake "configure_file"
mojo.
Now that I know about that approach, I'll use it for the
OCIO_NAMESPACE #define as well...
-- Jeremy
|
By
Jeremy Selan <jeremy...@...>
·
#142
·
|
|
Re: Inital Houdini lut support
I'm happy to match what ever style you put forward, I mainly like doing
this as it makes it really clear what a function / method is returning. We
don't have function overloading but in code bases
I'm happy to match what ever style you put forward, I mainly like doing
this as it makes it really clear what a function / method is returning. We
don't have function overloading but in code bases
|
By
Malcolm Humphreys <malcolmh...@...>
·
#147
·
|
|
Re: XML Profile Format
I'm completely in favor of making the OCIO configuration files easier
to read and edit.
I have a few specific concerns about YAML, but it's definitely worth
exploring. Care to take a stab at it?
In
I'm completely in favor of making the OCIO configuration files easier
to read and edit.
I have a few specific concerns about YAML, but it's definitely worth
exploring. Care to take a stab at it?
In
|
By
Jeremy Selan <jeremy...@...>
·
#148
·
|
|
Re: XML Profile Format
http://code.google.com/p/yaml-cpp/
...is the compiled yaml io library. I believe yaml support is built
into the python distro.
-blake
http://code.google.com/p/yaml-cpp/
...is the compiled yaml io library. I believe yaml support is built
into the python distro.
-blake
|
By
bsloan <bsl...@...>
·
#149
·
|
|
Re: XML Profile Format
Sorry I will be responding to this soon, bit busy for the next 3 days.
.malcolm
Sorry I will be responding to this soon, bit busy for the next 3 days.
.malcolm
|
By
Malcolm Humphreys <malcolmh...@...>
·
#150
·
|
|
Review: ExponentTransform can serialize itself
The ExponentTransform (a publicly exposed class for doing power /
gamma operations) previously could not serialize itself to xml. This
commit adds the
The ExponentTransform (a publicly exposed class for doing power /
gamma operations) previously could not serialize itself to xml. This
commit adds the
|
By
Jeremy Selan <jeremy...@...>
·
#151
·
|
|
Re: XML Profile Format
Ok lets jump in :)
There are a few good articles on the subject of choosing XML 'just because', these two I
Ok lets jump in :)
There are a few good articles on the subject of choosing XML 'just because', these two I
|
By
Malcolm Humphreys <malcolmh...@...>
·
#152
·
|
|
Re: Review: ExponentTransform can serialize itself
LGTM - even without any tests : )
.malcolm
LGTM - even without any tests : )
.malcolm
|
By
Malcolm Humphreys <malcolmh...@...>
·
#153
·
|
|
Review: use CPack to create the source tarball
* added cpack support to replace the tgz_create script. Run 'make package_source' to create 'olio.VERSION.tar.gz'
* removed tgz_create
* added cpack support to replace the tgz_create script. Run 'make package_source' to create 'olio.VERSION.tar.gz'
* removed tgz_create
|
By
Malcolm Humphreys <malcolmh...@...>
·
#154
·
|
|
Re: Review: use CPack to create the source tarball
looks good to me.
-- Jeremy
<malcolmh...@...> wrote:
looks good to me.
-- Jeremy
<malcolmh...@...> wrote:
|
By
Jeremy Selan <jeremy...@...>
·
#155
·
|
|
Re: Review: use CPack to create the source tarball
One gotcha: when you use `make package_source` it appears to grab all
files in the subdirectory, including the build dirs and other files
which may not be part of the repository. I'm looking at
One gotcha: when you use `make package_source` it appears to grab all
files in the subdirectory, including the build dirs and other files
which may not be part of the repository. I'm looking at
|
By
Jeremy Selan <jeremy...@...>
·
#156
·
|
|
Re: Review: use CPack to create the source tarball
There is a cpack ignore dirs command, I would recommended doing out of source builds also.
"Jeremy Selan" <jeremy...@...> wrote:
--
Sent from my phone.
There is a cpack ignore dirs command, I would recommended doing out of source builds also.
"Jeremy Selan" <jeremy...@...> wrote:
--
Sent from my phone.
|
By
Malcolm Humphreys <malcolmh...@...>
·
#159
·
|
|
Re: Review: use CPack to create the source tarball
Hi Jeremy,
You can use the CPACK_SOURCE_IGNORE_FILES to hold a semi-colon separated
list of regexs to ignore files/directories.
Cheers,
Alan.
Hi Jeremy,
You can use the CPACK_SOURCE_IGNORE_FILES to hold a semi-colon separated
list of regexs to ignore files/directories.
Cheers,
Alan.
|
By
Alan Jones <sky...@...>
·
#158
·
|
|
Re: XML Profile Format
Ok, I'm convinced. Let's give YAML a shot.
In terms of broad technical strokes, I think either YAML or XML would
be sufficient. But given your enthusiasm for YAML, and it's superior
human
Ok, I'm convinced. Let's give YAML a shot.
In terms of broad technical strokes, I think either YAML or XML would
be sufficient. But given your enthusiasm for YAML, and it's superior
human
|
By
Jeremy Selan <jeremy...@...>
·
#157
·
|
|
C++ LUTs
Hi All,
Just wanted to throw a quick thought in on C++ LUTs.
I've recently been dealing with Arri's Alexa. One of the more unusual
aspects of it's Log-C transform is that it changes based on
Hi All,
Just wanted to throw a quick thought in on C++ LUTs.
I've recently been dealing with Arri's Alexa. One of the more unusual
aspects of it's Log-C transform is that it changes based on
|
By
Alan Jones <sky...@...>
·
#160
·
|
|
Review: YAML serialization
- Initial checkin of YAML serialization
- Added ext/yaml-cpp-0.2.5.tar.gz with a patch to build it static
- Added yaml-cpp to the LICENCE file
- CDLTransform should be the only thing depending on
- Initial checkin of YAML serialization
- Added ext/yaml-cpp-0.2.5.tar.gz with a patch to build it static
- Added yaml-cpp to the LICENCE file
- CDLTransform should be the only thing depending on
|
By
Malcolm Humphreys <malcolmh...@...>
·
#162
·
|
|
Re: XML Profile Format
Ok, so there is a initial go at this in the other mail.
I have added a local copy of yaml-cpp and a patch to make it build static.
Once we get a little further down the road, we can work with the
Ok, so there is a initial go at this in the other mail.
I have added a local copy of yaml-cpp and a patch to make it build static.
Once we get a little further down the road, we can work with the
|
By
Malcolm Humphreys <malcolmh...@...>
·
#163
·
|
|
Re: C++ LUTs
Alan,
It seems that this can be taken care of by having multiple colorspaces. For Arri log or Red log it is simple enough to treat each ISO rating as a separate colorspace. If you didn't want to
Alan,
It seems that this can be taken care of by having multiple colorspaces. For Arri log or Red log it is simple enough to treat each ISO rating as a separate colorspace. If you didn't want to
|
By
Joseph Slomka <jsl...@...>
·
#161
·
|