|
Review: removed TODO
I've removed the TODO file internal to the codebase, in favor of the
github issue tracking. (Which is really nice!)
Please feel free to add any issues (bugs or features) to this list as
you encounter
I've removed the TODO file internal to the codebase, in favor of the
github issue tracking. (Which is really nice!)
Please feel free to add any issues (bugs or features) to this list as
you encounter
|
By
Jeremy Selan <jeremy...@...>
·
#276
·
|
|
Re: Review: API Change to ColorSpace.GPUAllocation
No one has objected, so I'll roll this into the master branch.
-- Jeremy
No one has objected, so I'll roll this into the master branch.
-- Jeremy
|
By
Jeremy Selan <jeremy...@...>
·
#275
·
|
|
Review: API Change to ColorSpace.GPUAllocation
This updates the API for setting the ColorSpace GPU allocation hint.
(The allocation is used to determine how a particular lattice is best
sampled using a fixed domain lut on the GPU). Previously
This updates the API for setting the ColorSpace GPU allocation hint.
(The allocation is used to determine how a particular lattice is best
sampled using a fixed domain lut on the GPU). Previously
|
By
Jeremy Selan <jeremy...@...>
·
#274
·
|
|
OCIO 0.7.1 released
Version 0.7.1 (Nov 15 2010):
* Additional 3d lut formats: Truelight .cub + Iridas .cube
* FileTransform supports envvars and search paths
* Added Nuke plugins: LogConvert + FileTransform
Version 0.7.1 (Nov 15 2010):
* Additional 3d lut formats: Truelight .cub + Iridas .cube
* FileTransform supports envvars and search paths
* Added Nuke plugins: LogConvert + FileTransform
|
By
Jeremy Selan <jeremy...@...>
·
#273
·
|
|
Re: Review: FileTransform will try all lut formats (if the initial read fails)
In the absence of any objections, I will check this into master.
-- Jeremy
In the absence of any objections, I will check this into master.
-- Jeremy
|
By
Jeremy Selan <jeremy...@...>
·
#272
·
|
|
Review: FileTransform will try all lut formats (if the initial read fails)
FileTransform will attempt to load the specified lut formats, if the
initial read fails. I also had to make some of the 3D lut loaders use
stricter parsing as they now get called (in error
FileTransform will attempt to load the specified lut formats, if the
initial read fails. I also had to make some of the 3D lut loaders use
stricter parsing as they now get called (in error
|
By
Jeremy Selan <jeremy...@...>
·
#271
·
|
|
Re: Review: Lut1D optimization
That's fair to add it as an option. I'll add it as an official TODO,
and will implement it once we have a few more examples of this type.
I'm not sure if this will be a transform specific option, or
That's fair to add it as an option. I'll add it as an official TODO,
and will implement it once we have a few more examples of this type.
I'm not sure if this will be a transform specific option, or
|
By
Jeremy Selan <jeremy...@...>
·
#270
·
|
|
Review: .3dl loading updates
* Simplified the .3dl loading code
* Full support for .3dl shaper
* Simplified the .3dl loading code
* Full support for .3dl shaper
|
By
Jeremy Selan <jeremy...@...>
·
#269
·
|
|
Review: Simplified .csp lut3d loading
Looking again at 3d lut index ordering, .csp files can be loaded
without any float reordering - none of the prior index mojo is
required. This simplifies the code quite a bit, results are
Looking again at 3d lut index ordering, .csp files can be loaded
without any float reordering - none of the prior index mojo is
required. This simplifies the code quite a bit, results are
|
By
Jeremy Selan <jeremy...@...>
·
#262
·
|
|
Re: Review: Config.roles data storage is map
Yup, sending the map directly to the yaml stream works great.
Thanks.
-- Jeremy
<malcolmh...@...> wrote:
Yup, sending the map directly to the yaml stream works great.
Thanks.
-- Jeremy
<malcolmh...@...> wrote:
|
By
Jeremy Selan <jeremy...@...>
·
#261
·
|
|
Review: Added support for Iridas .cube luts (1d + 3d)
Added full read support for Iridas .cube luts. Verified results agree
with Nuke for all luts in FrameCycler distro.
commits:
1880192d63718dfba54d96d88ff396a0ac85fdee
-- Jeremy
Added full read support for Iridas .cube luts. Verified results agree
with Nuke for all luts in FrameCycler distro.
commits:
1880192d63718dfba54d96d88ff396a0ac85fdee
-- Jeremy
|
By
Jeremy Selan <jeremy...@...>
·
#260
·
|
|
Re: Review: Config.roles data storage is map
LGTM
I'm pretty sure yaml-cpp supports std::map serialization does the following work?
sorry I can't test this myself.
--snip--
// Roles
if(m_impl->roles_.size() > 0)
LGTM
I'm pretty sure yaml-cpp supports std::map serialization does the following work?
sorry I can't test this myself.
--snip--
// Roles
if(m_impl->roles_.size() > 0)
|
By
Malcolm Humphreys <malcolmh...@...>
·
#268
·
|
|
Re: Review: Switched auto_ptr -> ptr
LGTM
.malcolm
By
Malcolm Humphreys <malcolmh...@...>
·
#267
·
|
|
Re: Review: Inital pass at searchpath impl
+1
I was tempted to always have a lut that would match in the searchpath, say a global identity lut.
As this is possible to circumvent this way I would fix this later. The identity lut option should
+1
I was tempted to always have a lut that would match in the searchpath, say a global identity lut.
As this is possible to circumvent this way I would fix this later. The identity lut option should
|
By
Malcolm Humphreys <malcolmh...@...>
·
#266
·
|
|
Re: Review: EnvExpand optimization
LGTM
By
Malcolm Humphreys <malcolmh...@...>
·
#265
·
|
|
Re: Review: CSP bugfix
LGTM, sorry I did know about this I was in the middle of doing the spline op for the prelut section and waiting for a better name for GetAutodeskLut3DArrayOffset which
we were discussing in one of the
LGTM, sorry I did know about this I was in the middle of doing the spline op for the prelut section and waiting for a better name for GetAutodeskLut3DArrayOffset which
we were discussing in one of the
|
By
Malcolm Humphreys <malcolmh...@...>
·
#264
·
|
|
Re: Review: Disable envvar unit tests
hmm thats a bit weird the test should be creating all the files it is looking for.
--snip--
std::string lut2(two_dir+"somelut2.lut");
std::ofstream
hmm thats a bit weird the test should be creating all the files it is looking for.
--snip--
std::string lut2(two_dir+"somelut2.lut");
std::ofstream
|
By
Malcolm Humphreys <malcolmh...@...>
·
#263
·
|
|
Review: Updated Nuke OCIOFileTransform
Added explicit control of transform direction + interpolation to the
Nuke OCIOFileTransform node.
Commits:
3143ccdb38fee9ec774a1be94150c8f04d9e70c5
-- Jeremy
Added explicit control of transform direction + interpolation to the
Nuke OCIOFileTransform node.
Commits:
3143ccdb38fee9ec774a1be94150c8f04d9e70c5
-- Jeremy
|
By
Jeremy Selan <jeremy...@...>
·
#259
·
|
|
Re: Review: Lut1D optimization
I guess my preference would be to allow someone to ask for
optimization or not. In the glorious future when OCIO is involved in
the creation of every pixel in every movie, the animated CTL
I guess my preference would be to allow someone to ask for
optimization or not. In the glorious future when OCIO is involved in
the creation of every pixel in every movie, the animated CTL
|
By
Rod Bogart <bog...@...>
·
#258
·
|
|
Re: Review: Lut1D optimization
Man, I can't get anything past you guys! :)
The clamp was omitted on purpose, but I could probably be convinced
either way on this issue.*
If this code were inside a compiler, there would be no
Man, I can't get anything past you guys! :)
The clamp was omitted on purpose, but I could probably be convinced
either way on this issue.*
If this code were inside a compiler, there would be no
|
By
Jeremy Selan <jeremy...@...>
·
#257
·
|