|
Re: Review: Lut1D optimization
Is this semantically correct if the presence of the 1D lut also
triggers clipping to 0-1? Is there now a missing clamp?
RGB
Is this semantically correct if the presence of the 1D lut also
triggers clipping to 0-1? Is there now a missing clamp?
RGB
|
By
Rod Bogart <bog...@...>
·
#256
·
|
|
Review: Lut1D optimization
On Lut loading, 1D luts are checked to determine if the underlying
transform represents 'identity'. If so, they are skipped during op
generation. This is particularly useful when working with 3D
On Lut loading, 1D luts are checked to determine if the underlying
transform represents 'identity'. If so, they are skipped during op
generation. This is particularly useful when working with 3D
|
By
Jeremy Selan <jeremy...@...>
·
#255
·
|
|
Review: Added Truelight .cub support
Added support for Truelight .cub luts. (Both 1D shaper + 3d lut). 1D
shaper lut currently uses linear interpolation, until something better
comes along.
Note: This checkin tested with a limited
Added support for Truelight .cub luts. (Both 1D shaper + 3d lut). 1D
shaper lut currently uses linear interpolation, until something better
comes along.
Note: This checkin tested with a limited
|
By
Jeremy Selan <jeremy...@...>
·
#254
·
|
|
Review: Config.roles data storage is map
The list of defined roles within a config previously maintained order.
Conceptually, this is actually a mapping type where order does not
matter (and the yaml serialization dropped ordering). This
The list of defined roles within a config previously maintained order.
Conceptually, this is actually a mapping type where order does not
matter (and the yaml serialization dropped ordering). This
|
By
Jeremy Selan <jeremy...@...>
·
#253
·
|
|
Review: EnvExpand optimization
Minor optimization: the potentially expensive EnvExpand call (which
expands envvars in file paths), does an early exit for paths which do
not contain special characters. ($ +
Minor optimization: the potentially expensive EnvExpand call (which
expands envvars in file paths), does an early exit for paths which do
not contain special characters. ($ +
|
By
Jeremy Selan <jeremy...@...>
·
#252
·
|
|
Re: Review: CSP bugfix
In the absence of any objections, I will be merging this (and the
previous commits) into OCIO.
-- Jeremy
In the absence of any objections, I will be merging this (and the
previous commits) into OCIO.
-- Jeremy
|
By
Jeremy Selan <jeremy...@...>
·
#251
·
|
|
Re: Review: Inital pass at searchpath impl
Malcolm, I like your suggestions.
My thoughts:
* The name 'globals' is good.
* I like pre-declaring the list of allowed variables beforehand for the config.
* I like the use of env-vars as
Malcolm, I like your suggestions.
My thoughts:
* The name 'globals' is good.
* I like pre-declaring the list of allowed variables beforehand for the config.
* I like the use of env-vars as
|
By
Jeremy Selan <jeremy...@...>
·
#250
·
|
|
Review: CSP bugfix
Upon further testing, it appears the channel swizzling was backwards
during CSP lut importing.
I used Nuke as the baseline in terms of lut channel order, so it's
possible that I've actually broken
Upon further testing, it appears the channel swizzling was backwards
during CSP lut importing.
I used Nuke as the baseline in terms of lut channel order, so it's
possible that I've actually broken
|
By
Jeremy Selan <jeremy...@...>
·
#249
·
|
|
Review: Added two additional Nuke OCIO nodes
* LogConvert, which is a handy node that does the colorspace transform
between the SCENE_LINEAR role, and the COMPOSITING_LOG role. While
this isnt strictly needed (it could be accomplished using
* LogConvert, which is a handy node that does the colorspace transform
between the SCENE_LINEAR role, and the COMPOSITING_LOG role. While
this isnt strictly needed (it could be accomplished using
|
By
Jeremy Selan <jeremy...@...>
·
#248
·
|
|
Review: Switched auto_ptr -> ptr
In the public API we were storing references to m_impl using autoptrs,
which really was unnecessary. This only saved one line of code per
use, and made the memory model less obvious. This doesnt
In the public API we were storing references to m_impl using autoptrs,
which really was unnecessary. This only saved one line of code per
use, and made the memory model less obvious. This doesnt
|
By
Jeremy Selan <jeremy...@...>
·
#247
·
|
|
Review: Disable envvar unit tests
Unit tests for envvars were failing, referencing files that weren't
checked into the source tree. Disabling these specific tests for now.
Commits:
0a052d9090c9d693f63cdb409260627406790d75
--
Unit tests for envvars were failing, referencing files that weren't
checked into the source tree. Disabling these specific tests for now.
Commits:
0a052d9090c9d693f63cdb409260627406790d75
--
|
By
Jeremy Selan <jeremy...@...>
·
#246
·
|
|
Re: Idea: Remove boost:shared_ptr
Definitely,
I went to add tr1 on mac, and realized we're already doing it. From
export/OpenColorIO/OpenColorTypes.h,
#ifdef __APPLE__
#include <tr1/memory>
#define OCIO_SHARED_PTR
Definitely,
I went to add tr1 on mac, and realized we're already doing it. From
export/OpenColorIO/OpenColorTypes.h,
#ifdef __APPLE__
#include <tr1/memory>
#define OCIO_SHARED_PTR
|
By
Jeremy Selan <jeremy...@...>
·
#245
·
|
|
Re: Idea: Remove boost:shared_ptr
Would
#include <tr1/memory>
be an option for now?
Would
#include <tr1/memory>
be an option for now?
|
By
Colin Doncaster <colin.d...@...>
·
#244
·
|
|
Re: Review: Inital pass at searchpath impl
Hi,
It might have to wait a few weeks, I'm in Hong Kong right now and I'm going to be MIA in asia for a bit.
But yes a chat would be good when we are both free.
They are a common mechanism for setting
Hi,
It might have to wait a few weeks, I'm in Hong Kong right now and I'm going to be MIA in asia for a bit.
But yes a chat would be good when we are both free.
They are a common mechanism for setting
|
By
Malcolm Humphreys <malcolmh...@...>
·
#243
·
|
|
Re: Idea: Remove boost:shared_ptr
+1 it should be pretty easy to add boost back as a dependency if we need to. I have
seen a lot of projects copy the shared_ptr so it seems fairly common practice.
.malcolm
+1 it should be pretty easy to add boost back as a dependency if we need to. I have
seen a lot of projects copy the shared_ptr so it seems fairly common practice.
.malcolm
|
By
Malcolm Humphreys <malcolmh...@...>
·
#242
·
|
|
Re: Review: Added missing role enum to python
LGTM
By
Malcolm Humphreys <malcolmh...@...>
·
#241
·
|
|
Re: Idea: Remove boost:shared_ptr
+1 it should be pretty easy to add boost back as a dependency if we need to. I have seen a lot of projects copy the shared_ptr so it seems fairly common practice.
.malcolm
+1 it should be pretty easy to add boost back as a dependency if we need to. I have seen a lot of projects copy the shared_ptr so it seems fairly common practice.
.malcolm
|
By
Malcolm Humphreys <malcolmh...@...>
·
#240
·
|
|
Re: Review: Added missing role enum to python
LGTM
By
Malcolm Humphreys <malcolmh...@...>
·
#239
·
|
|
Review: Nuke to OCIO exporter
I've added a nuke python script to src/testbed that lets you export
specified nuke color spaces into an OCIO profile. It also is a good
example of using the python API to create an OCIO
I've added a nuke python script to src/testbed that lets you export
specified nuke color spaces into an OCIO profile. It also is a good
example of using the python API to create an OCIO
|
By
Jeremy Selan <jeremy...@...>
·
#237
·
|
|
New 0.7 Profile posted
A new profile, 'nuke-default' has been added to the 0.7.1 config bundle.
http://sites.google.com/site/opencolorio/profiles
This profile emulates the 'out of the box' color processing luts that
come
A new profile, 'nuke-default' has been added to the 0.7.1 config bundle.
http://sites.google.com/site/opencolorio/profiles
This profile emulates the 'out of the box' color processing luts that
come
|
By
Jeremy Selan <jeremy...@...>
·
#236
·
|