|
Re: Review: new Baker interface
Thats cool, I'm trying to get all the remaining pieces in place before friday. So
I will have a few more things over the next few days.
.malcolm
Thats cool, I'm trying to get all the remaining pieces in place before friday. So
I will have a few more things over the next few days.
.malcolm
|
By
Malcolm Humphreys <malcolmh...@...>
·
#463
·
|
|
Re: Review: new Baker interface
On first glance, this looks great. Thanks! I wont have a chance to do a more thorough review until tomorrow...
-- Jeremy
On first glance, this looks great. Thanks! I wont have a chance to do a more thorough review until tomorrow...
-- Jeremy
|
By
Jeremy Selan <jeremy...@...>
·
#462
·
|
|
Review: new Baker interface
https://github.com/imageworks/OpenColorIO/pull/73
Replacing some pre ocio code for building luts at drd
- Added new OCIO::Baker interface and initial pass at houdini lut writing
- Added new app
https://github.com/imageworks/OpenColorIO/pull/73
Replacing some pre ocio code for building luts at drd
- Added new OCIO::Baker interface and initial pass at houdini lut writing
- Added new app
|
By
Malcolm Humphreys <malcolmh...@...>
·
#461
·
|
|
Re: Status of CSP prelut?
Oh, of course - test data might be.. useful...
http://dl.dropbox.com/u/796113/ocio_temp/csp_prelut_testfile.tar.gz
- Source image (JPLogLin'd marcie)
- a lin_to_rec709.csp test LUT
- source image with
Oh, of course - test data might be.. useful...
http://dl.dropbox.com/u/796113/ocio_temp/csp_prelut_testfile.tar.gz
- Source image (JPLogLin'd marcie)
- a lin_to_rec709.csp test LUT
- source image with
|
By
DBR - Ben <dbr....@...>
·
#460
·
|
|
Re: Status of CSP prelut?
Sorry I'm working on some other stuff for the last few days in preparation for wrapping up next week. I'll be back on ocio tomorrow so I'll have a look at it then.
.malcolm
Sorry I'm working on some other stuff for the last few days in preparation for wrapping up next week. I'll be back on ocio tomorrow so I'll have a look at it then.
.malcolm
|
By
Malcolm Humphreys <malcolmh...@...>
·
#459
·
|
|
Re: Status of CSP prelut?
Cool, looks good!
Would anyone have an example csp file with a prelut suitable for testing?
Malcolm?
Even though what you've done looks totally reasonable, I'd like to QC it against some known good
Cool, looks good!
Would anyone have an example csp file with a prelut suitable for testing?
Malcolm?
Even though what you've done looks totally reasonable, I'd like to QC it against some known good
|
By
Jeremy Selan <jeremy...@...>
·
#458
·
|
|
Re: Status of CSP prelut?
Initial attempt at this, and an unrelated commit which prevents empty config sections being seralised:
https://github.com/imageworks/OpenColorIO/pull/72
Initial attempt at this, and an unrelated commit which prevents empty config sections being seralised:
https://github.com/imageworks/OpenColorIO/pull/72
|
By
"dbr/Ben" <b...@...>
·
#457
·
|
|
Re: Review: No more email reviews!
Actually, on further thought let's do both. Very few people get notified of pull requests, and I'd like to keep everyone on this list in the development loop. (that is it's purpose, after all).
So
Actually, on further thought let's do both. Very few people get notified of pull requests, and I'd like to keep everyone on this list in the development loop. (that is it's purpose, after all).
So
|
By
Jeremy Selan <jeremy...@...>
·
#456
·
|
|
Re: Review: No more email reviews!
Sounds good.
My only concern is that discussion would end up being spread over both the mailing list, and pull request comments - it's kind of nice to have it all in one place
...but that's a
Sounds good.
My only concern is that discussion would end up being spread over both the mailing list, and pull request comments - it's kind of nice to have it all in one place
...but that's a
|
By
"dbr/Ben" <b...@...>
·
#455
·
|
|
Review: No more email reviews!
So github's pull request mechanism has gotten a lot better since we
started the project.
At this point I don't see a compelling reason to submit reviews to
this email alias, rather than to just use
So github's pull request mechanism has gotten a lot better since we
started the project.
At this point I don't see a compelling reason to submit reviews to
this email alias, rather than to just use
|
By
Jeremy Selan <jeremy...@...>
·
#454
·
|
|
Re: Stable Version, Ahoy!
Excellent. Thanks for the feedback.
Do we know that static linking isn't currently working? I've never
tried. Why wouldn't it work already? (just that we dont have cmake
create the .a
Excellent. Thanks for the feedback.
Do we know that static linking isn't currently working? I've never
tried. Why wouldn't it work already? (just that we dont have cmake
create the .a
|
By
Jeremy Selan <jeremy...@...>
·
#453
·
|
|
Re: Review: ociocheck
Sounds good. I'll try to give it a shot.
-- Jeremy
Sounds good. I'll try to give it a shot.
-- Jeremy
|
By
Jeremy Selan <jeremy...@...>
·
#452
·
|
|
Re: Status of CSP prelut?
Looks good.
So for the case you outline below, you'd create a Lut1D op, where
from_min = 0.0, from_max = 4.0, and the lut values 0 ... 2.0 would go
in the lut.
I'd go with a fixed number of samples
Looks good.
So for the case you outline below, you'd create a Lut1D op, where
from_min = 0.0, from_max = 4.0, and the lut values 0 ... 2.0 would go
in the lut.
I'd go with a fixed number of samples
|
By
Jeremy Selan <jeremy...@...>
·
#451
·
|
|
Re: Review: ociocheck
I don't mind at all if somebody wants to replace the BOOST_FOREACH in OIIO argparse with regular 'for' statements.
-- lg
--
Larry Gritz
l...@...
I don't mind at all if somebody wants to replace the BOOST_FOREACH in OIIO argparse with regular 'for' statements.
-- lg
--
Larry Gritz
l...@...
|
By
Larry Gritz <l...@...>
·
#448
·
|
|
Re: Status of CSP prelut?
Started attempting this, seems to be progressing well - thanks for the tips!
To be clear about the resampling. Given a prelut of:
0.0 2.0 4.0
0.0 1.0 2.0
..the code would linearly-interoplate
Started attempting this, seems to be progressing well - thanks for the tips!
To be clear about the resampling. Given a prelut of:
0.0 2.0 4.0
0.0 1.0 2.0
..the code would linearly-interoplate
|
By
"dbr/Ben" <b...@...>
·
#450
·
|
|
Re: Review: ociocheck
Only seems to use BOOST_FOREACH - should be easy enough to replace with an old-fashioned for()
Only seems to use BOOST_FOREACH - should be easy enough to replace with an old-fashioned for()
|
By
"dbr/Ben" <b...@...>
·
#449
·
|
|
Re: Review: ociocheck
I was looking at oiio argparse but that too seems dependant on boost for something I remember.
.malcolm
I was looking at oiio argparse but that too seems dependant on boost for something I remember.
.malcolm
|
By
Malcolm Humphreys <malcolmh...@...>
·
#447
·
|
|
Re: Review: ociocheck
Agreed about the --inputconfig / $OCIO option. I've added that.
I'll see what I can do about remove the boost dependency. I agree
that if we can avoid it, we should.
-- Jeremy
Agreed about the --inputconfig / $OCIO option. I've added that.
I'll see what I can do about remove the boost dependency. I agree
that if we can avoid it, we should.
-- Jeremy
|
By
Jeremy Selan <jeremy...@...>
·
#444
·
|
|
Re: Review: upgrade to pyglue
Ope, that's an embarrassing copy/paste error... fixed!
I totally agree that python docstrings are critical. I'll add the
task to the git issues list, and try to get to it soon.
-- Jeremy
Ope, that's an embarrassing copy/paste error... fixed!
I totally agree that python docstrings are critical. I'll add the
task to the git issues list, and try to get to it soon.
-- Jeremy
|
By
Jeremy Selan <jeremy...@...>
·
#443
·
|
|
Re: Review: ociocheck
Looks good!
Perhaps if --inputconfig flag is not set, it could check $OCIO? Might be a convenient way to verify the env is setup correctly, and may answer many "why doesn't OCIO work!" questions.
Looks good!
Perhaps if --inputconfig flag is not set, it could check $OCIO? Might be a convenient way to verify the env is setup correctly, and may answer many "why doesn't OCIO work!" questions.
|
By
"dbr/Ben" <b...@...>
·
#446
·
|