|
Re: Review: No more email reviews!
Actually, on further thought let's do both. Very few people get notified of pull requests, and I'd like to keep everyone on this list in the development loop. (that is it's purpose, after all).
So
Actually, on further thought let's do both. Very few people get notified of pull requests, and I'd like to keep everyone on this list in the development loop. (that is it's purpose, after all).
So
|
By
Jeremy Selan <jeremy...@...>
·
#456
·
|
|
Re: Review: No more email reviews!
Sounds good.
My only concern is that discussion would end up being spread over both the mailing list, and pull request comments - it's kind of nice to have it all in one place
...but that's a
Sounds good.
My only concern is that discussion would end up being spread over both the mailing list, and pull request comments - it's kind of nice to have it all in one place
...but that's a
|
By
"dbr/Ben" <b...@...>
·
#455
·
|
|
Review: No more email reviews!
So github's pull request mechanism has gotten a lot better since we
started the project.
At this point I don't see a compelling reason to submit reviews to
this email alias, rather than to just use
So github's pull request mechanism has gotten a lot better since we
started the project.
At this point I don't see a compelling reason to submit reviews to
this email alias, rather than to just use
|
By
Jeremy Selan <jeremy...@...>
·
#454
·
|
|
Re: Stable Version, Ahoy!
Excellent. Thanks for the feedback.
Do we know that static linking isn't currently working? I've never
tried. Why wouldn't it work already? (just that we dont have cmake
create the .a
Excellent. Thanks for the feedback.
Do we know that static linking isn't currently working? I've never
tried. Why wouldn't it work already? (just that we dont have cmake
create the .a
|
By
Jeremy Selan <jeremy...@...>
·
#453
·
|
|
Re: Review: ociocheck
Sounds good. I'll try to give it a shot.
-- Jeremy
Sounds good. I'll try to give it a shot.
-- Jeremy
|
By
Jeremy Selan <jeremy...@...>
·
#452
·
|
|
Re: Status of CSP prelut?
Looks good.
So for the case you outline below, you'd create a Lut1D op, where
from_min = 0.0, from_max = 4.0, and the lut values 0 ... 2.0 would go
in the lut.
I'd go with a fixed number of samples
Looks good.
So for the case you outline below, you'd create a Lut1D op, where
from_min = 0.0, from_max = 4.0, and the lut values 0 ... 2.0 would go
in the lut.
I'd go with a fixed number of samples
|
By
Jeremy Selan <jeremy...@...>
·
#451
·
|
|
Re: Review: ociocheck
I don't mind at all if somebody wants to replace the BOOST_FOREACH in OIIO argparse with regular 'for' statements.
-- lg
--
Larry Gritz
l...@...
I don't mind at all if somebody wants to replace the BOOST_FOREACH in OIIO argparse with regular 'for' statements.
-- lg
--
Larry Gritz
l...@...
|
By
Larry Gritz <l...@...>
·
#448
·
|
|
Re: Status of CSP prelut?
Started attempting this, seems to be progressing well - thanks for the tips!
To be clear about the resampling. Given a prelut of:
0.0 2.0 4.0
0.0 1.0 2.0
..the code would linearly-interoplate
Started attempting this, seems to be progressing well - thanks for the tips!
To be clear about the resampling. Given a prelut of:
0.0 2.0 4.0
0.0 1.0 2.0
..the code would linearly-interoplate
|
By
"dbr/Ben" <b...@...>
·
#450
·
|
|
Re: Review: ociocheck
Only seems to use BOOST_FOREACH - should be easy enough to replace with an old-fashioned for()
Only seems to use BOOST_FOREACH - should be easy enough to replace with an old-fashioned for()
|
By
"dbr/Ben" <b...@...>
·
#449
·
|
|
Re: Review: ociocheck
I was looking at oiio argparse but that too seems dependant on boost for something I remember.
.malcolm
I was looking at oiio argparse but that too seems dependant on boost for something I remember.
.malcolm
|
By
Malcolm Humphreys <malcolmh...@...>
·
#447
·
|
|
Re: Review: ociocheck
Agreed about the --inputconfig / $OCIO option. I've added that.
I'll see what I can do about remove the boost dependency. I agree
that if we can avoid it, we should.
-- Jeremy
Agreed about the --inputconfig / $OCIO option. I've added that.
I'll see what I can do about remove the boost dependency. I agree
that if we can avoid it, we should.
-- Jeremy
|
By
Jeremy Selan <jeremy...@...>
·
#444
·
|
|
Re: Review: upgrade to pyglue
Ope, that's an embarrassing copy/paste error... fixed!
I totally agree that python docstrings are critical. I'll add the
task to the git issues list, and try to get to it soon.
-- Jeremy
Ope, that's an embarrassing copy/paste error... fixed!
I totally agree that python docstrings are critical. I'll add the
task to the git issues list, and try to get to it soon.
-- Jeremy
|
By
Jeremy Selan <jeremy...@...>
·
#443
·
|
|
Re: Review: ociocheck
Looks good!
Perhaps if --inputconfig flag is not set, it could check $OCIO? Might be a convenient way to verify the env is setup correctly, and may answer many "why doesn't OCIO work!" questions.
Looks good!
Perhaps if --inputconfig flag is not set, it could check $OCIO? Might be a convenient way to verify the env is setup correctly, and may answer many "why doesn't OCIO work!" questions.
|
By
"dbr/Ben" <b...@...>
·
#446
·
|
|
Re: Review: upgrade to pyglue
Looks much more Python'y \o/
Would be good to have more helpful method signatures for __init__ - would make this feature more discoverable - currently it just says:
...
| __init__(...)
|
Looks much more Python'y \o/
Would be good to have more helpful method signatures for __init__ - would make this feature more discoverable - currently it just says:
...
| __init__(...)
|
|
By
"dbr/Ben" <b...@...>
·
#445
·
|
|
Re: Stable Version, Ahoy!
Hi,
My top few right now
- Bit depth support in the API
- !<Look> concept fleshed out a little
- Transform / Op Plugin API
- Static Link working
- Update to the latest yaml-cpp from trunk, it has some
Hi,
My top few right now
- Bit depth support in the API
- !<Look> concept fleshed out a little
- Transform / Op Plugin API
- Static Link working
- Update to the latest yaml-cpp from trunk, it has some
|
By
Malcolm Humphreys <malcolmh...@...>
·
#442
·
|
|
Stable Version, Ahoy!
Team Coco,
OpenColorIO is rapidly approaching stability, so the time is ripe to
lock off on our next stable API version. If you have any short-term
additions or requests that will break API binary
Team Coco,
OpenColorIO is rapidly approaching stability, so the time is ripe to
lock off on our next stable API version. If you have any short-term
additions or requests that will break API binary
|
By
Jeremy Selan <jeremy...@...>
·
#441
·
|
|
Re: Status of CSP prelut?
Ben,
So if you're still interested in implementing this feel free to take a
stab.
What you'll probably want to do is to copy the code from the specified
link,
add it to an anonymous namespace in the
Ben,
So if you're still interested in implementing this feel free to take a
stab.
What you'll probably want to do is to copy the code from the specified
link,
add it to an anonymous namespace in the
|
By
Jeremy Selan <jeremy...@...>
·
#440
·
|
|
Review: update config file loading
Commit:
http://github.com/jeremyselan/OpenColorIO/commit/05354bc1aad4325eca4cdbef64b4edaade8f16dc
$OCIO, ociocheck, and other programs that end up calling
Config::CreateFromFile(...), can now specify
Commit:
http://github.com/jeremyselan/OpenColorIO/commit/05354bc1aad4325eca4cdbef64b4edaade8f16dc
$OCIO, ociocheck, and other programs that end up calling
Config::CreateFromFile(...), can now specify
|
By
Jeremy Selan <jeremy...@...>
·
#439
·
|
|
Review: ociocheck
Commit:
http://github.com/jeremyselan/OpenColorIO/commit/8be4a3ba174c69438cf151802f829696cb7b6555
ociocheck now does much better error checking.
It will test each colorspace and see which conversions
Commit:
http://github.com/jeremyselan/OpenColorIO/commit/8be4a3ba174c69438cf151802f829696cb7b6555
ociocheck now does much better error checking.
It will test each colorspace and see which conversions
|
By
Jeremy Selan <jeremy...@...>
·
#438
·
|
|
Review: upgrade to pyglue
Commits:
http://github.com/jeremyselan/OpenColorIO/commit/a764a5f7fb151d13be93107697262a670ba34392
This add kwarg support to most of the transform constructors in
python. Makes it way more
Commits:
http://github.com/jeremyselan/OpenColorIO/commit/a764a5f7fb151d13be93107697262a670ba34392
This add kwarg support to most of the transform constructors in
python. Makes it way more
|
By
Jeremy Selan <jeremy...@...>
·
#437
·
|