|
Re: Review: added ociobuildicc app
This is great :D
I generated a LUT without issue, and it was as close as I would expect from Photoshop...
Only nitpick'y problem I can see is the --outputfile argument seems to be redundant given
This is great :D
I generated a LUT without issue, and it was as close as I would expect from Photoshop...
Only nitpick'y problem I can see is the --outputfile argument seems to be redundant given
|
By
"dbr/Ben" <b...@...>
·
#422
·
|
|
Re: Review: added ociobuildicc app
ociobuildicc --description="spi-vfx log test" --workingspace compositing_log --viewspace sRGB /Users/malcolm/Library/ColorSync/Profiles/spi-vfx_compositing_log_test.icc
sure, it depends on how
ociobuildicc --description="spi-vfx log test" --workingspace compositing_log --viewspace sRGB /Users/malcolm/Library/ColorSync/Profiles/spi-vfx_compositing_log_test.icc
sure, it depends on how
|
By
Malcolm Humphreys <malcolmh...@...>
·
#420
·
|
|
Re: Review: added ociobuildicc app
Malcolm,
This is awesome! I've wanted to have icc export for so long, this is
hugely appreciated. (We'll use it at SPI immediately)
* What are the command-line arguments used in your example? I'd
Malcolm,
This is awesome! I've wanted to have icc export for so long, this is
hugely appreciated. (We'll use it at SPI immediately)
* What are the command-line arguments used in your example? I'd
|
By
Jeremy Selan <jeremy...@...>
·
#416
·
|
|
Re: Review: added ociobuildicc app
Also added Little CMS to LICENSE file
Commit:
https://github.com/malcolmhumphreys/OpenColorIO/commit/8ff296f8ab234ea7b06704036037bf2a132ebd6a
.malcolm
Also added Little CMS to LICENSE file
Commit:
https://github.com/malcolmhumphreys/OpenColorIO/commit/8ff296f8ab234ea7b06704036037bf2a132ebd6a
.malcolm
|
By
Malcolm Humphreys <malcolmh...@...>
·
#419
·
|
|
Re: Review: added ociobuildicc app
Attaching some slightly larger examples :)
Attaching some slightly larger examples :)
|
By
Malcolm Humphreys <malcolmh...@...>
·
#418
·
|
|
Review: added ociobuildicc app
Added ociobuildicc app which will build a soft-proofing icc profile for a given working space.
(added LCMS2 into
Added ociobuildicc app which will build a soft-proofing icc profile for a given working space.
(added LCMS2 into
|
By
Malcolm Humphreys <malcolmh...@...>
·
#417
·
|
|
Re: Review: FileTransform supports .cc and .ccc files
LGTM, committed.
Thanks!
-- Jeremy
LGTM, committed.
Thanks!
-- Jeremy
|
By
Jeremy Selan <jeremy...@...>
·
#409
·
|
|
Re: Review: FileTransform supports .cc and .ccc files
Oh,https://github.com/dbr/OpenColorIO/commit/0247f16ae202eeb5316f695c1310dac523272a0e
Oh,https://github.com/dbr/OpenColorIO/commit/0247f16ae202eeb5316f695c1310dac523272a0e
|
By
"dbr/Ben" <b...@...>
·
#415
·
|
|
Re: Review: Replaced config->getRoleNameByIndex
LGTM - committed.
-- Jeremy
<malcolmh...@...> wrote:
LGTM - committed.
-- Jeremy
<malcolmh...@...> wrote:
|
By
Jeremy Selan <jeremy...@...>
·
#408
·
|
|
Re: Review: DisplayTransform interface update
I think that's a perfect description of all the terminology. I'm
thinking a glossary section (front page of webpage?, inside the FAQ?)
would be appropriate.
I'm thinking of naming the class that
I think that's a perfect description of all the terminology. I'm
thinking a glossary section (front page of webpage?, inside the FAQ?)
would be appropriate.
I'm thinking of naming the class that
|
By
Jeremy Selan <jeremy...@...>
·
#407
·
|
|
Re: Review: DisplayTransform interface update
I would think looks would be something separate from views.
Terminology we currently have:
- Transform - functions that transform RGBA data
- ReferenceSpace - a space that connects ColorSpaces
-
I would think looks would be something separate from views.
Terminology we currently have:
- Transform - functions that transform RGBA data
- ReferenceSpace - a space that connects ColorSpaces
-
|
By
Malcolm Humphreys <malcolmh...@...>
·
#414
·
|
|
Re: Review: Replaced config->getRoleNameByIndex
Replaced config->getRoleNameByIndex() with config->getRoleName()
- getRoleNameByIndex returned the colorspace name not the role name, also ..ByIndex seemed redundant in the signature.
Added
Replaced config->getRoleNameByIndex() with config->getRoleName()
- getRoleNameByIndex returned the colorspace name not the role name, also ..ByIndex seemed redundant in the signature.
Added
|
By
Malcolm Humphreys <malcolmh...@...>
·
#413
·
|
|
Re: Review: Python build warning fix
LGTM
By
Malcolm Humphreys <malcolmh...@...>
·
#412
·
|
|
Review: Python build warning fix
Commit:
http://github.com/jeremyselan/OpenColorIO/commit/d37b316cd8354216b4d89b85c06ab08108b5d1cc
A pretty trivial change, include python.h first when building pyglue.
Some linux installations are
Commit:
http://github.com/jeremyselan/OpenColorIO/commit/d37b316cd8354216b4d89b85c06ab08108b5d1cc
A pretty trivial change, include python.h first when building pyglue.
Some linux installations are
|
By
Jeremy Selan <jeremy...@...>
·
#406
·
|
|
Re: Review: DisplayTransform interface update
Cool, no pressure just wanted to know if this was the direction we were thinking of going.
.malcolm
Cool, no pressure just wanted to know if this was the direction we were thinking of going.
.malcolm
|
By
Malcolm Humphreys <malcolmh...@...>
·
#411
·
|
|
Re: Review: DisplayTransform interface update
Yes, I like it. Just haven't had a chance to update the code and
re-submit yet. Sorry...
-- Jeremy
<malcolmh...@...> wrote:
Yes, I like it. Just haven't had a chance to update the code and
re-submit yet. Sorry...
-- Jeremy
<malcolmh...@...> wrote:
|
By
Jeremy Selan <jeremy...@...>
·
#405
·
|
|
Re: Review: DisplayTransform interface update
Did you have any thoughts on this?
Did you have any thoughts on this?
|
By
Malcolm Humphreys <malcolmh...@...>
·
#410
·
|
|
Re: Review: DisplayTransform interface update
Could this not be part of the API? the core could just keep around the list that was in the profile as the default list and then the active would either be a copy of this or what was ever dynamically
Could this not be part of the API? the core could just keep around the list that was in the profile as the default list and then the active would either be a copy of this or what was ever dynamically
|
By
Malcolm Humphreys <malcolmh...@...>
·
#404
·
|
|
Re: Review: DisplayTransform interface update
Would the 'view' terminology be able to encompass your concept of looks? Id it does then I'm onboard
-Joseph
Would the 'view' terminology be able to encompass your concept of looks? Id it does then I'm onboard
-Joseph
|
By
Joseph Slomka <jsl...@...>
·
#401
·
|
|
Re: Review: DisplayTransform interface update
Oh, and have we agreed to use 'View' rather than 'Alias'? I'm cool with that...
-- Jeremy
Oh, and have we agreed to use 'View' rather than 'Alias'? I'm cool with that...
-- Jeremy
|
By
Jeremy Selan <jeremy...@...>
·
#400
·
|