|
Review: updated ociodisplay + ocioconvert
Issue:
http://github.com/imageworks/OpenColorIO/issues#issue/51
Commit:
http://github.com/jeremyselan/OpenColorIO/commit/afe8a04366515a152197c345e0362bd6f5540c37
* Added makefile support for
Issue:
http://github.com/imageworks/OpenColorIO/issues#issue/51
Commit:
http://github.com/jeremyselan/OpenColorIO/commit/afe8a04366515a152197c345e0362bd6f5540c37
* Added makefile support for
|
By
Jeremy Selan <jeremy...@...>
·
#351
·
|
|
Re: Review: Misc fixes
LGTM
.malcolm
By
Malcolm Humphreys <malcolmh...@...>
·
#353
·
|
|
Review: Misc fixes
3 unrelated commits.
1) Updated an error message in config loading.
http://github.com/jeremyselan/OpenColorIO/commit/05b84bca45187f4f5f2c8117ce0bb2a553a36f16
2) GLSL shader doesnt use invalid
3 unrelated commits.
1) Updated an error message in config loading.
http://github.com/jeremyselan/OpenColorIO/commit/05b84bca45187f4f5f2c8117ce0bb2a553a36f16
2) GLSL shader doesnt use invalid
|
By
Jeremy Selan <jeremy...@...>
·
#350
·
|
|
Re: Review: Support python with --exec-prefix and registering Nuke viewer processes
Done.
I've checked this into master, with a few changes:
* Nuke_INSTALL_PATH is now NUKE_INSTALL_PATH (all caps)
I know the old value predates this checkin, but now that it's
publicized I figure we
Done.
I've checked this into master, with a few changes:
* Nuke_INSTALL_PATH is now NUKE_INSTALL_PATH (all caps)
I know the old value predates this checkin, but now that it's
publicized I figure we
|
By
Jeremy Selan <jeremy...@...>
·
#348
·
|
|
Re: Review: Support python with --exec-prefix and registering Nuke viewer processes
It all looks great other than the ocio_viewer as I would need to disable this for our install.
I think the nuke nodes should only be registered as part of the ocio project initialisation.
Viewer
It all looks great other than the ocio_viewer as I would need to disable this for our install.
I think the nuke nodes should only be registered as part of the ocio project initialisation.
Viewer
|
By
Malcolm Humphreys <malcolmh...@...>
·
#349
·
|
|
Re: Review: Support python with --exec-prefix and registering Nuke viewer processes
Thanks for the commits!
Look great at first glance. (I'll run it all this afternoon to make
sure it works multi-platform, etc). I like all the nuke cleanup, very
sensible.
My one concern is I'm
Thanks for the commits!
Look great at first glance. (I'll run it all this afternoon to make
sure it works multi-platform, etc). I like all the nuke cleanup, very
sensible.
My one concern is I'm
|
By
Jeremy Selan <jeremy...@...>
·
#344
·
|
|
Review: Support python with --exec-prefix and registering Nuke viewer processes
I've made a few minor changes, partly to familiarise myself with the
code, partly to say thanks for open-sourcing this extremely useful
project!
First change - there was a hardcoded Nuke path, which
I've made a few minor changes, partly to familiarise myself with the
code, partly to say thanks for open-sourcing this extremely useful
project!
First change - there was a hardcoded Nuke path, which
|
By
"dbr/Ben" <dbr....@...>
·
#343
·
|
|
Re: Review: Exposed gamma control on Nuke OCIODisplay node
done.
<malcolmh...@...> wrote:
done.
<malcolmh...@...> wrote:
|
By
Jeremy Selan <jeremy...@...>
·
#342
·
|
|
Re: Review: Exposed gamma control on Nuke OCIODisplay node
perfect
By
Malcolm Humphreys <malcolmh...@...>
·
#347
·
|
|
Re: Review: Exposed gamma control on Nuke OCIODisplay node
Spaces in knob names have always worried me. How about an underscore
in the knob name?
<malcolmh...@...> wrote:
Spaces in knob names have always worried me. How about an underscore
in the knob name?
<malcolmh...@...> wrote:
|
By
Jeremy Selan <jeremy...@...>
·
#341
·
|
|
Re: Review: Exposed gamma control on Nuke OCIODisplay node
I would do both just for consistency.
I would do both just for consistency.
|
By
Malcolm Humphreys <malcolmh...@...>
·
#346
·
|
|
Re: Review: Exposed gamma control on Nuke OCIODisplay node
UI Label or underlying knob name?
<malcolmh...@...> wrote:
UI Label or underlying knob name?
<malcolmh...@...> wrote:
|
By
Jeremy Selan <jeremy...@...>
·
#340
·
|
|
Re: Review: Exposed gamma control on Nuke OCIODisplay node
LGTM
I would be tempted to name the knob 'display gamma'.
.malcolm
LGTM
I would be tempted to name the knob 'display gamma'.
.malcolm
|
By
Malcolm Humphreys <malcolmh...@...>
·
#345
·
|
|
Review: Exposed gamma control on Nuke OCIODisplay node
Issue:
http://github.com/imageworks/OpenColorIO/issues#issue/45
Commit:
http://github.com/jeremyselan/OpenColorIO/commit/c206c4fe65d415b5c87c09acde3e05013dc0ab9f
I've exposed a gamma control for the
Issue:
http://github.com/imageworks/OpenColorIO/issues#issue/45
Commit:
http://github.com/jeremyselan/OpenColorIO/commit/c206c4fe65d415b5c87c09acde3e05013dc0ab9f
I've exposed a gamma control for the
|
By
Jeremy Selan <jeremy...@...>
·
#339
·
|
|
Re: Review: Added html and pdf documentation generation using sphinx
Malcolm, I wasn't able to build the docs at home even on OSX 10.6.
Would you try the master repo on your machine again (post merge) to
verify it works for you?
-- Jeremy
Malcolm, I wasn't able to build the docs at home even on OSX 10.6.
Would you try the master repo on your machine again (post merge) to
verify it works for you?
-- Jeremy
|
By
Jeremy Selan <jeremy...@...>
·
#338
·
|
|
Re: Review: Added html and pdf documentation generation using sphinx
Looks good to me. I did the merge, but disabled doc generation in the
top-level makefile by default. When you add the explicit target i'll
just roll that in too.
Thanks!
-- Jeremy
Looks good to me. I did the merge, but disabled doc generation in the
top-level makefile by default. When you add the explicit target i'll
just roll that in too.
Thanks!
-- Jeremy
|
By
Jeremy Selan <jeremy...@...>
·
#333
·
|
|
0.7.4 Released
Version 0.7.4 (Jan 4 2011):
* Added Context, allowing for 'per-shot' Transforms
* Misc API Cleanup: removed old functions + fixed const-ness
* Added config.sanityCheck() for validation
Version 0.7.4 (Jan 4 2011):
* Added Context, allowing for 'per-shot' Transforms
* Misc API Cleanup: removed old functions + fixed const-ness
* Added config.sanityCheck() for validation
|
By
Jeremy Selan <jeremy...@...>
·
#332
·
|
|
Re: Review: Makefile updates
Yah, these conflict in:
export/OpenColorIO/OpenColorIO.h
src/pyglue/CMakeLists.txt
Looks easy to address though. Why don't you checkin the extra build
option to make the docs optional on your
Yah, these conflict in:
export/OpenColorIO/OpenColorIO.h
src/pyglue/CMakeLists.txt
Looks easy to address though. Why don't you checkin the extra build
option to make the docs optional on your
|
By
Jeremy Selan <jeremy...@...>
·
#331
·
|
|
Re: Review: Makefile updates
LGTM,
This might slightly conflict with the docs commit just see how you go.
.malcolm
LGTM,
This might slightly conflict with the docs commit just see how you go.
.malcolm
|
By
Malcolm Humphreys <malcolmh...@...>
·
#337
·
|
|
Re: Review: added pycontext
LGTM
By
Malcolm Humphreys <malcolmh...@...>
·
#336
·
|