Issue: http://github.com/imageworks/OpenColorIO/issues#issue/51 Commit: http://github.com/jeremyselan/OpenColorIO/commit/afe8a04366515a152197c345e0362bd6f5540c37 * Added makefile support for

LGTM .malcolm

3 unrelated commits. 1) Updated an error message in config loading. http://github.com/jeremyselan/OpenColorIO/commit/05b84bca45187f4f5f2c8117ce0bb2a553a36f16 2) GLSL shader doesnt use invalid

Done. I've checked this into master, with a few changes: * Nuke_INSTALL_PATH is now NUKE_INSTALL_PATH (all caps) I know the old value predates this checkin, but now that it's publicized I figure we

It all looks great other than the ocio_viewer as I would need to disable this for our install. I think the nuke nodes should only be registered as part of the ocio project initialisation. Viewer

Thanks for the commits! Look great at first glance. (I'll run it all this afternoon to make sure it works multi-platform, etc). I like all the nuke cleanup, very sensible. My one concern is I'm

I've made a few minor changes, partly to familiarise myself with the code, partly to say thanks for open-sourcing this extremely useful project! First change - there was a hardcoded Nuke path, which

done. <malcolmh...@...> wrote:

perfect

Spaces in knob names have always worried me. How about an underscore in the knob name? <malcolmh...@...> wrote:

I would do both just for consistency.

UI Label or underlying knob name? <malcolmh...@...> wrote:

LGTM I would be tempted to name the knob 'display gamma'. .malcolm

Issue: http://github.com/imageworks/OpenColorIO/issues#issue/45 Commit: http://github.com/jeremyselan/OpenColorIO/commit/c206c4fe65d415b5c87c09acde3e05013dc0ab9f I've exposed a gamma control for the

Malcolm, I wasn't able to build the docs at home even on OSX 10.6. Would you try the master repo on your machine again (post merge) to verify it works for you? -- Jeremy

Looks good to me. I did the merge, but disabled doc generation in the top-level makefile by default. When you add the explicit target i'll just roll that in too. Thanks! -- Jeremy

Version 0.7.4 (Jan 4 2011): * Added Context, allowing for 'per-shot' Transforms * Misc API Cleanup: removed old functions + fixed const-ness * Added config.sanityCheck() for validation

Yah, these conflict in: export/OpenColorIO/OpenColorIO.h src/pyglue/CMakeLists.txt Looks easy to address though. Why don't you checkin the extra build option to make the docs optional on your

LGTM, This might slightly conflict with the docs commit just see how you go. .malcolm

LGTM