ocio-dev@lists.aswf.io

Home Messages Hashtags Subgroups Calendar

Messages

Topics Expanded Polls

Export Group Data

Between

and

Re: Review: FileTransform supports .cc and .ccc files

LGTM, committed. Thanks! -- Jeremy

By Jeremy Selan <jeremy...@...> · #409 ·

Re: Review: FileTransform supports .cc and .ccc files

Oh,https://github.com/dbr/OpenColorIO/commit/0247f16ae202eeb5316f695c1310dac523272a0e

By "dbr/Ben" <b...@...> · #415 ·

Re: Review: Replaced config->getRoleNameByIndex

LGTM - committed. -- Jeremy <malcolmh...@...> wrote:

By Jeremy Selan <jeremy...@...> · #408 ·

Re: Review: DisplayTransform interface update

I think that's a perfect description of all the terminology. I'm thinking a glossary section (front page of webpage?, inside the FAQ?) would be appropriate. I'm thinking of naming the class that

By Jeremy Selan <jeremy...@...> · #407 ·

Re: Review: DisplayTransform interface update

I would think looks would be something separate from views. Terminology we currently have: - Transform - functions that transform RGBA data - ReferenceSpace - a space that connects ColorSpaces -

By Malcolm Humphreys <malcolmh...@...> · #414 ·

Re: Review: Replaced config->getRoleNameByIndex

Replaced config->getRoleNameByIndex() with config->getRoleName() - getRoleNameByIndex returned the colorspace name not the role name, also ..ByIndex seemed redundant in the signature. Added

By Malcolm Humphreys <malcolmh...@...> · #413 ·

Re: Review: Python build warning fix

LGTM

By Malcolm Humphreys <malcolmh...@...> · #412 ·

Review: Python build warning fix

Commit: http://github.com/jeremyselan/OpenColorIO/commit/d37b316cd8354216b4d89b85c06ab08108b5d1cc A pretty trivial change, include python.h first when building pyglue. Some linux installations are

By Jeremy Selan <jeremy...@...> · #406 ·

Re: Review: DisplayTransform interface update

Cool, no pressure just wanted to know if this was the direction we were thinking of going. .malcolm

By Malcolm Humphreys <malcolmh...@...> · #411 ·

Re: Review: DisplayTransform interface update

Yes, I like it. Just haven't had a chance to update the code and re-submit yet. Sorry... -- Jeremy <malcolmh...@...> wrote:

By Jeremy Selan <jeremy...@...> · #405 ·

Re: Review: DisplayTransform interface update

Did you have any thoughts on this?

By Malcolm Humphreys <malcolmh...@...> · #410 ·

Re: Review: DisplayTransform interface update

Could this not be part of the API? the core could just keep around the list that was in the profile as the default list and then the active would either be a copy of this or what was ever dynamically

By Malcolm Humphreys <malcolmh...@...> · #404 ·

Re: Review: DisplayTransform interface update

Would the 'view' terminology be able to encompass your concept of looks? Id it does then I'm onboard -Joseph

By Joseph Slomka <jsl...@...> · #401 ·

Re: Review: DisplayTransform interface update

Oh, and have we agreed to use 'View' rather than 'Alias'? I'm cool with that... -- Jeremy

By Jeremy Selan <jeremy...@...> · #400 ·

Re: Review: DisplayTransform interface update

Would this syntax preserve Display order? I think that's important. -- Jeremy

By Jeremy Selan <jeremy...@...> · #399 ·

Re: Review: DisplayTransform interface update

Malcom, I'm thinking of an edge case where you want to query the defalt displays of a color configuration independently of the active displays. The example I could think of is writing a script to

By Joseph Slomka <jsl...@...> · #398 ·

Re: Review: DisplayTransform interface update

Hi Joesph, Oh I was thinking in the profile the list of active_displays would be the defaults. Which then you could dynamically override with $OCIO_ACTIVE_DISPLAYS (which was called

By Malcolm Humphreys <malcolmh...@...> · #403 ·

Re: Review: DisplayTransform interface update

Malcom, I like your layout. I think that calling the The name change will allow the opportunity to have a list of default display that can be different from what the active displays are. I think

By Joseph Slomka <jsl...@...> · #397 ·

Re: Review: DisplayTransform interface update

Hi, Ok thats a bit clearer. But I think having this as a flat list is not so nice. After playing around with this a bit I came up with this layout. This makes it clearer that you have a set of

By Malcolm Humphreys <malcolmh...@...> · #402 ·

Re: Review: DisplayTransform interface update

Here's a chunk from spi-vfx with the new options: displays: - !<Display> {device: sRGB, alias: Raw, colorspace: nc10} - !<Display> {device: sRGB, alias: Log, colorspace: lg10} - !<Display>

By Jeremy Selan <jeremy...@...> · #396 ·

1861 - 1880 of 2272

Home Hashtags Subgroups Calendar Terms