|
Re: Review: DisplayTransform interface update
Here's a chunk from spi-vfx with the new options:
displays:
- !<Display> {device: sRGB, alias: Raw, colorspace: nc10}
- !<Display> {device: sRGB, alias: Log, colorspace: lg10}
- !<Display>
Here's a chunk from spi-vfx with the new options:
displays:
- !<Display> {device: sRGB, alias: Raw, colorspace: nc10}
- !<Display> {device: sRGB, alias: Log, colorspace: lg10}
- !<Display>
|
By
Jeremy Selan <jeremy...@...>
·
#396
·
|
|
Re: Review: FileTransform supports .cc and .ccc files
This sounds like a good solution, much less error prone than storing the dropdown in the node itself.
The J_3Way node (http://major-kong.blogspot.com/2010/01/jops-10v1a5-released.html ) has a nice UI
This sounds like a good solution, much less error prone than storing the dropdown in the node itself.
The J_3Way node (http://major-kong.blogspot.com/2010/01/jops-10v1a5-released.html ) has a nice UI
|
By
"dbr/Ben" <b...@...>
·
#395
·
|
|
Re: Review: FileTransform supports .cc and .ccc files
Good point. I've renamed the first section "A contrived example", which just explains using env-vars to find a LUT. The second example is more practical, and applies the grade, then a lin-to-log/3D
Good point. I've renamed the first section "A contrived example", which just explains using env-vars to find a LUT. The second example is more practical, and applies the grade, then a lin-to-log/3D
|
By
"dbr/Ben" <b...@...>
·
#394
·
|
|
Re: Review: FileTransform supports .cc and .ccc files
Hi Ben,
I love docs :) (because of my horrible memory)
My main comments would be I would tend to aim 'contexts' being used as part of the complete viewing transform. Right now it reads as though we
Hi Ben,
I love docs :) (because of my horrible memory)
My main comments would be I would tend to aim 'contexts' being used as part of the complete viewing transform. Right now it reads as though we
|
By
Malcolm Humphreys <malcolmh...@...>
·
#393
·
|
|
Re: Review: FileTransform supports .cc and .ccc files
LGTM
.malcolm
By
Malcolm Humphreys <malcolmh...@...>
·
#392
·
|
|
Review: Processor.getGpuShaderTextCacheID()
LGTM
Begin forwarded message:
LGTM
Begin forwarded message:
|
By
Malcolm Humphreys <malcolmh...@...>
·
#391
·
|
|
Re: Review: DisplayTransform interface update
Hi,
Can you post an example profile with a few more display lines. The code for this looks fine, I'm just not too sure of the structure in the yaml and how clear the names device and alias are as
Hi,
Can you post an example profile with a few more display lines. The code for this looks fine, I'm just not too sure of the structure in the yaml and how clear the names device and alias are as
|
By
Malcolm Humphreys <malcolmh...@...>
·
#390
·
|
|
Re: Review: FileTransform supports .cc and .ccc files
Nice job on the docs. By all means, check them in! (Even partial
docs are better than nothing). :)
I like this, but I'm not sure that there's a nuke UI widget rich
enough for this behavior. What
Nice job on the docs. By all means, check them in! (Even partial
docs are better than nothing). :)
I like this, but I'm not sure that there's a nuke UI widget rich
enough for this behavior. What
|
By
Jeremy Selan <jeremy...@...>
·
#388
·
|
|
Re: Review: FileTransform supports .cc and .ccc files
This is great. Nice and intuitive \o/
!<FileTransform> {src: grades/grades.ccc, cccid: "beauty/${SEQ}/${SHOT}"}
..or, could split the grades into one file per seq and do ({src:
This is great. Nice and intuitive \o/
!<FileTransform> {src: grades/grades.ccc, cccid: "beauty/${SEQ}/${SHOT}"}
..or, could split the grades into one file per seq and do ({src:
|
By
"dbr/Ben" <b...@...>
·
#389
·
|
|
Review: FileTransform supports .cc and .ccc files
Commits:
http://github.com/jeremyselan/OpenColorIO/commit/843407c6a15df2afa817412614d3d6606d2fa613
http://github.com/jeremyselan/OpenColorIO/commit/dd77b2c5b789d56d8043a33a2e4bea7e99886f2a
Issue:
htt
Commits:
http://github.com/jeremyselan/OpenColorIO/commit/843407c6a15df2afa817412614d3d6606d2fa613
http://github.com/jeremyselan/OpenColorIO/commit/dd77b2c5b789d56d8043a33a2e4bea7e99886f2a
Issue:
htt
|
By
Jeremy Selan <jeremy...@...>
·
#387
·
|
|
Review: Processor.getGpuShaderTextCacheID()
Commit:
http://github.com/jeremyselan/OpenColorIO/commit/7ffb711edea3b4b3c4aa0ad046c15de8f70b936e
I added a call to get the cacheID for the shadertext on the processor
object. Note that querying the
Commit:
http://github.com/jeremyselan/OpenColorIO/commit/7ffb711edea3b4b3c4aa0ad046c15de8f70b936e
I added a call to get the cacheID for the shadertext on the processor
object. Note that querying the
|
By
Jeremy Selan <jeremy...@...>
·
#386
·
|
|
Review: DisplayTransform interface update
Commit:
http://github.com/jeremyselan/OpenColorIO/commit/2ac16ae5e55949e297ed0d14baa585f04ff4d452
Issues:
https://github.com/imageworks/OpenColorIO/issues#issue/25
https://github.com/imageworks/OpenC
Commit:
http://github.com/jeremyselan/OpenColorIO/commit/2ac16ae5e55949e297ed0d14baa585f04ff4d452
Issues:
https://github.com/imageworks/OpenColorIO/issues#issue/25
https://github.com/imageworks/OpenC
|
By
Jeremy Selan <jeremy...@...>
·
#385
·
|
|
Re: Review: Replaced config->getRoleNameByIndex
Sure that sounds great, i'll fix that.
I don't remind removing them altogether.
I was really just adding them to match the old functionality of getRoleNameByIndex() which returned the colorspace
Sure that sounds great, i'll fix that.
I don't remind removing them altogether.
I was really just adding them to match the old functionality of getRoleNameByIndex() which returned the colorspace
|
By
Malcolm Humphreys <malcolmh...@...>
·
#384
·
|
|
Re: Review: Replaced config->getRoleNameByIndex
Thanks!
I like the intent, but have two minor issues:
First, the trivial: I'd prefer to never allow NULL values as return
types from const char * functions. Please use an empty string
Thanks!
I like the intent, but have two minor issues:
First, the trivial: I'd prefer to never allow NULL values as return
types from const char * functions. Please use an empty string
|
By
Jeremy Selan <jeremy...@...>
·
#382
·
|
|
Re: Context/per-shot grades
Unfortunately we dont have support yet for environment-driven
numerical parameters. It's something I'd like to add eventually, but
there are few hotter API issues I need to tackle first.
To summarize
Unfortunately we dont have support yet for environment-driven
numerical parameters. It's something I'd like to add eventually, but
there are few hotter API issues I need to tackle first.
To summarize
|
By
Jeremy Selan <jeremy...@...>
·
#381
·
|
|
Re: Is the const type qualifier only in CG?
hmmm tried to do that last night, but something went left of field. I now have a branch thats up to date with imageworks/master but the commits are in the future.. doesn't really matter as I'm hoping
hmmm tried to do that last night, but something went left of field. I now have a branch thats up to date with imageworks/master but the commits are in the future.. doesn't really matter as I'm hoping
|
By
Malcolm Humphreys <malcolmh...@...>
·
#383
·
|
|
Re: Is the const type qualifier only in CG?
That's no problem at all.
FYI, this really easy to solve with the 'rebase' command. Say you
have a branch and you want to incorporate all changes on spi/master.
(I've already setup the spi remote,
That's no problem at all.
FYI, this really easy to solve with the 'rebase' command. Say you
have a branch and you want to incorporate all changes on spi/master.
(I've already setup the spi remote,
|
By
Jeremy Selan <jeremy...@...>
·
#378
·
|
|
Re: Is the const type qualifier only in CG?
Whoops, I should live by that mantra 'update or die'. I have a few
too many different checkouts of ocio, still a bit in svn land, goto to
get used to using local git branches.
This fixed this issue
Whoops, I should live by that mantra 'update or die'. I have a few
too many different checkouts of ocio, still a bit in svn land, goto to
get used to using local git branches.
This fixed this issue
|
By
Malcolm Humphreys <malcolmh...@...>
·
#380
·
|
|
Re: Is the const type qualifier only in CG?
Yes, if you look att Processor.cpp : 381, you'll see that on apple
platforms we always insert a sampling of the tex2 even if it's not
needed. It appeared that without this, if the 3dlut was unused
Yes, if you look att Processor.cpp : 381, you'll see that on apple
platforms we always insert a sampling of the tex2 even if it's not
needed. It appeared that without this, if the 3dlut was unused
|
By
Jeremy Selan <jeremy...@...>
·
#374
·
|
|
Re: Is the const type qualifier only in CG?
I already fixed this too; thought it was checked in last week. hold
for details.
-- Jeremy
<malcolmh...@...> wrote:
I already fixed this too; thought it was checked in last week. hold
for details.
-- Jeremy
<malcolmh...@...> wrote:
|
By
Jeremy Selan <jeremy...@...>
·
#373
·
|