|
Review: Support for per-shot looks
Commits:
1a54ec8d76
Resolves Issue #16:
http://github.com/imageworks/OpenColorIO/issues#issue/16
This commit enables color transforms to leverage environment variables
+ search paths to determine
Commits:
1a54ec8d76
Resolves Issue #16:
http://github.com/imageworks/OpenColorIO/issues#issue/16
This commit enables color transforms to leverage environment variables
+ search paths to determine
|
By
Jeremy Selan <jeremy...@...>
·
#322
·
|
|
Re: Review: Add config.sanityCheck
Thanks, I'm going to check this in then.
-- Jeremy
<malcolmh...@...> wrote:
Thanks, I'm going to check this in then.
-- Jeremy
<malcolmh...@...> wrote:
|
By
Jeremy Selan <jeremy...@...>
·
#320
·
|
|
Re: Review: Add config.sanityCheck
yeah I guess you would either need to do that or have some config.getErrorMsg() function.
No I think it's ok esp if people are used to the ilm code.
The ilm code does call header.sanityCheck when
yeah I guess you would either need to do that or have some config.getErrorMsg() function.
No I think it's ok esp if people are used to the ilm code.
The ilm code does call header.sanityCheck when
|
By
Malcolm Humphreys <malcolmh...@...>
·
#321
·
|
|
Re: Review: Add config.sanityCheck
Either of our approaches will work, of course, but I'm still inclined
to go with the exception route.
A bunch of calls in OCIO can throw exceptions (the common one being
config->getProcessor(...) ),
Either of our approaches will work, of course, but I'm still inclined
to go with the exception route.
A bunch of calls in OCIO can throw exceptions (the common one being
config->getProcessor(...) ),
|
By
Jeremy Selan <jeremy...@...>
·
#319
·
|
|
Re: Review: removed config.getEditableColorSpace
LGTM
By
Malcolm Humphreys <malcolmh...@...>
·
#318
·
|
|
Re: Review: Add config.sanityCheck
Not really.
Would you ever expect to call OCIO::GetCurrentConfig() and get back a pointer to an invalid profile? Throwing an exception from inside GetCurrentConfig() feels sensible, while throwing in
Not really.
Would you ever expect to call OCIO::GetCurrentConfig() and get back a pointer to an invalid profile? Throwing an exception from inside GetCurrentConfig() feels sensible, while throwing in
|
By
Malcolm Humphreys <malcolmh...@...>
·
#317
·
|
|
Re: Adding multiple bit depths to one <!ColorSpace>
Malcolm - interesting idea!
I do agree that right now families feel a bit like a second-class
concept, and I would like them to be easier to deal with. I also
agree that it's appealing to present
Malcolm - interesting idea!
I do agree that right now families feel a bit like a second-class
concept, and I would like them to be easier to deal with. I also
agree that it's appealing to present
|
By
Jeremy Selan <jeremy...@...>
·
#316
·
|
|
Review: removed config.getEditableColorSpace
This checkin removed config.getEditableColorSpace(...). Users should
use the existing getColorSpace, and addColorSpace as replacements.
getEditableColorSpace has always been a wart on the OCIO API,
This checkin removed config.getEditableColorSpace(...). Users should
use the existing getColorSpace, and addColorSpace as replacements.
getEditableColorSpace has always been a wart on the OCIO API,
|
By
Jeremy Selan <jeremy...@...>
·
#315
·
|
|
Re: Review: Add config.sanityCheck
Your idea would also work. Not sure if either is better.
sanityCheck() was inspired by OpenEXR, which has a function of the
same name, and performs a similar action. Guess I just had that model
in
Your idea would also work. Not sure if either is better.
sanityCheck() was inspired by OpenEXR, which has a function of the
same name, and performs a similar action. Guess I just had that model
in
|
By
Jeremy Selan <jeremy...@...>
·
#313
·
|
|
Re: Review: Add config.sanityCheck
Could we call this config.validate(), I know we are all a bit insane ;)
enum ConfigValid
{
CONFIG_UNKNOWN = 0,
CONFIG_VALID,
CONFIG_INVALID
}
What do you think about not throwing an
Could we call this config.validate(), I know we are all a bit insane ;)
enum ConfigValid
{
CONFIG_UNKNOWN = 0,
CONFIG_VALID,
CONFIG_INVALID
}
What do you think about not throwing an
|
By
Malcolm Humphreys <malcolmh...@...>
·
#314
·
|
|
Review: Add config.sanityCheck
This will prevent the issues Blake encountered from happening again.
http://groups.google.com/group/ocio-dev/browse_thread/thread/c073e0f4fde995f7
This also addresses an outstanding
This will prevent the issues Blake encountered from happening again.
http://groups.google.com/group/ocio-dev/browse_thread/thread/c073e0f4fde995f7
This also addresses an outstanding
|
By
Jeremy Selan <jeremy...@...>
·
#312
·
|
|
Re: Testing Nuke Plugins
An updated nuke-default profile has been posted that should resolve
all your issues:
http://sites.google.com/site/opencolorio/downloads
Sorry for the trouble!
(I'll be submitting a patch later today
An updated nuke-default profile has been posted that should resolve
all your issues:
http://sites.google.com/site/opencolorio/downloads
Sorry for the trouble!
(I'll be submitting a patch later today
|
By
Jeremy Selan <jeremy...@...>
·
#311
·
|
|
Re: Testing Nuke Plugins
Blake,
Thanks for the testing!
* Glad to hear OCIOFileTransform is working. My goal is to support
(at a minimum) all of Nuke's lut formats in the near future.
* We're lucky that the nuke cineon
Blake,
Thanks for the testing!
* Glad to hear OCIOFileTransform is working. My goal is to support
(at a minimum) all of Nuke's lut formats in the near future.
* We're lucky that the nuke cineon
|
By
Jeremy Selan <jeremy...@...>
·
#310
·
|
|
Re: Testing Nuke Plugins
Gah. Correction:
The OCIODisplay node seems to ignore the 'input colorspace' knob.
Display transform and exposure work as expected.
As for the LogConvert node, switching the operation from loglin
Gah. Correction:
The OCIODisplay node seems to ignore the 'input colorspace' knob.
Display transform and exposure work as expected.
As for the LogConvert node, switching the operation from loglin
|
By
bsloan <bsl...@...>
·
#309
·
|
|
Testing Nuke Plugins
Hi all,
I've tested the OCIO 0.7.3 Nuke suite in Nuke 6.1v3 and have noticed
some possible bugs (or user errors ).
First of all, I downloaded the configs for 0.7 and pointed my OCIO env
var to the
Hi all,
I've tested the OCIO 0.7.3 Nuke suite in Nuke 6.1v3 and have noticed
some possible bugs (or user errors ).
First of all, I downloaded the configs for 0.7 and pointed my OCIO env
var to the
|
By
bsloan <bsl...@...>
·
#308
·
|
|
Re: Adding multiple bit depths to one <!ColorSpace>
Hi did you guys have any more thoughts on this? Jeremy do you see this fitting in somehow with contexts?
.malcolm
Hi did you guys have any more thoughts on this? Jeremy do you see this fitting in somehow with contexts?
.malcolm
|
By
Malcolm Humphreys <malcolmh...@...>
·
#307
·
|
|
0.7.3 Released
Version 0.7.3 (Dec 16 2010):
* Added example applications: ociodisplay, ocioconvert
* Makefile: Add boost header dependency
* Makefile: Nuke plugins are now version specific
* Fixed
Version 0.7.3 (Dec 16 2010):
* Added example applications: ociodisplay, ocioconvert
* Makefile: Add boost header dependency
* Makefile: Nuke plugins are now version specific
* Fixed
|
By
Jeremy Selan <jeremy...@...>
·
#306
·
|
|
Re: Review: Added example image viewer
LGTM
By
Malcolm Humphreys <malcolmh...@...>
·
#305
·
|
|
Re: Review: updated readme and usage example
LGTM
By
Malcolm Humphreys <malcolmh...@...>
·
#304
·
|
|
Re: Review: Bugfix for GLSL GPU
LGTM
By
Malcolm Humphreys <malcolmh...@...>
·
#303
·
|