Re: An OCS by any other name?
Jeremy Selan <jeremy...@...>
FYI,
We've started the process for getting legal clearance on OpenColorIO. Bonus kudos to Malcolm Humphreys for suggesting the name! -- Jeremy
|
|
Re: OpenColorSpace.h feedback
Jeremy Selan <jeremy...@...>
We have started to write some of the plugins we had before for 3delight, mantra, nuke, shake and houdini & mantra for applying the ASC-CDL. At the moment they all use the same code, I was hoping to replace this with an OCS::Op::CDL() op. This I guess changes the requirements for Ops a bit, but I would like to use the same color math across client apps for the simple cases. For cases like 3delight and mantra were you just want to call a single simple Op per sample, having access to the Op directly would also reduce the overhead of setting up ImageDesc() so that you can evaluate a simple op.I still believe that ops should not be part of the external API, though I think we can offer you a simple solution. We will expose a CDLTransform (note that it will be implemented without a native CDLOp, relying on the existing MatrixOffset and Gamma Ops). Have you seen the processor class in our recent checkin? It currently has an apply(ImageDesc & img) call. We can add an additional singlePixel variant that takes a raw float *. This will make it efficient to apply your cdl per-pixel with minimal overhead. What I left out of my last post was the suggestion that Ops should be plugins. I have a few cases like non standard transfer functions and support for calling libs like truelight or cinespace as an Op which I don't think belong in the OCS core. Cortex already has an Op for truelight which you might find interestinghttp://code.google.com/p/cortex-vfx/source/browse/trunk/src/IECoreTru... I think having some form of extendibility at the Op level will be needed for OCS to be widely adopted. It will be hard for people to take on if they can't replicate the workflow (broken or not) they have right now.I've been thinking a lot about op plugins -- I'm really on the fence -- but my current thought it to avoid it for 1.0. First, I fear that a plugin system, not done well, will lead to a lot of user confusion. I really want OCS files to be totally portable, where you dont have to think about versions or compatibility. I can picture a lead FX house coming up with an OCS configuration not realizing it's using an optional plugin format, distributing it, and then complications arising downsteam once they've distributed the profile. There would also be a whole range of issues related to plugin binary compatibility, registration, image quality, etc. Furthermore, I've always been strongly philosophically opposed to 'locked' LUT formats, and would like to discourage their use in interchange. (Locked lut formats are all pretense anyways, if you give me an API where I can process an image, I'll guarantee you I can fish the lut out. In fact, the OCS GPU pipeline takes advantage of this approach!) For 'broken' current workflows that people need to emulate, I'd love to attack them on case-by-case basis. I'd be really surprised if even the worst workflows we need to support would rely on ops we couldn't provide base level emulation of. It's an open source project, so if someone wants to add an additional 'custom' op so their workflow can be supported, I'd prefer that. Do you have any specific examples you could provide more info on? Finally, I'm worried about feature creep. My gut tells me that this could be a can of worms, and we're short on time for 1.0 already. There's a lot of intricacies in doing a proper plugin API, and I'd rather give it the time it deserves. How does a plugin system work with an .ocs bundle file? How does it work with GPU generation? What about multi-platform plugin support? What about Op reuse? In the long term, I'm totally open to reconsidering the idea; I feel it's just a bit too much to add to our plate right now. Thanks for the feedback! -- Jeremy
|
|
OCS 0.5.8 posted
Jeremy Selan <jeremy...@...>
Version 0.5.8 (June 22 2010):
* Support for .3dl * Support for matrix ops * Code refactor (added Processors) to support gpu/cpu model * Much better error checking * Compilation support for python 2.5 * Compilation support for OSX
|
|
Re: [ocs-dev] OpenColorSpace.h feedback
Malcolm Humphreys <malcolmh...@...>
On 20/06/2010, at 10:36 PM, Jeremy Selan wrote:
On another note that im about 50% done with the GPU design, and thisCool, sounds good. The big distinction between transforms and ops are that transforms areWe have started to write some of the plugins we had before for 3delight, mantra, nuke, shake and houdini & mantra for applying the ASC-CDL. At the moment they all use the same code, I was hoping to replace this with an OCS::Op::CDL() op. This I guess changes the requirements for Ops a bit, but I would like to use the same color math across client apps for the simple cases. For cases like 3delight and mantra were you just want to call a single simple Op per sample, having access to the Op directly would also reduce the overhead of setting up ImageDesc() so that you can evaluate a simple op. What I left out of my last post was the suggestion that Ops should be plugins. I have a few cases like non standard transfer functions and support for calling libs like truelight or cinespace as an Op which I don't think belong in the OCS core. Cortex already has an Op for truelight which you might find interesting http://code.google.com/p/cortex-vfx/source/browse/trunk/src/IECoreTruelight/TruelightColorTransformOp.cpp I think having some form of extendibility at the Op level will be needed for OCS to be widely adopted. It will be hard for people to take on if they can't replicate the workflow (broken or not) they have right now. A family relates to bit-depthness, and though the concept is fullyThat feels like you could drop the extra color spaces and make that part of the Transform() or TransformGroup(). This would make a ColorSpace() define how it would be represented in/at different bit depths. colorspace(name='lgh') to_reference(bitdepth='16f') ... op chain ... to_reference(bitdepth='16ui') ... op chain ... to_reference(bitdepth='10ui') ... op chain ... ... The other option would be to make that part of the Lut1D and Lut3D Ops, ie reading different luts for different bit depths. But after thinking about it I feel the to_reference(bitdepth='16f') would be better as you most likely will need different color op chains in certain situations which would get you back into having color spaces for different bit depths. Roles (their concept) are super useful to have in production becauseI still feel this should be in OCS configuration of some kind with an small api for listing and selecting roles in the current context. I don't think a change in configuration like renaming or adding a role should require recompiling of the OCS core. Give me a kick if this feedback is too much like noise. .malcolm
|
|
Re: [ocs-dev] OpenColorSpace.h feedback
Jeremy Selan <jeremy...@...>
yah, these summaries are correct. go to the google group, and check
out the 'internal architecture overview' doc. It's still a huge work in progress but provides a bit more of an overview. I have to run in a few, gonna do a super-quick reply... On another note that im about 50% done with the GPU design, and this will change the class design a bit yet a again. (It introduces a processor class, and all the ApplyTransforms go away. You instead do a instead, and processors have fcns like renderCPU(Img), getGPUShaderText, etc. It's actually much cleaner. The big distinction between transforms and ops are that transforms are client-facing, and ops never escape the library. I could ditch GroupTransform in favor of a transformVec, but it seemed useful to have to avoid all the trouble with returning a vector (windows dll crap). A family relates to bit-depthness, and though the concept is fully fleshed out in our internal spi library im still grappling with how to de-imageworks-ify it. For example, we use the colorspace 'lg10' for 10 bit file io, but the luts used dont have enough precision for 16 bit use. So we also have lg16 for that case. Also, lgh (h standing for half float). These are all in the lg family. It's actually called prefix in the SPI codebase. It would be cool if the concept could go away, but I havent yet figure out how to efficiently make that happen. Roles (their concept) are super useful to have in production because shows often names their colorspaces differently. We found ourselves wanting 'constants' for a whole bunch of em repeatedly, so thats why they're in the library. SCENE_LINEAR being an obvious one, where its useful to want to sometimes reference it by its 'concept'. They are also integral to the display pipeline (code not yet used), where they correspond to certain defaults. (in the display pipeline, fstop expose offsets default to a multiplier in SCENE_LINEAR, and this is how it's driven). The roles (and their API) are just strings though, so facilities are free to use new ones at any time using the same storage mechanism. (At SPI we add extra ones specifying each output media colorspace: quicktime, avi, omf, etc). On Sun, Jun 20, 2010 at 5:53 AM, Malcolm Humphreys <malcolmh...@mac.com> wrote: Hi Jeremy and others,
|
|
OpenColorSpace.h feedback
Malcolm Humphreys <malcolmh...@...>
Hi Jeremy and others, After looking at OpenColorSpace.h a bit today I have some feedback. First I just want to make sure I'm getting the concepts correct. Let me know if these summaries on the core classes are correct? class Config; is a top level configuration object that can be serialised into a .ocs file. Will also define the reference space (most likely scene linear) class ColorSpace; is a definition of color space with an operation chain to get from this space to the top level reference space. class Transform; is the base class for color transform operations class GroupTransform; manages an ordered list of color transform operations class FileTransform; is the base class for look up table transforms ops (Lut1D and Lut3D) I got a bit confused between Ops, Transform and GroupTransform when looking through the code. I can see how they will work just the concepts feel a bit mixed to me. I keep wanting to call a GroupTransform a Transform (or OpList or OpChain) and a Transform an Op. eg, Config ('fabricated') `- ColorSpace ('spacejam') `- Transform (to_reference) `- [ Op::Lut1D (), Op::Gamma (), Op::Foo () ] I don't think FileTransform should be in here. I'll send another email about Ops if this feedback is going in the right direction as I don't want to create two much noise. Family Can you give a brief description of what a family is? I can see 'family' referenced here and there but not currently used. Roles From the description: "ColorSpace Roles are used so that plugins, in addition to this API can have abstract ways of asking for common colorspaces, without referring to them by hardcoded names." I can see the need for an abstract way to tag colorspaces so that client apps don't need to deal with production details like the same ocs color space being called something slightly different on two shows. But it feels wrong for that abstract list of roles to be then hardcoded into the header. I would prefer to have a site-wide .ocs file which defines the possible roles (this file could also define site-wide color space but it wouldn't have too). Then in the local/show/project .ocs you would be able to link one of these abstract role names to a color space in that file/context. I would also like to be able to define new roles just in that project .ocs as well. These show roles would only be used with tools within that show that were written to support them. The long term idea would be to roll them back into the site-wide role definition (if it made sense to do so) but have some ability to test the roll in the show context. I could see my self using roles also for things like dealing with fixed production devices ie ROLE_STILLS_CAMERA1 but I'm not sure if thats what you had in mind. .malcolm
|
|
Re: An OCS by any other name?
Jeremy Selan <jeremy...@...>
You've convinced me.
OpenColorIO is pretty damn good. ... and your summary is dead accurate as well. After looking at OCS it feels like it's aiming to achieve 3 main things:Let's ponder this for the weekend.
|
|
Re: [ocs-dev] Re: An OCS by any other name?
Malcolm Humphreys <malcolmh...@...>
Pending on how the can of worm goes.
toggle quoted messageShow quoted text
The main observation I had with the name OCS is kind of what people are saying here. I feel the name is wrong (with any project not just OCS) if your not using it in conversations with others, or if your spending large amounts of time explaining why it's not what it says on the tin. I would rather spend that energy (even if it is my hot air) in other areas like making the system more complete, usable and adoptable. I think OpenColorManagement maybe is setting the bar a little two high for the project. Unless we think it will be a complete end to end solution. I can also see the ICC will be not be jumping for joy either. ;) http://www.color.org "The purpose of the ICC is to promote the use and adoption of open, vendor-neutral, cross-platform color management systems." After looking at OCS it feels like it's aiming to achieve 3 main things: - a standard / protocol for describing colo(u)r transformation chains - caching / baking of these chains (various lut formats) - evaluation of these chains on the cpu / gpu If this is what the project is trying to achieve (which I think will be amazing) then I would vote for something more like OpenColorIO. Which not only aligns it self well with OIIO but for me it fits better with these 3 overall aims. Really I could deal with pretty much any name other than OpenColorSpace. .malcolm
On 19/06/2010, at 8:09 AM, Rod Bogart wrote:
I must admit, I've been calling it OpenColorSPIce.
|
|
Re: [ocs-dev] Re: An OCS by any other name?
Jeremy Selan <jeremy...@...>
Hah! :)
toggle quoted messageShow quoted text
On Fri, Jun 18, 2010 at 3:09 PM, Rod Bogart <bog...@gmail.com> wrote:
I must admit, I've been calling it OpenColorSPIce.
|
|
Re: [ocs-dev] Re: An OCS by any other name?
Rod Bogart <bog...@...>
I must admit, I've been calling it OpenColorSPIce.
RGB On Fri, Jun 18, 2010 at 3:04 PM, Steve LaVietes <steve.l...@gmail.com> wrote: If it's the OCS part that matters:
|
|
Re: [ocs-dev] Re: An OCS by any other name?
Steve LaVietes <steve.l...@...>
If it's the OCS part that matters:
toggle quoted messageShow quoted text
Open Color System? -stevel
On Fri, Jun 18, 2010 at 2:55 PM, Jeremy Selan <jeremy...@gmail.com> wrote:
Ope,
|
|
Re: An OCS by any other name?
Jeremy Selan <jeremy...@...>
Ope,
Turns out I may have opened a can of worms on our end. I didnt realize this yesterday, but we'd already gotten legal signoff on the "OCS" name, and changing it now is not gonna be simple. So keep thinking of ideas, but don't anyone get their hopes up about "Open Color Management" yet. :( -- Jeremy
|
|
Re: [ocs-dev] Re: An OCS by any other name?
Larry Gritz <l...@...>
I vote for "Open Color Management."
But I'd use it no matter what name you choose. On Jun 18, 2010, at 1:56 PM, Alex wrote: I'm with the other's that this effort isn't really about defining-- Larry Gritz l...@imageworks.com
|
|
Re: An OCS by any other name?
Alex <alexfo...@...>
I'm with the other's that this effort isn't really about defining
toggle quoted messageShow quoted text
color spaces or color encodings but rather offering an open set of libraries to manage color transformations. I believe the name should probably reflect that.
On Jun 18, 10:59 am, Rod Bogart <bog...@gmail.com> wrote:
I agree that the system is more about conversion between spaces. OCC?
|
|
Re: [ocs-dev] An OCS by any other name?
Rod Bogart <bog...@...>
I agree that the system is more about conversion between spaces. OCC?
RGB PS - nice try sneaking the "u" into color, Bruno... On Fri, Jun 18, 2010 at 6:59 AM, Bruno Nicoletti <bruno.j....@googlemail.com> wrote: How about "Open Colour Management"? Seeing as it is more about
|
|
Re: [ocs-dev] An OCS by any other name?
Bruno Nicoletti <bruno.j....@...>
How about "Open Colour Management"? Seeing as it is more about
toggle quoted messageShow quoted text
coordinating the whole mess of colour spaces and displays and so on, rather than being a colour space per se. b
On 18 June 2010 08:52, Jeremy Selan <jeremy...@gmail.com> wrote:
I wasn't originally in love with the name Open Color Space, but I have --
Bruno Nicoletti
|
|
An OCS by any other name?
Jeremy Selan <jeremy...@...>
I wasn't originally in love with the name Open Color Space, but I have
to admit it's grown on me. What are other people's feeling on "OCS"? Previously, David (Gordon) has suggested that the use of "Open" is very 90s/cliche, and recommended dropping it. It's hard to disagree, plain "ColorSpace" is not really googleable. Malcolm has also suggested that a name such as "Open Color Space" is perhaps misleading... Malcolm: "I was telling one of the digital sups about it at DrD today. His first response was asking which monitor probes it will support, which I then had to go through and explain what OCS is trying to achieve and what that would mean for productions at DrD (ie for DrD this doesn't replace truelight or cinespace, just compliments them)." Malcolm's suggested a few additions (with my added notes) - OpenColorWorkSpace (Sony's DI facility is called ColorWorks, not sure if this is good or bad) - OpenColorIO - OpenColorFlow (same name as kodak product) - OpenColorWorkFlow - OpenColorTransfer - OpenColorBase (makes me think it's related to baselight) None of these particularly jump out at me, but I'm open to all ideas. What are peoples thoughts? There's time yet to rethink OCS's name, but the window is closing...
|
|
OCS now on github
Jeremy Selan <jeremy...@...>
We've setup a private repository for developers on github! Please
email your github account details you'd like access. For everyone else, we will continue to post weekly code drops.
|
|
Re: Got Luts?
Malcolm Humphreys <malcolmh...@...>
Oh I have never used this as it got released by RSR after we
implemented the csp format at RSP. Not sure if it's helpful as I haven't spent anytime looking into it so I wouldn't expect it to work out of the box. https://cinespacelutlib.svn.sourceforge.net/svnroot/cinespacelutlib/trunk/ .malcolm On Jun 15, 10:13 pm, Malcolm Humphreys <malcolmh...@mac.com> wrote: Mostly using cinespace .csp, houdini .lut and .icc profiles for
|
|
Re: Got Luts?
Malcolm Humphreys <malcolmh...@...>
Mostly using cinespace .csp, houdini .lut and .icc profiles for
toggle quoted messageShow quoted text
photoshop. The main lut format requirements for me is supporting some form of 1D pre lut and a 3D cube. I have uploaded the csp lut spec here as the RSR link out there never seemed to work. http://groups.google.com.au/group/ocs-dev/web/cineSpace_LUT_format.zip There is also an example 1D3D houdini lut if this helps http://groups.google.com.au/group/ocs-dev/web/lin_gamma22_1D3D.lut .malcolm
On Jun 9, 7:16 am, Jeremy Selan <jeremy...@gmail.com> wrote:
Good feedback. How about this:
|
|