Review: added new yaml-cpp with YAML::Newline feature


Jeremy Selan <jeremy...@...>
 

Thanks,

LGTM

On Mon, Oct 25, 2010 at 3:05 PM, Malcolm Humphreys
<malcolmh...@...> wrote:
On 26/10/2010, at 5:14 AM, Jeremy Selan wrote:

Is there a reason to not remove yaml-cpp-0.2.5* from ext?
No reason was just waiting to get the tick of approval, this is now removed.
http://github.com/malcolmhumphreys/OpenColorIO/commit/26aa9bfc1baa74796b355de0b2ec476960b1b481

.malcolm


Other than that, looks good to me.

-- Jeremy

On Mon, Oct 25, 2010 at 5:22 AM, Malcolm Humphreys
<malcolmh...@...> wrote:
- added yaml-cpp r443 which contains the new YAML::Newline emitter manipulator
http://stackoverflow.com/questions/3982901/how-to-emit-a-blank-line-using-yaml-cpp
- added some 'out << YAML::Newline' to tryout this feature

http://github.com/malcolmhumphreys/OpenColorIO/commit/0de8ccb6842b223f942789f1ae68d768dab9de29

.malcolm


Malcolm Humphreys <malcolmh...@...>
 

On 26/10/2010, at 5:14 AM, Jeremy Selan wrote:

Is there a reason to not remove yaml-cpp-0.2.5* from ext?
No reason was just waiting to get the tick of approval, this is now removed.
http://github.com/malcolmhumphreys/OpenColorIO/commit/26aa9bfc1baa74796b355de0b2ec476960b1b481

.malcolm


Other than that, looks good to me.

-- Jeremy

On Mon, Oct 25, 2010 at 5:22 AM, Malcolm Humphreys
<malcolmh...@...> wrote:
- added yaml-cpp r443 which contains the new YAML::Newline emitter manipulator
http://stackoverflow.com/questions/3982901/how-to-emit-a-blank-line-using-yaml-cpp
- added some 'out << YAML::Newline' to tryout this feature

http://github.com/malcolmhumphreys/OpenColorIO/commit/0de8ccb6842b223f942789f1ae68d768dab9de29

.malcolm


Jeremy Selan <jeremy...@...>
 

Is there a reason to not remove yaml-cpp-0.2.5* from ext?

Other than that, looks good to me.

-- Jeremy

On Mon, Oct 25, 2010 at 5:22 AM, Malcolm Humphreys
<malcolmh...@...> wrote:
- added yaml-cpp r443 which contains the new YAML::Newline emitter manipulator
http://stackoverflow.com/questions/3982901/how-to-emit-a-blank-line-using-yaml-cpp
- added some 'out << YAML::Newline' to tryout this feature

http://github.com/malcolmhumphreys/OpenColorIO/commit/0de8ccb6842b223f942789f1ae68d768dab9de29

.malcolm