1. Ocio-Dev
  2. Topics

Review: Processor.getGpuShaderTextCacheID()

Malcolm Humphreys <malcolmh...@...>
 

LGTM

Begin forwarded message:

From: Jeremy Selan <jeremy...@...>
Date: 22 January 2011 1:21:46 PM AEDT
To: OpenColorIO Developers <ocio...@...>
Subject: [ocio-dev] Review: Processor.getGpuShaderTextCacheID()
Reply-To: ocio...@...

Commit:
http://github.com/jeremyselan/OpenColorIO/commit/7ffb711edea3b4b3c4aa0ad046c15de8f70b936e

I added a call to get the cacheID for the shadertext on the processor
object.  Note that querying the shadertext is an inexpensive
operation, so there arent as many benefits to deferred shadertext
calls (compared to, say, the 3dlut generation).  However, for those
writing display apps it's convenient to have.

-- Jeremy
Jeremy Selan <jeremy...@...>
 

Commit:
http://github.com/jeremyselan/OpenColorIO/commit/7ffb711edea3b4b3c4aa0ad046c15de8f70b936e

I added a call to get the cacheID for the shadertext on the processor
object. Note that querying the shadertext is an inexpensive
operation, so there arent as many benefits to deferred shadertext
calls (compared to, say, the 3dlut generation). However, for those
writing display apps it's convenient to have.

-- Jeremy

1 - 2 of 2