OSX 10.9 compile expectations?


Rod Bogart <bog...@...>
 

Agreed.  I inserted unistd.h above the #elif, and it compiles fine on 10.9.

RGB

On Feb 9, 2014, at 5:23 PM, Colin Doncaster <colin.d...@...> wrote:

It looks like PathUtils.cpp needs unistd.h included.  

Looking at the source there’s:

#if defined(__APPLE__) && !defined(__IPHONE__)
#include <crt_externs.h> // _NSGetEnviron()
#elif !defined(WINDOWS)
#include <unistd.h>
extern char **environ;
#endif

so I’m not too sure how one would want to rework those conditionals. 

Mavericks headers are closer to Linux now, there’s a few projects I’ve rebuilt now that require the __APPLE__ defines to compile. 

Cheers

On Feb 8, 2014, at 6:14 PM, Rod Bogart <bog...@...> wrote:

Do we expect 10.9 to properly compile the git master version of OpenColorIO?

Steps to reproduce:
   “Clone in Desktop” to download software
   Cmake (with defaults) to populate build dir
   cd build
   make
[ 38%] Building CXX object src/core/CMakeFiles/OpenColorIO.dir/ParseUtils.cpp.o
[ 39%] Building CXX object src/core/CMakeFiles/OpenColorIO.dir/PathUtils.cpp.o
/Users/ocio/OpenColorIO/src/core/PathUtils.cpp:154:15: error: 
      no member named 'getcwd' in the global namespace
            ::getcwd(path, MAXPATHLEN);
            ~~^
1 error generated.

Will continue to debug, but thought I’d ask if someone has been here first…

RGB

--
You received this message because you are subscribed to the Google Groups "OpenColorIO Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ocio-dev+u...@....
For more options, visit https://groups.google.com/groups/opt_out.


--
You received this message because you are subscribed to the Google Groups "OpenColorIO Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ocio-dev+u...@....
For more options, visit https://groups.google.com/groups/opt_out.


Colin Doncaster <colin.d...@...>
 

It looks like PathUtils.cpp needs unistd.h included.  

Looking at the source there’s:

#if defined(__APPLE__) && !defined(__IPHONE__)
#include <crt_externs.h> // _NSGetEnviron()
#elif !defined(WINDOWS)
#include <unistd.h>
extern char **environ;
#endif

so I’m not too sure how one would want to rework those conditionals. 

Mavericks headers are closer to Linux now, there’s a few projects I’ve rebuilt now that require the __APPLE__ defines to compile. 

Cheers

On Feb 8, 2014, at 6:14 PM, Rod Bogart <bog...@...> wrote:

Do we expect 10.9 to properly compile the git master version of OpenColorIO?

Steps to reproduce:
   “Clone in Desktop” to download software
   Cmake (with defaults) to populate build dir
   cd build
   make
[ 38%] Building CXX object src/core/CMakeFiles/OpenColorIO.dir/ParseUtils.cpp.o
[ 39%] Building CXX object src/core/CMakeFiles/OpenColorIO.dir/PathUtils.cpp.o
/Users/ocio/OpenColorIO/src/core/PathUtils.cpp:154:15: error: 
      no member named 'getcwd' in the global namespace
            ::getcwd(path, MAXPATHLEN);
            ~~^
1 error generated.

Will continue to debug, but thought I’d ask if someone has been here first…

RGB

--
You received this message because you are subscribed to the Google Groups "OpenColorIO Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ocio-dev+u...@....
For more options, visit https://groups.google.com/groups/opt_out.


Rod Bogart <bog...@...>
 

Thanks.

Yes, it is the master branch. I have not yet spent time on the fix, but I believe you are correct; it should just be headers.

RGB

On Feb 8, 2014, at 4:46 PM, Jeremy Selan <jeremy...@...> wrote:

I haven't yet updated by OSX dev machine to 10.9 yet, so unfortunately
I can't test this at home. (Sounds like a good weekend project
though).

When I browse the open issues list,
https://github.com/imageworks/OpenColorIO/issues?state=open

there is a topic for compiliation problems on 10.9,
https://github.com/imageworks/OpenColorIO/issues/340

but it doesn't mention getcwd.

I'm not sure how you did the git checkout, but can you confirm if
you're on master or instead the tagged 1.0.9 release? The sha for
master is 63c6bde2, the sha for 1.0.9 is 2b12063e22

We'd very much welcome a patch if you'd like to take a stab at getting
this working. (probably a simple header fix?) :)

-- Jeremy

On Sat, Feb 8, 2014 at 3:14 PM, Rod Bogart <bog...@...> wrote:
Do we expect 10.9 to properly compile the git master version of OpenColorIO?

Steps to reproduce:
"Clone in Desktop" to download software
Cmake (with defaults) to populate build dir
cd build
make
[ 38%] Building CXX object
src/core/CMakeFiles/OpenColorIO.dir/ParseUtils.cpp.o
[ 39%] Building CXX object
src/core/CMakeFiles/OpenColorIO.dir/PathUtils.cpp.o
/Users/ocio/OpenColorIO/src/core/PathUtils.cpp:154:15: error:
no member named 'getcwd' in the global namespace
::getcwd(path, MAXPATHLEN);
~~^
1 error generated.

Will continue to debug, but thought I'd ask if someone has been here first...

RGB

--
You received this message because you are subscribed to the Google Groups
"OpenColorIO Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to ocio-dev+u...@....
For more options, visit https://groups.google.com/groups/opt_out.
--
You received this message because you are subscribed to the Google Groups "OpenColorIO Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ocio-dev+u...@....
For more options, visit https://groups.google.com/groups/opt_out.


Jeremy Selan <jeremy...@...>
 

I haven't yet updated by OSX dev machine to 10.9 yet, so unfortunately
I can't test this at home. (Sounds like a good weekend project
though).

When I browse the open issues list,
https://github.com/imageworks/OpenColorIO/issues?state=open

there is a topic for compiliation problems on 10.9,
https://github.com/imageworks/OpenColorIO/issues/340

but it doesn't mention getcwd.

I'm not sure how you did the git checkout, but can you confirm if
you're on master or instead the tagged 1.0.9 release? The sha for
master is 63c6bde2, the sha for 1.0.9 is 2b12063e22

We'd very much welcome a patch if you'd like to take a stab at getting
this working. (probably a simple header fix?) :)

-- Jeremy

On Sat, Feb 8, 2014 at 3:14 PM, Rod Bogart <bog...@...> wrote:
Do we expect 10.9 to properly compile the git master version of OpenColorIO?

Steps to reproduce:
"Clone in Desktop" to download software
Cmake (with defaults) to populate build dir
cd build
make
[ 38%] Building CXX object
src/core/CMakeFiles/OpenColorIO.dir/ParseUtils.cpp.o
[ 39%] Building CXX object
src/core/CMakeFiles/OpenColorIO.dir/PathUtils.cpp.o
/Users/ocio/OpenColorIO/src/core/PathUtils.cpp:154:15: error:
no member named 'getcwd' in the global namespace
::getcwd(path, MAXPATHLEN);
~~^
1 error generated.

Will continue to debug, but thought I'd ask if someone has been here first...

RGB

--
You received this message because you are subscribed to the Google Groups
"OpenColorIO Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to ocio-dev+u...@....
For more options, visit https://groups.google.com/groups/opt_out.


Rod Bogart <bog...@...>
 

Do we expect 10.9 to properly compile the git master version of OpenColorIO?

Steps to reproduce:
   “Clone in Desktop” to download software
   Cmake (with defaults) to populate build dir
   cd build
   make
[ 38%] Building CXX object src/core/CMakeFiles/OpenColorIO.dir/ParseUtils.cpp.o
[ 39%] Building CXX object src/core/CMakeFiles/OpenColorIO.dir/PathUtils.cpp.o
/Users/ocio/OpenColorIO/src/core/PathUtils.cpp:154:15: error: 
      no member named 'getcwd' in the global namespace
            ::getcwd(path, MAXPATHLEN);
            ~~^
1 error generated.

Will continue to debug, but thought I’d ask if someone has been here first…

RGB