After Effects OCIO Plugin code age


Sean Cooper <se...@...>
 

Oh ok, good to know, I had assumed they were independent. This should be fine then, thanks!

On Fri, Oct 27, 2017 at 12:12 PM, Brendan Bolles <bre...@...> wrote:
On Thursday, October 26, 2017 at 6:44:29 PM UTC-7, Sean Cooper wrote:
I'll have to look at this shortly. Before I go too far, do you think you could separate it into two pull requests? One for the AE plugin and another for the PS plugin? It will allow for separate discussion on each.


I could pull them apart if absolutely necessary, but since they sort of depend on each other it's easier said than done. For example, I made some changes to the AE files so that the Photoshop plug-in could use it too.

But I don't think there should be a need for too much discussion. There are no changes to the main OCIO codebase and I'm the only ones working on these. They don't even get built by CMake because there are a few Adobe SDK build quirks that we haven't been able to accommodate with CMake.

--
You received this message because you are subscribed to the Google Groups "OpenColorIO Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ocio-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Brendan Bolles <bre...@...>
 

On Thursday, October 26, 2017 at 6:44:29 PM UTC-7, Sean Cooper wrote:
I'll have to look at this shortly. Before I go too far, do you think you could separate it into two pull requests? One for the AE plugin and another for the PS plugin? It will allow for separate discussion on each.


I could pull them apart if absolutely necessary, but since they sort of depend on each other it's easier said than done. For example, I made some changes to the AE files so that the Photoshop plug-in could use it too.

But I don't think there should be a need for too much discussion. There are no changes to the main OCIO codebase and I'm the only ones working on these. They don't even get built by CMake because there are a few Adobe SDK build quirks that we haven't been able to accommodate with CMake.


Sean Cooper <se...@...>
 

Wonderful, thanks for the effort Brendan!

I'll have to look at this shortly. Before I go too far, do you think you could separate it into two pull requests? One for the AE plugin and another for the PS plugin? It will allow for separate discussion on each.

Virus-free. www.avast.com

On Thu, Oct 26, 2017 at 6:10 PM, Brendan Bolles <bre...@...> wrote:
On Monday, August 14, 2017 at 2:08:10 PM UTC-7, Deke Kincaid wrote:
Now that we have Sean actively accepting changes you can probably update with your newer pull requests for AE and Photoshop.


OK, I have a new pull request that should have everything up to date.



 

--
You received this message because you are subscribed to the Google Groups "OpenColorIO Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ocio-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Brendan Bolles <bre...@...>
 

On Monday, August 14, 2017 at 2:08:10 PM UTC-7, Deke Kincaid wrote:
Now that we have Sean actively accepting changes you can probably update with your newer pull requests for AE and Photoshop.


OK, I have a new pull request that should have everything up to date.

https://github.com/imageworks/OpenColorIO/pull/476


 


Brendan Bolles <bre...@...>
 

On Monday, August 14, 2017 at 5:31:29 PM UTC-7, Sean Cooper wrote:
I'll happily look at anything pushed our way.

Curious, would you be able to give a quick rundown of the PS plugin functionality / implementation?


What do you want to know? As Deke pointed out, I have a blog post where you can download it. Code is on GitHub.

It was made for use in a studio, so it's been tested. It's designed similarly to the After Effects plug-in.

This plug-in is a filter, so it can be applied to a layer to perform color space transformations. The big bummer about Photoshop is that a plug-in can't use used to modify the view continuously. It can export LUTs which can be used as a view LUT to the degree that Photoshop can do that.


Sean Cooper <se...@...>
 

I'll happily look at anything pushed our way.

Curious, would you be able to give a quick rundown of the PS plugin functionality / implementation?

On Mon, Aug 14, 2017 at 2:07 PM, Deke Kincaid <dekek...@...> wrote:
Yea, that's what I figured.  You have a pull request never fulfilled from 2016 so why bother with future ones. 

Now that we have Sean actively accepting changes you can probably update with your newer pull requests for AE and Photoshop.

On Mon, Aug 14, 2017 at 12:36 PM, Brendan Bolles <bre...@...> wrote:
On Monday, August 14, 2017 at 11:34:50 AM UTC-7, Sean Cooper wrote:
The latter mostly, most VFX studios that maintain the project don't actively use After Effects so it's not usually on our minds. So its also a question of, if its broken who cares enough to do something about it?


Au contraire! I've actually updated it as recently as January. See my ae_plugin_update branch:


I also have a Photoshop plug-in now in my "photoshop" branch.

I haven't done any pull requests lately because OCIO has been in hibernation until recently.

--
You received this message because you are subscribed to the Google Groups "OpenColorIO Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ocio-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "OpenColorIO Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ocio-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Deke Kincaid <dekek...@...>
 

Yea, that's what I figured.  You have a pull request never fulfilled from 2016 so why bother with future ones. 

Now that we have Sean actively accepting changes you can probably update with your newer pull requests for AE and Photoshop.

On Mon, Aug 14, 2017 at 12:36 PM, Brendan Bolles <bre...@...> wrote:
On Monday, August 14, 2017 at 11:34:50 AM UTC-7, Sean Cooper wrote:
The latter mostly, most VFX studios that maintain the project don't actively use After Effects so it's not usually on our minds. So its also a question of, if its broken who cares enough to do something about it?


Au contraire! I've actually updated it as recently as January. See my ae_plugin_update branch:


I also have a Photoshop plug-in now in my "photoshop" branch.

I haven't done any pull requests lately because OCIO has been in hibernation until recently.

--
You received this message because you are subscribed to the Google Groups "OpenColorIO Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ocio-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Brendan Bolles <bre...@...>
 

On Monday, August 14, 2017 at 11:34:50 AM UTC-7, Sean Cooper wrote:
The latter mostly, most VFX studios that maintain the project don't actively use After Effects so it's not usually on our minds. So its also a question of, if its broken who cares enough to do something about it?


Au contraire! I've actually updated it as recently as January. See my ae_plugin_update branch:

https://github.com/fnordware/OpenColorIO/tree/ae_plugin_update

I also have a Photoshop plug-in now in my "photoshop" branch.

I haven't done any pull requests lately because OCIO has been in hibernation until recently.


Deke Kincaid <dekek...@...>
 

He also has a nice one for Photoshop

http://fnordware.blogspot.com/2017/02/opencolorio-for-photoshop.html

He hasn't made a pull request yet but you can see the source for it below
https://github.com/fnordware/OpenColorIO/tree/photoshop/src/photoshop

On Mon, Aug 14, 2017 at 12:16 PM, Sean Cooper <se...@...> wrote:
Ah great, that's good to know. I'd never get my hand on AE anytime soon so I think its fair to trust your opinion on the situation.

@cam Maybe you could be an additional tester on #405 and we can pull it in if all is in the clear

On Mon, Aug 14, 2017 at 12:12 PM, Deke Kincaid <dekek...@...> wrote:
I've used the plugin a few times.  Minus a few minor issues it works fairly well.  There is an updated pull request from 2016 though which we should probably accept.  I've used this version and not the current 5 year old version in the repo.

https://github.com/imageworks/OpenColorIO/pull/405

On Mon, Aug 14, 2017 at 11:34 AM, Sean Cooper <se...@...> wrote:
The latter mostly, most VFX studios that maintain the project don't actively use After Effects so it's not usually on our minds. So its also a question of, if its broken who cares enough to do something about it?

With OCIO going through a dry spell most effort has been focused on the core library, but it would be nice to see how the plugins hold up to modern inspection.

On Sun, Aug 13, 2017 at 6:42 PM, Cam Wright <cwr...@...> wrote:
Hi there,

I'm taking a passing glance at colour management in After Effects and
I found the OCIO plugin maintained as part of the OCIO Github project.
https://github.com/imageworks/OpenColorIO/tree/master/src/aftereffects

Appears like the code is a number of years old now though.

Before even considering implementing in our pipeline, I'd like to find
out whether the code age is a matter of "it's out of date because it
doesn't see use in the real world" or a "don't fix what isn't broken"
kind of deal.

I suspect the latter is true, but figure a quick recce not a bad idea!

Thanks.

-C

Cam Wright - Systems and Technical Resource Administrator
CUTTINGEDGE /
90 Victoria St, West End, Brisbane, QLD, 4101
T + 61 7 3013 6200    M 0420 827 007
E cwr...@... | W www.cuttingedge.com.au

/SYD /BNE /TYO

--


This email is confidential and solely for the use of the intended recipient.
  If you have received this email in error please notify the author and
delete it immediately. This email is not to be distributed without the
author's written consent. Unauthorised forwarding, printing, copying or use
is strictly prohibited and may be a breach of copyright. Any views
expressed in this email are those of the individual sender unless
specifically stated to be the views of Cutting Edge Post Pty Ltd (Cutting
Edge). Although this email has been sent in the belief that it is
virus-free, it is the responsibility of the recipient to ensure that it is
virus free. No responsibility is accepted by Cutting Edge for any loss or
damage arising in any way from receipt or use of this email.  This email may
contain legally privileged information and privilege is not waived if you
have received this email in error.

--
You received this message because you are subscribed to the Google Groups "OpenColorIO Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ocio-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "OpenColorIO Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ocio-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "OpenColorIO Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ocio-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "OpenColorIO Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ocio-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Sean Cooper <se...@...>
 

Ah great, that's good to know. I'd never get my hand on AE anytime soon so I think its fair to trust your opinion on the situation.

@cam Maybe you could be an additional tester on #405 and we can pull it in if all is in the clear

On Mon, Aug 14, 2017 at 12:12 PM, Deke Kincaid <dekek...@...> wrote:
I've used the plugin a few times.  Minus a few minor issues it works fairly well.  There is an updated pull request from 2016 though which we should probably accept.  I've used this version and not the current 5 year old version in the repo.

https://github.com/imageworks/OpenColorIO/pull/405

On Mon, Aug 14, 2017 at 11:34 AM, Sean Cooper <se...@...> wrote:
The latter mostly, most VFX studios that maintain the project don't actively use After Effects so it's not usually on our minds. So its also a question of, if its broken who cares enough to do something about it?

With OCIO going through a dry spell most effort has been focused on the core library, but it would be nice to see how the plugins hold up to modern inspection.

On Sun, Aug 13, 2017 at 6:42 PM, Cam Wright <cwr...@...> wrote:
Hi there,

I'm taking a passing glance at colour management in After Effects and
I found the OCIO plugin maintained as part of the OCIO Github project.
https://github.com/imageworks/OpenColorIO/tree/master/src/aftereffects

Appears like the code is a number of years old now though.

Before even considering implementing in our pipeline, I'd like to find
out whether the code age is a matter of "it's out of date because it
doesn't see use in the real world" or a "don't fix what isn't broken"
kind of deal.

I suspect the latter is true, but figure a quick recce not a bad idea!

Thanks.

-C

Cam Wright - Systems and Technical Resource Administrator
CUTTINGEDGE /
90 Victoria St, West End, Brisbane, QLD, 4101
T + 61 7 3013 6200    M 0420 827 007
E cwr...@... | W www.cuttingedge.com.au

/SYD /BNE /TYO

--


This email is confidential and solely for the use of the intended recipient.
  If you have received this email in error please notify the author and
delete it immediately. This email is not to be distributed without the
author's written consent. Unauthorised forwarding, printing, copying or use
is strictly prohibited and may be a breach of copyright. Any views
expressed in this email are those of the individual sender unless
specifically stated to be the views of Cutting Edge Post Pty Ltd (Cutting
Edge). Although this email has been sent in the belief that it is
virus-free, it is the responsibility of the recipient to ensure that it is
virus free. No responsibility is accepted by Cutting Edge for any loss or
damage arising in any way from receipt or use of this email.  This email may
contain legally privileged information and privilege is not waived if you
have received this email in error.

--
You received this message because you are subscribed to the Google Groups "OpenColorIO Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ocio-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "OpenColorIO Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ocio-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "OpenColorIO Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ocio-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Deke Kincaid <dekek...@...>
 

I've used the plugin a few times.  Minus a few minor issues it works fairly well.  There is an updated pull request from 2016 though which we should probably accept.  I've used this version and not the current 5 year old version in the repo.

https://github.com/imageworks/OpenColorIO/pull/405

On Mon, Aug 14, 2017 at 11:34 AM, Sean Cooper <se...@...> wrote:
The latter mostly, most VFX studios that maintain the project don't actively use After Effects so it's not usually on our minds. So its also a question of, if its broken who cares enough to do something about it?

With OCIO going through a dry spell most effort has been focused on the core library, but it would be nice to see how the plugins hold up to modern inspection.

On Sun, Aug 13, 2017 at 6:42 PM, Cam Wright <cwr...@...> wrote:
Hi there,

I'm taking a passing glance at colour management in After Effects and
I found the OCIO plugin maintained as part of the OCIO Github project.
https://github.com/imageworks/OpenColorIO/tree/master/src/aftereffects

Appears like the code is a number of years old now though.

Before even considering implementing in our pipeline, I'd like to find
out whether the code age is a matter of "it's out of date because it
doesn't see use in the real world" or a "don't fix what isn't broken"
kind of deal.

I suspect the latter is true, but figure a quick recce not a bad idea!

Thanks.

-C

Cam Wright - Systems and Technical Resource Administrator
CUTTINGEDGE /
90 Victoria St, West End, Brisbane, QLD, 4101
T + 61 7 3013 6200    M 0420 827 007
E cwr...@... | W www.cuttingedge.com.au

/SYD /BNE /TYO

--


This email is confidential and solely for the use of the intended recipient.
  If you have received this email in error please notify the author and
delete it immediately. This email is not to be distributed without the
author's written consent. Unauthorised forwarding, printing, copying or use
is strictly prohibited and may be a breach of copyright. Any views
expressed in this email are those of the individual sender unless
specifically stated to be the views of Cutting Edge Post Pty Ltd (Cutting
Edge). Although this email has been sent in the belief that it is
virus-free, it is the responsibility of the recipient to ensure that it is
virus free. No responsibility is accepted by Cutting Edge for any loss or
damage arising in any way from receipt or use of this email.  This email may
contain legally privileged information and privilege is not waived if you
have received this email in error.

--
You received this message because you are subscribed to the Google Groups "OpenColorIO Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ocio-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "OpenColorIO Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ocio-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Sean Cooper <se...@...>
 

The latter mostly, most VFX studios that maintain the project don't actively use After Effects so it's not usually on our minds. So its also a question of, if its broken who cares enough to do something about it?

With OCIO going through a dry spell most effort has been focused on the core library, but it would be nice to see how the plugins hold up to modern inspection.

On Sun, Aug 13, 2017 at 6:42 PM, Cam Wright <cwr...@...> wrote:
Hi there,

I'm taking a passing glance at colour management in After Effects and
I found the OCIO plugin maintained as part of the OCIO Github project.
https://github.com/imageworks/OpenColorIO/tree/master/src/aftereffects

Appears like the code is a number of years old now though.

Before even considering implementing in our pipeline, I'd like to find
out whether the code age is a matter of "it's out of date because it
doesn't see use in the real world" or a "don't fix what isn't broken"
kind of deal.

I suspect the latter is true, but figure a quick recce not a bad idea!

Thanks.

-C

Cam Wright - Systems and Technical Resource Administrator
CUTTINGEDGE /
90 Victoria St, West End, Brisbane, QLD, 4101
T + 61 7 3013 6200    M 0420 827 007
E cwr...@... | W www.cuttingedge.com.au

/SYD /BNE /TYO

--


This email is confidential and solely for the use of the intended recipient.
  If you have received this email in error please notify the author and
delete it immediately. This email is not to be distributed without the
author's written consent. Unauthorised forwarding, printing, copying or use
is strictly prohibited and may be a breach of copyright. Any views
expressed in this email are those of the individual sender unless
specifically stated to be the views of Cutting Edge Post Pty Ltd (Cutting
Edge). Although this email has been sent in the belief that it is
virus-free, it is the responsibility of the recipient to ensure that it is
virus free. No responsibility is accepted by Cutting Edge for any loss or
damage arising in any way from receipt or use of this email.  This email may
contain legally privileged information and privilege is not waived if you
have received this email in error.

--
You received this message because you are subscribed to the Google Groups "OpenColorIO Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ocio-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.