Date
1 - 4 of 4
.ICC not requiring --copyright info
|
Andrew Britton <andrew.d...@...>
I've been building various .ICC files and not once have I set the --copyright flag and not once has an error been thrown. After looking in the main.cpp for ociobakelut I see that it should be throwing an error, but for some reason it isn't. Is it being set by default in the Argparse class?
Andrew |
|
|
|
dbr/Ben <dbr....@...>
Your last sentence is right, it does not error because there is a default value for 'copyright':
toggle quoted message
Show quoted text
std::string copyright = "OpenColorIO (Sony Imageworks)"; Whereas others like description are just: std::string description; I think it would only error if you did: ociobakelut --description "" (i.e an empty string) On 06/12/2012, at 7:55 AM, Andrew Britton wrote:
I've been building various .ICC files and not once have I set the --copyright flag and not once has an error been thrown. After looking in the main.cpp for ociobakelut I see that it should be throwing an error, but for some reason it isn't. Is it being set by default in the Argparse class? |
|
|
|
Andrew Britton <andrew.d...@...>
Should I pull out the code path in main.cpp that returns an error if --copyright is not set?
toggle quoted message
Show quoted text
It seems vestigial at this point. On Dec 5, 2012, at 9:45 PM, dbr/Ben <dbr....@...> wrote:
Your last sentence is right, it does not error because there is a default value for 'copyright': |
|
|
|
Jeremy Selan <jeremy...@...>
yup, please clean up that error code too, thanks!
We should also try to take advantage of github for code-checkin specific comments and discussions. I dont want to overwhelm people with minutia of code on the email list... :) -- Jeremy On Thu, Dec 6, 2012 at 8:49 AM, Andrew Britton <andrew.d...@...> wrote: Should I pull out the code path in main.cpp that returns an error if --copyright is not set? |
|
|