Review: Exposed gamma control on Nuke OCIODisplay node


Jeremy Selan <jeremy...@...>
 

Issue:
http://github.com/imageworks/OpenColorIO/issues#issue/45

Commit:
http://github.com/jeremyselan/OpenColorIO/commit/c206c4fe65d415b5c87c09acde3e05013dc0ab9f

I've exposed a gamma control for the Nuke OCIODisplay node. The gamma
control, like the origin one in nuke's monitor, is post-display
transform.

-- Jeremy


Malcolm Humphreys <malcolmh...@...>
 

LGTM

I would be tempted to name the knob 'display gamma'.

.malcolm

On 11/01/2011, at 12:43 PM, Jeremy Selan wrote:

Issue:
http://github.com/imageworks/OpenColorIO/issues#issue/45

Commit:
http://github.com/jeremyselan/OpenColorIO/commit/c206c4fe65d415b5c87c09acde3e05013dc0ab9f

I've exposed a gamma control for the Nuke OCIODisplay node. The gamma
control, like the origin one in nuke's monitor, is post-display
transform.

-- Jeremy


Jeremy Selan <jeremy...@...>
 

UI Label or underlying knob name?

On Mon, Jan 10, 2011 at 5:48 PM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:
LGTM

I would be tempted to name the knob 'display gamma'.

.malcolm

On 11/01/2011, at 12:43 PM, Jeremy Selan wrote:

Issue:
http://github.com/imageworks/OpenColorIO/issues#issue/45

Commit:
http://github.com/jeremyselan/OpenColorIO/commit/c206c4fe65d415b5c87c09acde3e05013dc0ab9f

I've exposed a gamma control for the Nuke OCIODisplay node.  The gamma
control, like the origin one in nuke's monitor, is post-display
transform.

-- Jeremy


Malcolm Humphreys <malcolmh...@...>
 

On 11/01/2011, at 12:49 PM, Jeremy Selan wrote:
UI Label or underlying knob name?
I would do both just for consistency.


On Mon, Jan 10, 2011 at 5:48 PM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:
LGTM

I would be tempted to name the knob 'display gamma'.

.malcolm

On 11/01/2011, at 12:43 PM, Jeremy Selan wrote:

Issue:
http://github.com/imageworks/OpenColorIO/issues#issue/45

Commit:
http://github.com/jeremyselan/OpenColorIO/commit/c206c4fe65d415b5c87c09acde3e05013dc0ab9f

I've exposed a gamma control for the Nuke OCIODisplay node. The gamma
control, like the origin one in nuke's monitor, is post-display
transform.

-- Jeremy


Jeremy Selan <jeremy...@...>
 

Spaces in knob names have always worried me. How about an underscore
in the knob name?

On Mon, Jan 10, 2011 at 5:51 PM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:
On 11/01/2011, at 12:49 PM, Jeremy Selan wrote:
UI Label or underlying knob name?
I would do both just for consistency.


On Mon, Jan 10, 2011 at 5:48 PM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:
LGTM

I would be tempted to name the knob 'display gamma'.

.malcolm

On 11/01/2011, at 12:43 PM, Jeremy Selan wrote:

Issue:
http://github.com/imageworks/OpenColorIO/issues#issue/45

Commit:
http://github.com/jeremyselan/OpenColorIO/commit/c206c4fe65d415b5c87c09acde3e05013dc0ab9f

I've exposed a gamma control for the Nuke OCIODisplay node.  The gamma
control, like the origin one in nuke's monitor, is post-display
transform.

-- Jeremy


Malcolm Humphreys <malcolmh...@...>
 

On 11/01/2011, at 12:54 PM, Jeremy Selan wrote:

Spaces in knob names have always worried me. How about an underscore
in the knob name?
perfect


On Mon, Jan 10, 2011 at 5:51 PM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:
On 11/01/2011, at 12:49 PM, Jeremy Selan wrote:
UI Label or underlying knob name?
I would do both just for consistency.


On Mon, Jan 10, 2011 at 5:48 PM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:
LGTM

I would be tempted to name the knob 'display gamma'.

.malcolm

On 11/01/2011, at 12:43 PM, Jeremy Selan wrote:

Issue:
http://github.com/imageworks/OpenColorIO/issues#issue/45

Commit:
http://github.com/jeremyselan/OpenColorIO/commit/c206c4fe65d415b5c87c09acde3e05013dc0ab9f

I've exposed a gamma control for the Nuke OCIODisplay node. The gamma
control, like the origin one in nuke's monitor, is post-display
transform.

-- Jeremy


Jeremy Selan <jeremy...@...>
 

done.

On Mon, Jan 10, 2011 at 6:00 PM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:
On 11/01/2011, at 12:54 PM, Jeremy Selan wrote:

Spaces in knob names have always worried me.  How about an underscore
in the knob name?
perfect


On Mon, Jan 10, 2011 at 5:51 PM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:
On 11/01/2011, at 12:49 PM, Jeremy Selan wrote:
UI Label or underlying knob name?
I would do both just for consistency.


On Mon, Jan 10, 2011 at 5:48 PM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:
LGTM

I would be tempted to name the knob 'display gamma'.

.malcolm

On 11/01/2011, at 12:43 PM, Jeremy Selan wrote:

Issue:
http://github.com/imageworks/OpenColorIO/issues#issue/45

Commit:
http://github.com/jeremyselan/OpenColorIO/commit/c206c4fe65d415b5c87c09acde3e05013dc0ab9f

I've exposed a gamma control for the Nuke OCIODisplay node.  The gamma
control, like the origin one in nuke's monitor, is post-display
transform.

-- Jeremy