Review: No more email reviews!


Jeremy Selan <jeremy...@...>
 

So github's pull request mechanism has gotten a lot better since we
started the project.

At this point I don't see a compelling reason to submit reviews to
this email alias, rather than to just use github's existing mechanism.
Does anyone disagree?

If we're in favor of testing the approach out, I'll be submitting a
pull request momentarily (with the apps updated to not use boost's
program options).

-- Jeremy


"dbr/Ben" <b...@...>
 

Sounds good.

My only concern is that discussion would end up being spread over both the mailing list, and pull request comments - it's kind of nice to have it all in one place

...but that's a pretty minor thing - I like the pull requests, they're much more accessible and visible
- Ben

On 09/02/2011, at 12:01 PM, Jeremy Selan wrote:

So github's pull request mechanism has gotten a lot better since we
started the project.

At this point I don't see a compelling reason to submit reviews to
this email alias, rather than to just use github's existing mechanism.
Does anyone disagree?

If we're in favor of testing the approach out, I'll be submitting a
pull request momentarily (with the apps updated to not use boost's
program options).

-- Jeremy


Jeremy Selan <jeremy...@...>
 

Actually, on further thought let's do both.  Very few people get notified of pull requests, and I'd like to keep everyone on this list in the development loop. (that is it's purpose, after all).

So going ahead, I'd like to encourage review emails, to this list, that have a link to a github pull request and a quick summary.

Thanks!

-- Jeremy