Review: OCIO namespace update


Jeremy Selan <jeremy...@...>
 

OCIO namespace #define is now configured using the CMAKE
configure_file mojo. This makes namespace errors far less likely, as
it's baked into the header that's a part of make_install.

commits:
d00581c9373806b85416115a58488d57a12be04a


Malcolm Humphreys <malcolmh...@...>
 

I think your missing a set() line in the CMakeLists.txt eg.
..
set(OCIO_VERSION "${OCIO_VERSION_MAJOR}.${OCIO_VERSION_MINOR}.${OCIO_VERSION_PATCH}")
set(OCIO_NAMESPACE OpenColorIO)
..

Other than that it LGTM.

.malcolm

On 27/10/2010, at 9:16 AM, Jeremy Selan wrote:

OCIO namespace #define is now configured using the CMAKE
configure_file mojo.  This makes namespace errors far less likely, as
it's baked into the header that's a part of make_install.

commits:
d00581c9373806b85416115a58488d57a12be04a


Jeremy Selan <jeremy...@...>
 

Can you be more specific? Which CMakeLists file, the root one or the
one in src/core?

The main CMake file has this chunk,

# Set the default namespace
if(NOT OCIO_NAMESPACE)
set(OCIO_NAMESPACE OpenColorIO CACHE STRING
"Specify the master OCIO C++ namespace: Options include
OpenColorIO OpenColorIO_<YOURFACILITY> etc."
FORCE)
endif(NOT OCIO_NAMESPACE)

What is not working for you?
Can you nuke your build dir and try again 'fresh'?

-- Jeremy

On Wed, Oct 27, 2010 at 11:10 PM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:
I think your missing a set() line in the CMakeLists.txt eg.
..
set(OCIO_VERSION
"${OCIO_VERSION_MAJOR}.${OCIO_VERSION_MINOR}.${OCIO_VERSION_PATCH}")
set(OCIO_NAMESPACE OpenColorIO)
..
Other than that it LGTM.
.malcolm
On 27/10/2010, at 9:16 AM, Jeremy Selan wrote:

OCIO namespace #define is now configured using the CMAKE
configure_file mojo.  This makes namespace errors far less likely, as
it's baked into the header that's a part of make_install.

commits:
d00581c9373806b85416115a58488d57a12be04a


Malcolm Humphreys <malcolmh...@...>
 

Sorry I never noticed that section in the main CMakelists file, it all looks good.

"Jeremy Selan" <jeremy...@gmail.com> wrote:

Can you be more specific? Which CMakeLists file, the root one or the
one in src/core?

The main CMake file has this chunk,

# Set the default namespace
if(NOT OCIO_NAMESPACE)
set(OCIO_NAMESPACE OpenColorIO CACHE STRING
"Specify the master OCIO C++ namespace: Options include
OpenColorIO OpenColorIO_<YOURFACILITY> etc."
FORCE)
endif(NOT OCIO_NAMESPACE)

What is not working for you?
Can you nuke your build dir and try again 'fresh'?

-- Jeremy

On Wed, Oct 27, 2010 at 11:10 PM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:
I think your missing a set() line in the CMakeLists.txt eg.
..
set(OCIO_VERSION
"${OCIO_VERSION_MAJOR}.${OCIO_VERSION_MINOR}.${OCIO_VERSION_PATCH}")
set(OCIO_NAMESPACE OpenColorIO)
..
Other than that it LGTM.
.malcolm
On 27/10/2010, at 9:16 AM, Jeremy Selan wrote:

OCIO namespace #define is now configured using the CMAKE
configure_file mojo.  This makes namespace errors far less likely, as
it's baked into the header that's a part of make_install.

commits:
d00581c9373806b85416115a58488d57a12be04a

--
Sent from my phone.


Jeremy Selan <jeremy...@...>
 

Excellent, thanks.

On Thu, Oct 28, 2010 at 2:31 PM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:
Sorry I never noticed that section in the main CMakelists file, it all looks good.