Review: OCIO now adheres to commonwealth convention


Jeremy Selan <jeremy...@...>
 

This breaks ABI compatibility.

Let me know if anyone has any concerns?

https://github.com/imageworks/OpenColorIO/pull/250


Hugh Macdonald <hugh.ma...@...>
 

No concerns from this side of the pond... ;-)

I've been somewhat concerned about this bug for some time now, and it's glad to see it's now been addressed.

Now if only The Foundry could do the same in Nuke (they're based in London - this should be one of their top priorities), I'll be happy.

Hugh Macdonald
nvizibleVISUAL EFFECTS

hugh.ma...@...
+44(0) 20 3167 3860
+44(0) 7773 764 708

www.nvizible.com

On 01/04/12 18:09, Jeremy Selan wrote:
This breaks ABI compatibility.

Let me know if anyone has any concerns?

https://github.com/imageworks/OpenColorIO/pull/250


Sean Looper <sean....@...>
 

Should this be done with #ifdefs instead? Perhaps driven by a USE_COLOUR variable?

-sean


On Sun, Apr 1, 2012 at 10:14 AM, Hugh Macdonald <hugh.ma...@...> wrote:
No concerns from this side of the pond... ;-)

I've been somewhat concerned about this bug for some time now, and it's glad to see it's now been addressed.

Now if only The Foundry could do the same in Nuke (they're based in London - this should be one of their top priorities), I'll be happy.

Hugh Macdonald
nvizibleVISUAL EFFECTS

hugh.ma...@...
+44(0) 20 3167 3860
+44(0) 7773 764 708

www.nvizible.com

On 01/04/12 18:09, Jeremy Selan wrote:
This breaks ABI compatibility.

Let me know if anyone has any concerns?

https://github.com/imageworks/OpenColorIO/pull/250


Steve LaVietes <steve.l...@...>
 

This is an outrage. I'm immediately switching to Photoshop CS 6 beta for all of my color needs.

-stevel



On Apr 1, 2012, at 10:09 AM, Jeremy Selan <jeremy...@...> wrote:

This breaks ABI compatibility.

Let me know if anyone has any concerns?

https://github.com/imageworks/OpenColorIO/pull/250


Matt Plec <mp...@...>
 

I haven't done a thorough check but I'll bet there are some uses of the letter Z that don't conform to convention either.

Speaking of... Hugh, shouldn't that be "nvisible" ? ;-)


On Sun, Apr 1, 2012 at 8:22 PM, Steve LaVietes <steve.l...@...> wrote:
This is an outrage. I'm immediately switching to Photoshop CS 6 beta for all of my color needs.

-stevel



On Apr 1, 2012, at 10:09 AM, Jeremy Selan <jeremy...@...> wrote:

This breaks ABI compatibility.

Let me know if anyone has any concerns?

https://github.com/imageworks/OpenColorIO/pull/250


Deke Kincaid <dekek...@...>
 

I was in the middle or writing an angry letter and then realized what day it was :)

-deke


On Sun, Apr 1, 2012 at 14:29, Matt Plec <mp...@...> wrote:
I haven't done a thorough check but I'll bet there are some uses of the letter Z that don't conform to convention either.

Speaking of... Hugh, shouldn't that be "nvisible" ? ;-)


On Sun, Apr 1, 2012 at 8:22 PM, Steve LaVietes <steve.l...@...> wrote:
This is an outrage. I'm immediately switching to Photoshop CS 6 beta for all of my color needs.

-stevel



On Apr 1, 2012, at 10:09 AM, Jeremy Selan <jeremy...@...> wrote:

This breaks ABI compatibility.

Let me know if anyone has any concerns?

https://github.com/imageworks/OpenColorIO/pull/250



Dithermaster <dither...@...>
 

Well played Jeremy!

///d@


On Sun, Apr 1, 2012 at 7:03 PM, Deke Kincaid <dekek...@...> wrote:
I was in the middle or writing an angry letter and then realized what day it was :)

-deke


On Sun, Apr 1, 2012 at 14:29, Matt Plec <mp...@...> wrote:
I haven't done a thorough check but I'll bet there are some uses of the letter Z that don't conform to convention either.

Speaking of... Hugh, shouldn't that be "nvisible" ? ;-)


On Sun, Apr 1, 2012 at 8:22 PM, Steve LaVietes <steve.l...@...> wrote:
This is an outrage. I'm immediately switching to Photoshop CS 6 beta for all of my color needs.

-stevel



On Apr 1, 2012, at 10:09 AM, Jeremy Selan <jeremy...@...> wrote:

This breaks ABI compatibility.

Let me know if anyone has any concerns?

https://github.com/imageworks/OpenColorIO/pull/250




Jeremy Selan <jeremy...@...>
 

Thanks everyone for all the suggestions!

(Closing the pull request.)

Until next year...??...

-- Jeremy


On Sun, Apr 1, 2012 at 6:02 PM, Dithermaster <dither...@...> wrote:
Well played Jeremy!

///d@


On Sun, Apr 1, 2012 at 7:03 PM, Deke Kincaid <dekek...@...> wrote:
I was in the middle or writing an angry letter and then realized what day it was :)

-deke


On Sun, Apr 1, 2012 at 14:29, Matt Plec <mp...@...> wrote:
I haven't done a thorough check but I'll bet there are some uses of the letter Z that don't conform to convention either.

Speaking of... Hugh, shouldn't that be "nvisible" ? ;-)


On Sun, Apr 1, 2012 at 8:22 PM, Steve LaVietes <steve.l...@...> wrote:
This is an outrage. I'm immediately switching to Photoshop CS 6 beta for all of my color needs.

-stevel



On Apr 1, 2012, at 10:09 AM, Jeremy Selan <jeremy...@...> wrote:

This breaks ABI compatibility.

Let me know if anyone has any concerns?

https://github.com/imageworks/OpenColorIO/pull/250