Review: use CPack to create the source tarball


Malcolm Humphreys <malcolmh...@...>
 

* added cpack support to replace the tgz_create script. Run 'make package_source' to create 'olio.VERSION.tar.gz'
* removed tgz_create script

http://github.com/malcolmhumphreys/OpenColorIO/commit/a02d021cb8bc9d297e4db4d133e16fc189f75405

.malcolm


Jeremy Selan <jeremy...@...>
 

looks good to me.
-- Jeremy

On Thu, Oct 14, 2010 at 4:22 AM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:
* added cpack support to replace the tgz_create script. Run 'make package_source' to create 'olio.VERSION.tar.gz'
* removed tgz_create script

http://github.com/malcolmhumphreys/OpenColorIO/commit/a02d021cb8bc9d297e4db4d133e16fc189f75405

.malcolm


Jeremy Selan <jeremy...@...>
 

One gotcha: when you use `make package_source` it appears to grab all
files in the subdirectory, including the build dirs and other files
which may not be part of the repository. I'm looking at setting up
cpack to only include specified subdirs.

-- Jeremy

On Fri, Oct 15, 2010 at 3:20 PM, Jeremy Selan <jeremy...@gmail.com> wrote:
looks good to me.
-- Jeremy

On Thu, Oct 14, 2010 at 4:22 AM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:
* added cpack support to replace the tgz_create script. Run 'make package_source' to create 'olio.VERSION.tar.gz'
* removed tgz_create script

http://github.com/malcolmhumphreys/OpenColorIO/commit/a02d021cb8bc9d297e4db4d133e16fc189f75405

.malcolm


Malcolm Humphreys <malcolmh...@...>
 

There is a cpack ignore dirs command, I would recommended doing out of source builds also.

"Jeremy Selan" <jeremy...@gmail.com> wrote:

One gotcha: when you use `make package_source` it appears to grab all
files in the subdirectory, including the build dirs and other files
which may not be part of the repository. I'm looking at setting up
cpack to only include specified subdirs.

-- Jeremy

On Fri, Oct 15, 2010 at 3:20 PM, Jeremy Selan <jeremy...@gmail.com> wrote:
looks good to me.
-- Jeremy

On Thu, Oct 14, 2010 at 4:22 AM, Malcolm Humphreys
<malcolmh...@mac.com> wrote:
* added cpack support to replace the tgz_create script. Run 'make package_source' to create 'olio.VERSION.tar.gz'
* removed tgz_create script

http://github.com/malcolmhumphreys/OpenColorIO/commit/a02d021cb8bc9d297e4db4d133e16fc189f75405

.malcolm

--
Sent from my phone.


Alan Jones <sky...@...>
 

Hi Jeremy,

On Fri, Oct 15, 2010 at 5:35 PM, Jeremy Selan <jeremy...@gmail.com> wrote:
One gotcha:  when you use `make package_source` it appears to grab all
files in the subdirectory, including the build dirs and other files
which may not be part of the repository.   I'm looking at setting up
cpack to only include specified subdirs.
You can use the CPACK_SOURCE_IGNORE_FILES to hold a semi-colon separated
list of regexs to ignore files/directories.

Cheers,

Alan.