Upstreamable patches?


Richard Shaw <hobbe...@...>
 

Hey guys, been a while but things seem to be going well with my Fedora
package of ocio so I haven't needed to ask any questions lately.

I was going through my packages and noticed I have two patches against
the current 1.0.7 source which I think are upstreamable. I may have
already mentioned them but I've slept too many times since then to be
sure.

This one makes sure that no hidden files are packaged in the
documentation (found my rpmlint):
https://dl.dropbox.com/u/34775202/ocio/OpenColorIO-1.0.7-docfix.patch

This one gives me the option to no put a soname on the pyglue library:
https://dl.dropbox.com/u/34775202/ocio/OpenColorIO-1.0.7-pylib_no_soname.patch

Thanks,
Richard


Jeremy Selan <jeremy...@...>
 

Both of those look good to get into the main repo. Are you
comfortable submitting a pull request? If not, I am happy too.

Out of curiosity, i'll have to admit that I'm a bit of a newbie in
terms of package management? Is there a simple command-line to do an
ocio package installation on fedora? If so, we should certainly update
the docs / website to reflect as much.

-- Jeremy

On Tue, Dec 11, 2012 at 6:22 AM, Richard Shaw <hobbe...@gmail.com> wrote:
Hey guys, been a while but things seem to be going well with my Fedora
package of ocio so I haven't needed to ask any questions lately.

I was going through my packages and noticed I have two patches against
the current 1.0.7 source which I think are upstreamable. I may have
already mentioned them but I've slept too many times since then to be
sure.

This one makes sure that no hidden files are packaged in the
documentation (found my rpmlint):
https://dl.dropbox.com/u/34775202/ocio/OpenColorIO-1.0.7-docfix.patch

This one gives me the option to no put a soname on the pyglue library:
https://dl.dropbox.com/u/34775202/ocio/OpenColorIO-1.0.7-pylib_no_soname.patch

Thanks,
Richard

--


Richard Shaw <hobbe...@...>
 

On Tue, Dec 11, 2012 at 7:48 PM, Jeremy Selan <jeremy...@gmail.com> wrote:
Both of those look good to get into the main repo. Are you
comfortable submitting a pull request? If not, I am happy too.
Oh, it looks like someone already did this for me on 1.0.8, correct?
If not, I'll do a pull request..


Out of curiosity, i'll have to admit that I'm a bit of a newbie in
terms of package management? Is there a simple command-line to do an
ocio package installation on fedora? If so, we should certainly update
the docs / website to reflect as much.
Yes, I remember now saying that we should do that once the packages
were accepted but never got around to doing it :)

a simple "yum install OpenColorIO" will work on F15 and up and also on
EL6 (but only if using the Fedora EPEL repository...)

Thanks,
Richard


dbr/Ben <dbr....@...>
 

On 12/12/2012, at 2:51 PM, Richard Shaw wrote:
Oh, it looks like someone already did this for me on 1.0.8, correct?

Think it was you (or your helpful evil-twin) :D


..which were both tagged in v1.0.7 if I'm not mistaken:

$ git describe b7ac8ae8fc508a4ef96052e219953aebecb3f216
v1.0.7-4-gb7ac8ae
$ git describe 44c82c50d18fd23ca035de1272bd27a016511a7c
v1.0.7-1-g44c82c5

a simple "yum install OpenColorIO" will work on F15 and up and also on
EL6 (but only if using the Fedora EPEL repository...)

This should definitely be mentioned in the installation guide - having a nice easy install option before the "Building from source" instructions is a great improvement!

It should also mention the "Homebrew" installation command for OS X ("brew install opencolorio")

I'm happy to add this, as I'm working on other sections of the docs right now


Jeremy Selan <jeremy...@...>
 

Please do add the pre-built installation guides in the docs (as you
mention). Thanks!

-- Jeremy

On Wed, Dec 12, 2012 at 4:35 AM, dbr/Ben <dbr....@gmail.com> wrote:
On 12/12/2012, at 2:51 PM, Richard Shaw wrote:

Oh, it looks like someone already did this for me on 1.0.8, correct?


Think it was you (or your helpful evil-twin) :D

https://github.com/imageworks/OpenColorIO/commit/b7ac8ae8fc508a4ef96052e219953aebecb3f216
https://github.com/imageworks/OpenColorIO/commit/44c82c50d18fd23ca035de1272bd27a016511a7c

..which were both tagged in v1.0.7 if I'm not mistaken:

$ git describe b7ac8ae8fc508a4ef96052e219953aebecb3f216
v1.0.7-4-gb7ac8ae
$ git describe 44c82c50d18fd23ca035de1272bd27a016511a7c
v1.0.7-1-g44c82c5

a simple "yum install OpenColorIO" will work on F15 and up and also on
EL6 (but only if using the Fedora EPEL repository...)


This should definitely be mentioned in the installation guide - having a
nice easy install option before the "Building from source" instructions is a
great improvement!

It should also mention the "Homebrew" installation command for OS X ("brew
install opencolorio")

I'm happy to add this, as I'm working on other sections of the docs right
now

--


dbr/Ben <dbr....@...>
 

On 13/12/2012, at 1:46 AM, Jeremy Selan wrote:

Please do add the pre-built installation guides in the docs (as you
mention).  Thanks!

-- Jeremy

On Wed, Dec 12, 2012 at 4:35 AM, dbr/Ben <dbr....@...> wrote:
On 12/12/2012, at 2:51 PM, Richard Shaw wrote:

Oh, it looks like someone already did this for me on 1.0.8, correct?


Think it was you (or your helpful evil-twin) :D

https://github.com/imageworks/OpenColorIO/commit/b7ac8ae8fc508a4ef96052e219953aebecb3f216
https://github.com/imageworks/OpenColorIO/commit/44c82c50d18fd23ca035de1272bd27a016511a7c

..which were both tagged in v1.0.7 if I'm not mistaken:

$ git describe b7ac8ae8fc508a4ef96052e219953aebecb3f216
v1.0.7-4-gb7ac8ae
$ git describe 44c82c50d18fd23ca035de1272bd27a016511a7c
v1.0.7-1-g44c82c5

a simple "yum install OpenColorIO" will work on F15 and up and also on
EL6 (but only if using the Fedora EPEL repository...)


This should definitely be mentioned in the installation guide - having a
nice easy install option before the "Building from source" instructions is a
great improvement!

It should also mention the "Homebrew" installation command for OS X ("brew
install opencolorio")

I'm happy to add this, as I'm working on other sections of the docs right
now

--



--