toggle quoted messageShow quoted text
Doesn't look like looking through the commit history is triggering anything; those are just merges along the way. Indeed taking a step back a few years (decades?) I see the following on Savannah. ; http://cvs.savannah.nongnu.org/viewvc/openexr/OpenEXR/IlmImf/ImfChromaticities.cpp?view=log
Stepping through the diffs there it looks like this one dates back all the way to the first public release.
Revision 1.1 - (view) (download) (annotate) - [select for diffs]
Tue Dec 2 03:06:21 2003 UTC (16 years, 2 months ago) by dhess
CVS Tags: HEAD, OPENEXR_1_0_7, OPENEXR_1_1_0, OPENEXR_1_1_1, OPENEXR_1_2_1, OPENEXR_1_2_2, OPENEXR_1_3_0, OPENEXR_1_3_1, OPENEXR_1_3_2,OPENEXR_1_4_0, OPENEXR_1_4_0a, OPENEXR_1_7_0
Branch point for: OPENEXR_1_0_7_PATCHES, lossy
* Support for new "optional standard" attributes (chromaticities,
luminance, comments, etc.). (Florian Kainz, Greg Ward, Joseph Goldstone)
I rather think we should rework this. As Phil points out, the floating point comparison here is ready to haunt us and we are indeed missing the white point.
I would be tempted to settle on a tolerance to account for some common round trips, e.g. P3 -> sRGB -> P3 and some white point adaptation matrices.
Phil, I don't have the numbers in front of me, but do you know what the maximum delta-E is for a 4 decimal place perturbation?
On Wed, 5 Feb 2020 at 17:33, Cary Phillips <cary@...> wrote: