Re: Fix errors and warnings from g++-4.4.1 (issue193074)
chri...@...
On 2010/01/24 08:26:12, blair wrote:
You could do what Google Protocol Buffers does and determine whichhash map to use at configure time. It works with g++ 3.4.x all the way up to4.4.x. See the m4 file at: http://code.google.com/p/protobuf/source/browse/trunk/m4/stl_hash.m4IMHO this seems to be a bit of overkill, and my preferred option would be just to specify that >=boost-1.36 was necessary. However I know that may not be an option for everyone so I'll let the OSL core developers chime in. What's the story guys? I'll note that using hash_map *does* compile with g++-4.4.1, but not without warnings (and hence doesn't compile when using -Werror which is turned on by default in the build scripts). Protocol Buffers has a new BSD license so this could be copiedstraight from them.The M4 would have to be converted to cmake, but it's good to see all the potential places which hash_map may reside. Gosh there's a lot! http://codereview.appspot.com/193074/show |
|