1. Messages
  2. Fix errors and warnings from g++-4.4.1 (issue193074)

Re: Fix errors and warnings from g++-4.4.1 (issue193074)

Wormszer <worm...@...>
 

I too recieved an error from strcmp in oslex.l/cpp when building with visual studio.

Visual studio has not deprecated hash_map from what i can tell, but a boost solution would work there as well.

Does the gcc build really generate no warnings, i guess it must not with the compiler flags to make warnings errors?
I just built oslcomp and I get about 3800 warnings, this is displaying all warnings.

Just picking one example some functions don't have a return in the default switch case, even though the default switch case has a ASSERT macro that calls abort, VS throws a warning.

Jeremy


On Sun, Jan 24, 2010 at 4:28 AM, <chri...@...> wrote:
On 2010/01/24 08:26:12, blair wrote:
You could do what Google Protocol Buffers does and determine which
hash map to
use at configure time.  It works with g++ 3.4.x all the way up to
4.4.x.  See
the m4 file at:

http://code.google.com/p/protobuf/source/browse/trunk/m4/stl_hash.m4

IMHO this seems to be a bit of overkill, and my preferred option would
be just to specify that >=boost-1.36 was necessary.  However I know that
may not be an option for everyone so I'll let the OSL core developers
chime in.  What's the story guys?

I'll note that using hash_map *does* compile with g++-4.4.1, but not
without warnings (and hence doesn't compile when using -Werror which is
turned on by default in the build scripts).


Protocol Buffers has a new BSD license so this could be copied
straight from
them.

The M4 would have to be converted to cmake, but it's good to see all the
potential places which hash_map may reside.  Gosh there's a lot!



http://codereview.appspot.com/193074/show

--
You received this message because you are subscribed to the Google Groups "OSL Developers" group.
To post to this group, send email to osl...@....
To unsubscribe from this group, send email to osl...@....
For more options, visit this group at http://groups.google.com/group/osl-dev?hl=en.
Join {osl-dev@lists.aswf.io to automatically receive all group messages.