Re: Review: bind refactor (issue195042)
cku...@...
LGTM - just a few small notes
http://codereview.appspot.com/195042/diff/1/5 File src/liboslexec/exec.cpp (right): http://codereview.appspot.com/195042/diff/1/5#newcode191 src/liboslexec/exec.cpp:191: VaryingRef<float> * valref = NULL, *dxref = NULL, *dyref = NULL; This is a big confusing - they all get turned into a VaryingRef to floats even though they all have different types. Maybe a comment could explain why this isn't important here. http://codereview.appspot.com/195042/diff/1/5#newcode310 src/liboslexec/exec.cpp:310: // Uninitialized strings in the heap can really screw Could we mark this as temporary? I really think it would be better to guarantee this on the compiler side. http://codereview.appspot.com/195042/show |
|