Re: Review: more nan/inf checking (issue196066)

Home Messages Hashtags Subgroups Calendar

Larry Gritz <l...@...> #186 Good call on both counts. I will upload an updated review shortly. -- lg On Feb 1, 2010, at 8:26 AM, <cku...@...> <cku...@...> wrote: http://codereview.appspot.com/196066/diff/1/3 File src/liboslexec/exec.cpp (right): http://codereview.appspot.com/196066/diff/1/3#newcode345 src/liboslexec/exec.cpp:345: if (debugnan && check_nan (sym, NULL, 0, m_npoints-1, badval)) Can you pass the original run flags here? Otherwise you are checking points that might not be valid. http://codereview.appspot.com/196066/diff/1/3#newcode384 src/liboslexec/exec.cpp:384: if (!get_renderer_userdata (m_npoints, wants_derivatives, It would be good to check the results here too. http://codereview.appspot.com/196066/show -- Larry Gritz l...@...
More

Join {osl-dev@lists.aswf.io to automatically receive all group messages.