Re: Review: improve adjust_varying (issue204046)


Larry Gritz <l...@...>
 

On Feb 5, 2010, at 11:03 PM, Solomon Boulos wrote:

I forgot to also second Chris's suggestion that the enter/exit stuff be moved into push/pop_runflags() (which despite sounding like a general utility function is _only_ used when the runflags "changes" -- modulo the note below).
That's not actually true. We push when we first run the shader, and that doesn't change the runflags. And we need to, so that exit() will work correctly.

I suppose we could have an optional argument to push_runflags that says whether we expect the runflags to actually change, and modify the 'diverged' flag only in that case.


--
Larry Gritz
l...@...

Join osl-dev@lists.aswf.io to automatically receive all group messages.