Review: message passing of closures, and bug fixes


Larry Gritz <l...@...>
 

We're big fans of code reviews BEFORE committing into the trunk, and at SPI used ReviewBoard religiously while developing OSL. We're still trying to figure out how to do reviews the way we prefer, now that we're on google code; their native tool is set up for post-commit reviews.

So here's our first try at using codereview.appspot.com, a google web app that lets you make code reviews for local changes that haven't been committed, against a public repository. Let's see how well it goes. Apologies if it's clunky until we figure out the logistics.

There will probably be a duplicate email to the group, since I specified osl...@... as a CC on the review app.


http://codereview.appspot.com/186135


--
Larry Gritz
l...@...

Join osl-dev@lists.aswf.io to automatically receive all group messages.