Review: fix derivatives of mod()
Larry Gritz <l...@...>
http://codereview.appspot.com/189073
Ugh, still having trouble making it send all review emails to this list automatically. -- Larry Gritz l...@...
|
|
Our code development
Larry Gritz <larry...@...>
I hope you all can see from the traffic in the last few days that
Imageworks is not merely planning to occasionally snapshot OSL and release it, but rather we are committed to developing the whole thing in public, warts and all. (This is not just my idea, but indeed is the explicit directive from management.) The google code SVN *is* our development trunk, we are trying to do all our code reviews over this mail list and codereview.appspot.com, and use the google-hosted bug tickets for our actual issue tracking (except for cases specific to our in-house renderer or that discuss unreleased films). So you'll see everything, be it good, bad, ugly, or irrelevant. But you'll also see the steady daily progress, maybe learn something about our development process, and some of you, I hope, will be inspired to participate. -- lg
|
|
Re: Question about BSDFClosure functions
Larry Gritz <l...@...>
On Jan 14, 2010, at 9:31 AM, Alex Conty wrote:
Apparently I can't post here from my work address, so resending. Sorry If it's just a case of the message bouncing because it doesn't know you (at work) are a member of the group, try signing up for a second googlegroups membership, using your work address, and check the box that says "web participation only, no email". That will make it accept emails from you but not send you duplicate emails to both your work mail and your gmail account. I have to say, one of my main annoyances with google code hosting is that so many things require "google credentials" rather than one's normal home or work email and userid. -- Larry Gritz l...@...
|
|
Re: Question about BSDFClosure functions
Alex Conty <aco...@...>
Apparently I can't post here from my work address, so resending. Sorry
if somebody gets a duplicate. Hi Brecht, I'm Alejandro Conty (jandro in the old blender days), we met several times at the Blender conference. Nice hearing from you about this. I understand the main use for this is importance sampling. I'm afraidI have a question that I couldn't find an answer to in the I'm not allowed to say how we do things here at imageworks, but there are other ways to do importance sampling. That function would make things easier, of course, the problem is that not all BSDF's can be easily integrated. The expensive method is not an option, it would be overkill. So you need an analytical solution which is not always available. There is also a practical issue too. We have this sample function that has to return a normalized PDF and so. It turns out that people find it very hard to implement it in some cases. Even when the PDF doesn't have to match the BSDF exactly. So adding that extra function could be asking for too much. But the discussion is open and you are wellcome in. Let's see what the other guys think about this ... Alex
|
|
Question about BSDFClosure functions
brecht <brechtv...@...>
Hi,
First, let me say thanks for releasing this as open source, it's looking very impressive. I'm working on the shading system in Blender and was looking into how this design compares to what I'm planning and how I could make my implementation compatible such that OSL could be plugged in at a later time. I have a question that I couldn't find an answer to in the documentation or source code. The BSDFClosure has eval_reflect, eval_transmit and sample functions. Some rendering engines have an additional function to compute the average reflected or transmitted color independent of the incoming light direction, by the integrating the bsdf over the incoming light direction without any lights. In PBRT for example this function is called rho. There are a number of uses for this: * Compute surface albedo, i.e. "unshaded color", to output as a pass for example. * Compute surface opacity (by doing this for transmission), useful as a pass for compositing, rasterization with alpha or transparent shadows. * Importance sampling by picking one of two blended bsdf's proportional to this. It would be possible to compute this value by doing the integration each time, calling the sample function a number of times, but this is not as efficient as it could be. Or these values could be manually provided by the shader writer. Maybe there is another way to do this that I'm missing, or perhaps it was left out intentionally, or not implemented yet, ..? Thanks, Brecht.
|
|
Review: bug fix with compound initializers
Larry Gritz <l...@...>
http://codereview.appspot.com/189060
Sorry, I can't quite seem to get the review comments to automatically get sent to this list. Do we care? Would you guys like to see every review-related email, or just the initial "there is a review for Foo at http://blah"? -- Larry Gritz l...@...
|
|
Re: Bug fix with compound initializers (issue189060)
cku...@...
|
|
Bug fix with compound initializers (issue189060)
larry...@...
Reviewers: ,
Message: Review at http://codereview.appspot.com/189060 Description: Bug introduced with r507 when I overhauled compound initializers in ASTvariable_declaration. Forgot one place where they needed to be handled. Please review this at http://codereview.appspot.com/189060 Affected files: M src/liboslcomp/codegen.cpp M src/liboslcomp/oslcomp.cpp Index: src/liboslcomp/codegen.cpp =================================================================== --- src/liboslcomp/codegen.cpp (revision 517) +++ src/liboslcomp/codegen.cpp (working copy) @@ -515,7 +515,14 @@ if (init() && sym->fieldid() < 0) { // Normal vars with initializers -- generate them - for (ASTNode::ref i = init(); i; i = i->next()) { + + // If it's a compound initializer, look at the individual pieces + ref init = this->init(); + if (init->nodetype() == compound_initializer_node) { + init = ((ASTcompound_initializer *)init.get())->initlist(); + } + + for (ASTNode::ref i = init; i; i = i->next()) { completed &= param_one_default_literal (sym, i.get(), out); } } else { Index: src/liboslcomp/oslcomp.cpp =================================================================== --- src/liboslcomp/oslcomp.cpp (revision 517) +++ src/liboslcomp/oslcomp.cpp (working copy) @@ -601,7 +601,7 @@ } if (m_ircode.size() == 0) // If no code, still need a code marker - oso ("code main\n"); + oso ("code ___main___\n"); oso ("\tend\n");
|
|
Review: message passing of closures, and bug fixes
Larry Gritz <l...@...>
We're big fans of code reviews BEFORE committing into the trunk, and at SPI used ReviewBoard religiously while developing OSL. We're still trying to figure out how to do reviews the way we prefer, now that we're on google code; their native tool is set up for post-commit reviews.
So here's our first try at using codereview.appspot.com, a google web app that lets you make code reviews for local changes that haven't been committed, against a public repository. Let's see how well it goes. Apologies if it's clunky until we figure out the logistics. There will probably be a duplicate email to the group, since I specified osl...@... as a CC on the review app. http://codereview.appspot.com/186135 -- Larry Gritz l...@...
|
|
Re: Got it working I think?
Jon Macey <jma...@...>
still getting the fails,
toggle quoted messageShow quoted text
If I do a make debug I get loads of boost Undefined symbols: errors (for example) Linking CXX shared library liboslexec.dylib Undefined symbols: "boost::detail::get_tss_data(void const*)", referenced from: boost::thread_specific_ptr<OSL::pvt::ShadingSystemImpl::PerThreadInfo>::get () const in shadingsys.cpp.o "boost::detail::set_tss_data(void const*, boost::shared_ptr<boost::detail::tss_cleanup_function>, void*, bool)", referenced from: boost::thread_specific_ptr<OSL::pvt::ShadingSystemImpl::PerThreadInfo>::reset (OSL::pvt::ShadingSystemImpl::PerThreadInfo*)in shadingsys.cpp.o ld: symbol(s) not found and Linking CXX shared library liboslcomp.dylib Undefined symbols: "boost::filesystem::detail::status_api(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, boost::system::error_code&)", referenced from: boost::enable_if<boost::filesystem::is_basic_path<boost::filesystem::basic_path<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, boost::filesystem::path_traits> >, bool>::type boost::filesystem::exists<boost::filesystem::basic_path<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, boost::filesystem::path_traits> > (boost::filesystem::basic_path<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, boost::filesystem::path_traits> const&)in oslcomp.cpp.o ld: symbol(s) not found Will need to check my boost install and get back to you (tomorrow now) as the non debug version compile fine Cheers Jon
On Jan 12, 7:35 pm, Larry Gritz <l...@...> wrote:
The "run.py" script takes arguments (which are passed when the testsuite is run). You want:
|
|
Re: Got it working I think?
Larry Gritz <l...@...>
The "run.py" script takes arguments (which are passed when the testsuite is run). You want:
cd testsuite/YOURTEST ./run.py . ../../build/ARCH (ARCH in your case is "macosx") Does that help? If not, can you do a 'make debug' and see if you can figure out the line where it's crashing? -- lg On Jan 12, 2010, at 11:17 AM, Jon Macey wrote: Building on Mac OS X (Darwin)-- Larry Gritz l...@...
|
|
Re: Got it working I think?
Jon Macey <jma...@...>
I've just run it in gdb and got the following
toggle quoted messageShow quoted text
Program received signal EXC_BAD_ACCESS, Could not access memory. Reason: KERN_PROTECTION_FAILURE at address: 0x00000001 0x0016a07d in OSL::pvt::ShadingContext::execute () (gdb) up #1 0x00009608 in main () not familiar with the source yet so will investigate more
On Jan 12, 7:17 pm, Jon Macey <j...@...> wrote:
Building on Mac OS X (Darwin)
|
|
Got it working I think?
Jon Macey <jma...@...>
Building on Mac OS X (Darwin)
seems to work and run but when I try most of the tests it seems to fail with a bus error For example (geomath) edit run.py to work with my local paths geomath]$./run.py test.osl:0: warning: Unable to find "/usr/shaders" sh: line 1: 31148 Bus error testshade -g 2 2 test >> out.txt FAIL however out.txt Compiled test.osl -> test.oso hypot (3, 4) = 5 hypot (3, 4, 5) = 7.07107 reflect (0.447214 -0.894427 0, 0 1 0) = 0.447214 0.894427 0 reflect (0.447214 -0.894427 0, -1 0 0) = -0.447214 -0.894427 0 testing total-internal reflection: refract (0.707107 -0.707107 0, 0 1 0, 1.42) = 0 0 0 frensel: Kr= 1 Kt = 0 R = 0.707107 0.707107 0 T = 0 0 0 testing regular refraction: refract (-0.436436 -0.218218 -0.872872, 0.267261 0.534522 0.801784, 0.862069) = -0.415346 -0.266336 -0.869801 --> verify refract(): 1/1.16 = sin(18.0549)/sin(21.0705) => 0.862069 ?= 0.862068 fresnel: Kr= 0.00557254 Kt = 0.739022 R = 0.0623479 0.779349 0.623479 T = -0.415346 -0.266336 -0.869801 --> verify fresnel(): 1/1.16 = sin(18.0549)/sin(21.0705) => 0.862069 ?= 0.862068 Varying: hypot (0, 0) = 0 hypot (1, 0) = 1 hypot (0, 1) = 1 hypot (1, 1) = 1.41421 hypot (0, 0, 0) = 0 hypot (1, 0, 1) = 1.41421 hypot (0, 1, 1) = 1.41421 hypot (1, 1, 2) = 2.44949 reflect (0 -1 0, 0 1 0) = 0 1 0 reflect (0.447214 -0.894427 0, 0 1 0) = 0.447214 0.894427 0 reflect (0 -1 0, 0.707107 0.707107 0) = 1 -5.96046e-08 0 reflect (0.447214 -0.894427 0, 0.707107 0.707107 0) = 0.894427 -0.447214 0 refract (0.408248 -0.408248 -0.816497, 0 0 1, 0.75188) = 0.306954 -0.306954 -0.900866 refract (0.801784 -0.267261 -0.534522, 0 0 1, 0.75188) = 0.602845 -0.200948 -0.772138 refract (0.408248 0.408248 -0.816497, 0 0 1, 0.75188) = 0.306954 0.306954 -0.900866 refract (0.801784 0.267261 -0.534522, 0 0 1, 0.75188) = 0.602845 0.200948 -0.772138 --> verify refract(): 1/1.33 = sin(25.7279)/sin(35.2644) => 0.75188 ?= 0.75188 --> verify refract(): 1/1.33 = sin(39.4537)/sin(57.6885) => 0.75188 ?= 0.75188 --> verify refract(): 1/1.33 = sin(25.7279)/sin(35.2644) => 0.75188 ?= 0.75188 --> verify refract(): 1/1.33 = sin(39.4537)/sin(57.6885) => 0.75188 ?= 0.75188 fresnel() -> Kr= 0.0222824 Kt = 0.552726 R = 0 0 0 T = 0.306954 -0.306954 -0.900866 fresnel() -> Kr= 0.0505776 Kt = 0.53673 R = 0 0 0 T = 0.602845 -0.200948 -0.772138 fresnel() -> Kr= 0.0222824 Kt = 0.552726 R = 0 0 0 T = 0.306954 0.306954 -0.900866 fresnel() -> Kr= 0.0505776 Kt = 0.53673 R = 0 0 0 T = 0.602845 0.200948 -0.772138 --> verify fresnel(): 1/1.33 = sin(25.7279)/sin(35.2644) => 0.75188 ?= 0.75188 --> verify fresnel(): 1/1.33 = sin(39.4537)/sin(57.6885) => 0.75188 ?= 0.75188 --> verify fresnel(): 1/1.33 = sin(25.7279)/sin(35.2644) => 0.75188 ?= 0.75188 --> verify fresnel(): 1/1.33 = sin(39.4537)/sin(57.6885) => 0.75188 ?= 0.75188 which is the same as the ref Also had to do a couple of hacks in the oiio ivgl.cpp file to cast the std::max and std::clamp functions to get it all to compile I will play with the rest of the tests and see what happens Cheers Jon
|
|
Re: Build errors
Larry Gritz <larry...@...>
Aha, you must be a prior OpenImageIO user. You need to 'svn update'
toggle quoted messageShow quoted text
and recompile your OIIO -- this code in OSL requires a recent change to the ParamValueList helper class that's part of OIIO. At this moment, the required OIIO change is only in the OIIO trunk, it hasn't migrated to the 0.7 release branch. Let me know if this is a problem, and I'll merge it right away. -- lg
On Jan 12, 4:51 am, Adrien Herubel <he...@...> wrote:
Hi,
|
|
Build errors
Adrien Herubel <her...@...>
Hi,
I encountered several minor build errors both on release and debug. I corrected a few (I'll release a patch if you're interrested) but there is one i can't explain : src/liboslexec/opmessage.cpp:71: error: ‘class ParamValueList’ has no member named ‘grow’ I didn't find any declaration of the class/struct/typedef of ParamValueList I used : g++ (SUSE Linux) 4.4.1 [gcc-4_4-branch revision 150839]
|
|
Overview of unique OSL features and state of the project
Larry Gritz <larry...@...>
I've posted a Wiki page giving a brief introduction to the project, a
list of things unique to OSL (compared to other shading languages), a status report on the current state of the project. Click on the "Wiki" tab on the OSL project page, or go directly to: http://code.google.com/p/openshadinglanguage/wiki/WikiIntroduction
|
|
Re: Today is the day
Larry Gritz <larry...@...>
OK, it seems to have been synced. The trunk is now where we're
toggle quoted messageShow quoted text
actually doing all our development. We will periodically make release branches and tags at stable points. -- lg
On Jan 11, 10:55 am, Larry Gritz <lar...@...> wrote:
The code is syncing right now, revision by revision. But it's going
|
|
Re: OSL language spec available
Gene Crucean <emailgene...@...>
Whoops, I see what I did.
toggle quoted messageShow quoted text
Thanks David
On Mon, Jan 11, 2010 at 11:34 AM, David Hawbaker <djhaw...@...> wrote: http://code.google.com/p/openshadinglanguage/downloads/list --
[Gene Crucean] - [VFX & CG Supervisor/Generalist] ** Freelance for hire **
|
|
Re: OSL language spec available
David Hawbaker <djhaw...@...>
http://code.google.com/p/openshadinglanguage/downloads/list
On Jan 11, 11:30 am, Gene Crucean <emailge...@...> wrote: Am I blind? If I click on "Files" I don't see any files listed. There is
|
|
Re: OSL language spec available
Gene Crucean <emailgene...@...>
Am I blind? If I click on "Files" I don't see any files listed. There is also no downloads link.
toggle quoted messageShow quoted text
On Mon, Jan 11, 2010 at 11:26 AM, Larry Gritz <larry...@...> wrote: On the "downloads" tab. --
[Gene Crucean] - [VFX & CG Supervisor/Generalist] ** Freelance for hire **
|
|