I'm going to commit this ASAP and then hunt for other possible occurrences. http://codereview.appspot.com/198076/show

LGTM! You might want to hunt for this pattern in a few other places. get/setmessage come to mind http://codereview.appspot.com/198076/show

Reviewers: , Description: In several string ops, I used a local var that just told whether any of the arguments were varying, to determine whether to assign to just the first element of Result, or

Sure, I guess I could. I figured that the constants from the oso file were probably beyond reproach, but since it doesn't cost anything, will do. -- lg -- Larry Gritz l...@...

That works for me. Maybe throw in Const too? (just in case of some weird oso parsing regression?) http://codereview.appspot.com/199063/show

LGTM, except for the previously existing bug http://codereview.appspot.com/199063/diff/1/3 File src/liboslexec/exec.cpp

Reviewers: , Description: Extend the inf/nan checking to also check (and print specific messages for) derivatives. Also, fixed a minor buglet that, for arrays, would only have checked the first

"polymorphic" appears exactly once in the docs, I have changed to "overloaded." No biggie. -- Larry Gritz l...@...

Reading these two http://en.wikipedia.org/wiki/Type_polymorphism http://www.haskell.org/haskellwiki/Ad-hoc_polymorphism suggests that what OSL provides is ad-hoc polymorphism, or otherwise known as

RSL and OSL both are able to overload functions by return type. So, do the terminology purists out there think that this makes it "polymorphic" or merely "overloaded"? -- lg -- Larry

I think one of the reasons for this extensive explanation was meant to make the point that functions cannot be overloaded only by return type, in contrast to RSL :) This, along with many other

I believe you are correct. Polymorphism should refer to types, what I was talking about is really "overloading." -- lg -- Larry Gritz l...@...

Hey guys, Reading through the OSL manual, on page 20 there's this paragraph: """Functions may be polymorphic. That is, multiple functions may be defined to have the same name, as long as they have

Good call on both counts. I will upload an updated review shortly. -- lg -- Larry Gritz l...@...

http://codereview.appspot.com/196066/diff/1/3 File src/liboslexec/exec.cpp (right): http://codereview.appspot.com/196066/diff/1/3#newcode345 src/liboslexec/exec.cpp:345: if (debugnan && check_nan

LGTM http://codereview.appspot.com/194147/show

Reviewers: osl-dev_googlegroups.com, Description: We were forgetting to set the pdf in the eval function, plus we were using the wrong cosine in its sampler. Please review this at

I included the project file for mcpp. I plan to generate a cmake file for it. I have updated the cmakefiles for osl to hopefully work better on windows. They assume that there is an thirdpartyhome

Part of the windows build now requires the use of MCPP to do the OSL preprocessing. There is a binary available but unfortunatly it doesn't support a necessary command line parameter. So I had to

Reviewers: , Description: At Chris Kulla's suggestion, expand our "debugnan" checking to include the binding step, to catch any bad values passed into the shading system. Please review this at