LGTM http://codereview.appspot.com/194117/show

LGTM2 Can't wait to see the difference on those benchmark cases. http://codereview.appspot.com/194117/show

Mcpp integrated pretty easily with the existing structure. I can send you the project I made for it. Unfortunatly I wasn't able to get it to build on vs with cpp syntax. I think it assumed some

OK, I committed it, so give it a try. This should throw into even more stark relief the waste associated with sparse runflags. I'll tackle that after "rebind" is

Reviewers: , Description: Bug fix: When a function's 'return' statement is not the last statement in the function body, we use a trick where we wrap the function in a 'do { ... } while (0)' and the

Reviewers: osl-dev_googlegroups.com, Description: There was a problem with the sample function in beckman closure. A missing sqrt for sampling the tangent of theta. It was preventing reflections from

LGTM http://codereview.appspot.com/196043/show

On this one, I'll have to take your word for it. LGTM! http://codereview.appspot.com/195084/show

Hi Jeremy, Sure, you can do it. It would be great. Oleg

Right before checking in, I noticed that the same mistake could happen for ordinary loops: while (1) { } or do { } while(0); I just fixed in in both places in the identical way. -- Larry

Reviewers: , Description: This change allows a debug mode (set by attribute("debugnan",1)) that checks every value written by each instruction, and if any nan or inf values are found, issues a

How about checking the results of geometry binding as well? Otherwise LGTM http://codereview.appspot.com/194142/show

You mean checking all the inputs? Sure. But let me check this one in first. -- Larry Gritz l...@...

Reviewers: , Description: At Chris Kulla's suggestion, expand our "debugnan" checking to include the binding step, to catch any bad values passed into the shading system. Please review this at

Part of the windows build now requires the use of MCPP to do the OSL preprocessing. There is a binary available but unfortunatly it doesn't support a necessary command line parameter. So I had to

I included the project file for mcpp. I plan to generate a cmake file for it. I have updated the cmakefiles for osl to hopefully work better on windows. They assume that there is an thirdpartyhome

Reviewers: osl-dev_googlegroups.com, Description: We were forgetting to set the pdf in the eval function, plus we were using the wrong cosine in its sampler. Please review this at

LGTM http://codereview.appspot.com/194147/show

http://codereview.appspot.com/196066/diff/1/3 File src/liboslexec/exec.cpp (right): http://codereview.appspot.com/196066/diff/1/3#newcode345 src/liboslexec/exec.cpp:345: if (debugnan && check_nan

Good call on both counts. I will upload an updated review shortly. -- lg -- Larry Gritz l...@...