|
"Polymorphic" in OSL manual
Hey guys,
Reading through the OSL manual, on page 20 there's this paragraph:
"""Functions may be polymorphic. That is, multiple functions may be defined to have the same name, as long as they have
Hey guys,
Reading through the OSL manual, on page 20 there's this paragraph:
"""Functions may be polymorphic. That is, multiple functions may be defined to have the same name, as long as they have
|
By
Blair Zajac <bl...@...>
·
#187
·
|
|
Re: "Polymorphic" in OSL manual
I believe you are correct. Polymorphism should refer to types, what I was talking about is really "overloading."
-- lg
--
Larry Gritz
l...@...
I believe you are correct. Polymorphism should refer to types, what I was talking about is really "overloading."
-- lg
--
Larry Gritz
l...@...
|
By
Larry Gritz <l...@...>
·
#188
·
|
|
Re: "Polymorphic" in OSL manual
I think one of the reasons for this extensive explanation was meant to
make the point that functions cannot be overloaded only by return
type, in contrast to RSL :) This, along with many other
I think one of the reasons for this extensive explanation was meant to
make the point that functions cannot be overloaded only by return
type, in contrast to RSL :) This, along with many other
|
By
Iliyan <iliyan....@...>
·
#189
·
|
|
Re: "Polymorphic" in OSL manual
RSL and OSL both are able to overload functions by return type.
So, do the terminology purists out there think that this makes it "polymorphic" or merely "overloaded"?
-- lg
--
Larry
RSL and OSL both are able to overload functions by return type.
So, do the terminology purists out there think that this makes it "polymorphic" or merely "overloaded"?
-- lg
--
Larry
|
By
Larry Gritz <l...@...>
·
#190
·
|
|
Re: "Polymorphic" in OSL manual
Reading these two
http://en.wikipedia.org/wiki/Type_polymorphism
http://www.haskell.org/haskellwiki/Ad-hoc_polymorphism
suggests that what OSL provides is ad-hoc polymorphism, or otherwise known as
Reading these two
http://en.wikipedia.org/wiki/Type_polymorphism
http://www.haskell.org/haskellwiki/Ad-hoc_polymorphism
suggests that what OSL provides is ad-hoc polymorphism, or otherwise known as
|
By
Blair Zajac <bl...@...>
·
#193
·
|
|
Re: "Polymorphic" in OSL manual
"polymorphic" appears exactly once in the docs, I have changed to "overloaded." No biggie.
--
Larry Gritz
l...@...
"polymorphic" appears exactly once in the docs, I have changed to "overloaded." No biggie.
--
Larry Gritz
l...@...
|
By
Larry Gritz <l...@...>
·
#194
·
|
|
Review: extend inf/nan checking to derivatives, fix problem with arrays (issue199063)
Reviewers: ,
Description:
Extend the inf/nan checking to also check (and print specific messages
for) derivatives. Also, fixed a minor buglet that, for arrays, would
only have checked the first
Reviewers: ,
Description:
Extend the inf/nan checking to also check (and print specific messages
for) derivatives. Also, fixed a minor buglet that, for arrays, would
only have checked the first
|
By
larry...@...
·
#197
·
|
|
Re: Review: extend inf/nan checking to derivatives, fix problem with arrays (issue199063)
LGTM, except for the previously existing bug
http://codereview.appspot.com/199063/diff/1/3
File src/liboslexec/exec.cpp
LGTM, except for the previously existing bug
http://codereview.appspot.com/199063/diff/1/3
File src/liboslexec/exec.cpp
|
By
cku...@...
·
#198
·
|
|
Re: Review: extend inf/nan checking to derivatives, fix problem with arrays (issue199063)
That works for me.
Maybe throw in Const too? (just in case of some weird oso parsing
regression?)
http://codereview.appspot.com/199063/show
That works for me.
Maybe throw in Const too? (just in case of some weird oso parsing
regression?)
http://codereview.appspot.com/199063/show
|
By
cku...@...
·
#199
·
|
|
Re: Review: extend inf/nan checking to derivatives, fix problem with arrays (issue199063)
Sure, I guess I could. I figured that the constants from the oso file were probably beyond reproach, but since it doesn't cost anything, will do.
-- lg
--
Larry Gritz
l...@...
Sure, I guess I could. I figured that the constants from the oso file were probably beyond reproach, but since it doesn't cost anything, will do.
-- lg
--
Larry Gritz
l...@...
|
By
Larry Gritz <l...@...>
·
#195
·
|
|
Review: broken string ops (issue198076)
Reviewers: ,
Description:
In several string ops, I used a local var that just told whether any of
the arguments were varying, to determine whether to assign to just the
first element of Result, or
Reviewers: ,
Description:
In several string ops, I used a local var that just told whether any of
the arguments were varying, to determine whether to assign to just the
first element of Result, or
|
By
larry...@...
·
#200
·
|
|
Re: Review: broken string ops (issue198076)
LGTM!
You might want to hunt for this pattern in a few other places.
get/setmessage come to mind
http://codereview.appspot.com/198076/show
LGTM!
You might want to hunt for this pattern in a few other places.
get/setmessage come to mind
http://codereview.appspot.com/198076/show
|
By
cku...@...
·
#201
·
|
|
Re: Review: broken string ops (issue198076)
I'm going to commit this ASAP and then hunt for other possible
occurrences.
http://codereview.appspot.com/198076/show
I'm going to commit this ASAP and then hunt for other possible
occurrences.
http://codereview.appspot.com/198076/show
|
By
larry...@...
·
#202
·
|
|
Review: broken getmessage (issue199069)
Reviewers: ,
Description:
In the same way as my last review for string ops, if getmessage had all
uniform args but was called from within a varying conditional, it could
fill in only the first value
Reviewers: ,
Description:
In the same way as my last review for string ops, if getmessage had all
uniform args but was called from within a varying conditional, it could
fill in only the first value
|
By
larry...@...
·
#203
·
|
|
Re: Review: broken getmessage (issue199069)
LGTM
But I still think there are additional corner cases to both setmessage
and getmessage that might be broken.
Overall the logic in these ops is quite hard to follow ... is there
anything we could
LGTM
But I still think there are additional corner cases to both setmessage
and getmessage that might be broken.
Overall the logic in these ops is quite hard to follow ... is there
anything we could
|
By
cku...@...
·
#204
·
|
|
Re: Review: broken getmessage (issue199069)
Which other cases do you think are broken?
I can try to simplify, but it's a fairly complicated set of moving parts. I'll see what I can do.
-- lg
--
Larry Gritz
l...@...
Which other cases do you think are broken?
I can try to simplify, but it's a fairly complicated set of moving parts. I'll see what I can do.
-- lg
--
Larry Gritz
l...@...
|
By
Larry Gritz <l...@...>
·
#196
·
|
|
primitive variables
Just wondering if you have thought about binding shader parameters to
geometry like you can with primitive variables in RenderMan.
Specifically - if you are going to do something like this - it
Just wondering if you have thought about binding shader parameters to
geometry like you can with primitive variables in RenderMan.
Specifically - if you are going to do something like this - it
|
By
Simon Bunker <si...@...>
·
#205
·
|
|
Re: primitive variables
Thanks for the email, Simon!
Yes, OSL already has primitive variables. I agree that it would be handy to have a built-in function that tells you if the particular value is the default, from a
Thanks for the email, Simon!
Yes, OSL already has primitive variables. I agree that it would be handy to have a built-in function that tells you if the particular value is the default, from a
|
By
Larry Gritz <l...@...>
·
#206
·
|
|
Re: run flags vs active intervals
OK, I've done some really interesting investigation the runflags issue. Chris Foster was very inspiring with his test program and span idea (which we've been debating versus Chris Kulla's similar
OK, I've done some really interesting investigation the runflags issue. Chris Foster was very inspiring with his test program and span idea (which we've been debating versus Chris Kulla's similar
|
By
Larry Gritz <l...@...>
·
#207
·
|
|
Re: run flags vs active intervals
Next installment of "everything you wanted to know about runflags but were afraid to ask."
So after sampling representative runflags from a frame with production shaders and assets, next I wrote a
Next installment of "everything you wanted to know about runflags but were afraid to ask."
So after sampling representative runflags from a frame with production shaders and assets, next I wrote a
|
By
Larry Gritz <l...@...>
·
#208
·
|