LGTM

But I still think there are additional corner cases to both setmessage
and getmessage that might be broken.

Overall the logic in these ops is quite hard to follow ... is there
anything we could do to simplify it?

http://codereview.appspot.com/199069/show

Which other cases do you think are broken?

I can try to simplify, but it's a fairly complicated set of moving parts. I'll see what I can do.

-- lg


On Feb 2, 2010, at 5:37 PM, <cku...@...> <cku...@...> wrote:

LGTM

But I still think there are additional corner cases to both setmessage
and getmessage that might be broken.

Overall the logic in these ops is quite hard to follow ... is there
anything we could do to simplify it?

http://codereview.appspot.com/199069/show

--
Larry Gritz
l...@...