Date
1 - 3 of 3
Review: extend inf/nan checking to derivatives, fix problem with arrays (issue199063)
larry...@...
Reviewers: ,
Description: Extend the inf/nan checking to also check (and print specific messages for) derivatives. Also, fixed a minor buglet that, for arrays, would only have checked the first element for inf/nan. Please review this at http://codereview.appspot.com/199063/show Affected files: src/liboslexec/exec.cpp src/liboslexec/oslexec_pvt.h |
|
cku...@...
LGTM, except for the previously existing bug
http://codereview.appspot.com/199063/diff/1/3 File src/liboslexec/exec.cpp (right): http://codereview.appspot.com/199063/diff/1/3#newcode346 src/liboslexec/exec.cpp:346: if (debugnan && check_nan (sym, m_context->m_original_runflags, There's a serious bug here I didn't notice in the first pass. We are checking the value of locals and temps that have not been initialized yet. This gives tons of false positives in actual scenes. http://codereview.appspot.com/199063/show |
|
cku...@...
That works for me.
Maybe throw in Const too? (just in case of some weird oso parsing regression?) http://codereview.appspot.com/199063/show |
|