LGTM, other than my comment about the Result derivs in optexture.cpp.
Thanks for fixing this.



http://codereview.appspot.com/238043/diff/1/2
File src/liboslexec/optexture.cpp (left):

http://codereview.appspot.com/238043/diff/1/2#oldcode291
src/liboslexec/optexture.cpp:291: if (Result.has_derivs())
Why is this no longer needed?

http://codereview.appspot.com/238043/diff/1/7
File src/liboslexec/oslops.h (right):

http://codereview.appspot.com/238043/diff/1/7#newcode288
src/liboslexec/oslops.h:288: # define SHADE_LOOP_EXIT { nspans_ = 1;
break; }
Clever!!! I was wondering how you were going to do that.

http://codereview.appspot.com/238043/show

http://codereview.appspot.com/238043/diff/1/2#oldcode291
src/liboslexec/optexture.cpp:291: if (Result.has_derivs())
Why is this no longer needed?

Because the result is an integer.



http://codereview.appspot.com/238043/show

Right. Duh. OK, all fine then.


On Mar 5, 2010, at 4:57 PM, <cku...@...> <cku...@...> wrote:

http://codereview.appspot.com/238043/diff/1/2#oldcode291
src/liboslexec/optexture.cpp:291: if (Result.has_derivs())
Why is this no longer needed?

Because the result is an integer.



http://codereview.appspot.com/238043/show

--
Larry Gritz
l...@...